| Message ID | 20200605073201.1742675-3-yangerkun@huawei.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | introduce interface to list all badblocks | expand |
On Fri, Jun 5, 2020 at 3:48 AM yangerkun <yangerkun@huawei.com> wrote: > > Since we support the listbadblocks command, introduce the detail in the > doc. > > Signed-off-by: yangerkun <yangerkun@huawei.com> Thank you for the documentation. I have a few corrections listed below: > --- > .../admin-guide/device-mapper/dm-dust.rst | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/admin-guide/device-mapper/dm-dust.rst b/Documentation/admin-guide/device-mapper/dm-dust.rst > index b6e7e7ead831..185b3ce6298b 100644 > --- a/Documentation/admin-guide/device-mapper/dm-dust.rst > +++ b/Documentation/admin-guide/device-mapper/dm-dust.rst > @@ -205,6 +205,21 @@ appear:: > > kernel: device-mapper: dust: clearbadblocks: no badblocks found > > +Listling the bad block list "Listing the bad block list" > +--------------------------- > + > +To list all bad block list, run the following message command:: "To list all bad blocks in the bad block list" > + > + $ sudo dmsetup message dust1 0 listbadblocks > + > +We will get following message(image that we have insert block 1/2, and > +we will list the block index in order):: "The following message will appear, listing one bad block number per line (using an example device with blocks 1 and 2 in the bad block list)" After those corrections are made, Reviewed-by: Bryan Gurney <bgurney@redhat.com> Thanks, Bryan > + > + device-mapper: dust: dust_list_badblocks: badblocks list as below: > + device-mapper: dust: bad block: 1 > + device-mapper: dust: bad block: 2 > + device-mapper: dust: dust_list_badblocks: badblocks list end. > + > Message commands list > --------------------- > > @@ -223,6 +238,7 @@ Single argument message commands:: > > countbadblocks > clearbadblocks > + listbadblocks > disable > enable > quiet > -- > 2.25.4 > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
在 2020/6/6 3:47, Bryan Gurney 写道: > On Fri, Jun 5, 2020 at 3:48 AM yangerkun <yangerkun@huawei.com> wrote: >> >> Since we support the listbadblocks command, introduce the detail in the >> doc. >> >> Signed-off-by: yangerkun <yangerkun@huawei.com> > > Thank you for the documentation. I have a few corrections listed below: > >> --- >> .../admin-guide/device-mapper/dm-dust.rst | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/admin-guide/device-mapper/dm-dust.rst b/Documentation/admin-guide/device-mapper/dm-dust.rst >> index b6e7e7ead831..185b3ce6298b 100644 >> --- a/Documentation/admin-guide/device-mapper/dm-dust.rst >> +++ b/Documentation/admin-guide/device-mapper/dm-dust.rst >> @@ -205,6 +205,21 @@ appear:: >> >> kernel: device-mapper: dust: clearbadblocks: no badblocks found >> >> +Listling the bad block list > > "Listing the bad block list" > >> +--------------------------- >> + >> +To list all bad block list, run the following message command:: > > "To list all bad blocks in the bad block list" > >> + >> + $ sudo dmsetup message dust1 0 listbadblocks >> + >> +We will get following message(image that we have insert block 1/2, and >> +we will list the block index in order):: > > "The following message will appear, listing one bad block number per > line (using an example device with blocks 1 and 2 in the bad block > list)" > > After those corrections are made, > > Reviewed-by: Bryan Gurney <bgurney@redhat.com> Thanks for your advise for this series, I will fix it and send v2 with your review tag! Thanks, Kun. > > > Thanks, > > Bryan > > > >> + >> + device-mapper: dust: dust_list_badblocks: badblocks list as below: >> + device-mapper: dust: bad block: 1 >> + device-mapper: dust: bad block: 2 >> + device-mapper: dust: dust_list_badblocks: badblocks list end. >> + >> Message commands list >> --------------------- >> >> @@ -223,6 +238,7 @@ Single argument message commands:: >> >> countbadblocks >> clearbadblocks >> + listbadblocks >> disable >> enable >> quiet >> -- >> 2.25.4 >> > > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/Documentation/admin-guide/device-mapper/dm-dust.rst b/Documentation/admin-guide/device-mapper/dm-dust.rst index b6e7e7ead831..185b3ce6298b 100644 --- a/Documentation/admin-guide/device-mapper/dm-dust.rst +++ b/Documentation/admin-guide/device-mapper/dm-dust.rst @@ -205,6 +205,21 @@ appear:: kernel: device-mapper: dust: clearbadblocks: no badblocks found +Listling the bad block list +--------------------------- + +To list all bad block list, run the following message command:: + + $ sudo dmsetup message dust1 0 listbadblocks + +We will get following message(image that we have insert block 1/2, and +we will list the block index in order):: + + device-mapper: dust: dust_list_badblocks: badblocks list as below: + device-mapper: dust: bad block: 1 + device-mapper: dust: bad block: 2 + device-mapper: dust: dust_list_badblocks: badblocks list end. + Message commands list --------------------- @@ -223,6 +238,7 @@ Single argument message commands:: countbadblocks clearbadblocks + listbadblocks disable enable quiet
Since we support the listbadblocks command, introduce the detail in the doc. Signed-off-by: yangerkun <yangerkun@huawei.com> --- .../admin-guide/device-mapper/dm-dust.rst | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)