| Message ID | 1591350221-32275-1-git-send-email-zhangshaokun@hisilicon.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 961abd78adcb4c72c343fcd9f9dc5e2ebbe9b448 |
| Headers | show |
| Series | drivers/perf: hisi: Fix wrong value for all counters enable | expand |
On Fri, 5 Jun 2020 17:43:41 +0800, Shaokun Zhang wrote: > In L3C uncore PMU drivers, bit16 is used to control all counters enable & > disable. Wrong value is given in the driver and its default value is 1'b1, > it can work because each PMU counter has its own control bits too. > Let's fix the wrong value. Applied to arm64 (for-next/core), thanks! [1/1] drivers/perf: hisi: Fix wrong value for all counters enable https://git.kernel.org/arm64/c/961abd78adcb Cheers,
Thanks Will. 在 2020/6/8 23:17, Will Deacon 写道: > On Fri, 5 Jun 2020 17:43:41 +0800, Shaokun Zhang wrote: >> In L3C uncore PMU drivers, bit16 is used to control all counters enable & >> disable. Wrong value is given in the driver and its default value is 1'b1, >> it can work because each PMU counter has its own control bits too. >> Let's fix the wrong value. > > Applied to arm64 (for-next/core), thanks! > > [1/1] drivers/perf: hisi: Fix wrong value for all counters enable > https://git.kernel.org/arm64/c/961abd78adcb > > Cheers, >
diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c index 8dd1278bec04..7719ae4e2c56 100644 --- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c +++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c @@ -35,7 +35,7 @@ /* L3C has 8-counters */ #define L3C_NR_COUNTERS 0x8 -#define L3C_PERF_CTRL_EN 0x20000 +#define L3C_PERF_CTRL_EN 0x10000 #define L3C_EVTYPE_NONE 0xff /*
In L3C uncore PMU drivers, bit16 is used to control all counters enable & disable. Wrong value is given in the driver and its default value is 1'b1, it can work because each PMU counter has its own control bits too. Let's fix the wrong value. Fixes: 2940bc433370 ("perf: hisi: Add support for HiSilicon SoC L3C PMU driver") Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> --- drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)