| Message ID | 20200608160044.15531-24-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/qdev: Warn when using pre-qdev/QOM devices | expand |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/misc/applesmc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c > index 1c4addb201..d63f19038d 100644 > --- a/hw/misc/applesmc.c > +++ b/hw/misc/applesmc.c > @@ -36,6 +36,7 @@ > #include "ui/console.h" > #include "qemu/module.h" > #include "qemu/timer.h" > +#include "hw/qdev-deprecated.h" > > /* #define DEBUG_SMC */ > > @@ -253,6 +254,8 @@ static void applesmc_add_key(AppleSMCState *s, const char *key, > { > struct AppleSMCData *def; > > + qdev_warn_deprecated_function_used(); > + > def = g_malloc0(sizeof(struct AppleSMCData)); > def->key = key; > def->len = len; > This one is okay. Paolo
diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 1c4addb201..d63f19038d 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -36,6 +36,7 @@ #include "ui/console.h" #include "qemu/module.h" #include "qemu/timer.h" +#include "hw/qdev-deprecated.h" /* #define DEBUG_SMC */ @@ -253,6 +254,8 @@ static void applesmc_add_key(AppleSMCState *s, const char *key, { struct AppleSMCData *def; + qdev_warn_deprecated_function_used(); + def = g_malloc0(sizeof(struct AppleSMCData)); def->key = key; def->len = len;
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/misc/applesmc.c | 3 +++ 1 file changed, 3 insertions(+)