| Message ID | 20200521192133.127559-1-hskinnemoen@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines | expand |
Patchew URL: https://patchew.org/QEMU/20200521192133.127559-1-hskinnemoen@google.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
Broken pipe
/tmp/qemu-test/src/tests/qtest/libqtest.c:166: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0)
TEST iotest-qcow2: 089
ERROR - too few tests run (expected 68, got 21)
make: *** [check-qtest-aarch64] Error 1
make: *** Waiting for unfinished jobs....
TEST iotest-qcow2: 090
TEST iotest-qcow2: 097
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=935cc7f201a94a2e865cf081636a2cf4', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-evkby52n/src/docker-src.2020-05-22-00.39.52.17361:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=935cc7f201a94a2e865cf081636a2cf4
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-evkby52n/src'
make: *** [docker-run-test-quick@centos7] Error 2
real 17m34.256s
user 0m9.006s
The full log is available at
http://patchew.org/logs/20200521192133.127559-1-hskinnemoen@google.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Thu, May 21, 2020 at 12:21 PM Havard Skinnemoen <hskinnemoen@google.com> wrote: > This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to > boot > a minimal Linux kernel. This includes device models for: > Does anyone have comments on this series? I'm currently finishing up a second patch series that adds flash support and a few other things so qemu can boot a full OpenBMC flash image built for npcm7xx. If you prefer, I can combine them both into one series and send it to the list. This series can be found here: https://patchwork.kernel.org/project/qemu-devel/list/?series=291809 Thanks, Havard
On Mon, 8 Jun 2020 at 22:15, Havard Skinnemoen <hskinnemoen@google.com> wrote: > > On Thu, May 21, 2020 at 12:21 PM Havard Skinnemoen <hskinnemoen@google.com> wrote: >> >> This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to boot >> a minimal Linux kernel. This includes device models for: > > > Does anyone have comments on this series? I'm currently finishing up a second patch series that adds flash support and a few other things so qemu can boot a full OpenBMC flash image built for npcm7xx. I had a look and they appear good to me. Note that I'm less in to the gory details of Qemu than some of our other reviewers, so you should seek a more detailed review from someone else. I look forward further support so I can test the OpenBMC kernel against Nuvoton boards in the same way as the Aspeed ones. Cheers, Joel > > If you prefer, I can combine them both into one series and send it to the list. > > This series can be found here: https://patchwork.kernel.org/project/qemu-devel/list/?series=291809 > > Thanks, > > Havard
On 6/9/20 12:14 AM, Havard Skinnemoen wrote: > On Thu, May 21, 2020 at 12:21 PM Havard Skinnemoen <hskinnemoen@google.com <mailto:hskinnemoen@google.com>> wrote: > > This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to boot > a minimal Linux kernel. This includes device models for: > > > Does anyone have comments on this series? I'm currently finishing up a second patch series that adds flash support and a few other things so qemu can boot a full OpenBMC flash image built for npcm7xx. > > If you prefer, I can combine them both into one series and send it to the list. The first series was nicely presented I think, but you can extend it in v2. Documentation needs an update in : docs/system/target-arm.rst Thanks, C.
On Tue, 9 Jun 2020 at 08:31, Cédric Le Goater <clg@kaod.org> wrote: > The first series was nicely presented I think, but you can extend it in v2. > Documentation needs an update in : > > docs/system/target-arm.rst To expand on that: the new boards should have at least some basic documentation in a new docs/system/arm/something.rst (we have one .rst file usually for each "family" of boards which are similar enough to make sense to document as a group), which is added to the toctree in target-arm.rst (note that it is supposed to be kept in alpha-order-of-document-title-text). aspeed.rst should give an idea of what ought to be documented: a basic summary of what the machine is, what is supported, what is not implemented, any machine options that the board has, that sort of thing. thanks -- PMM
On Tue, Jun 9, 2020 at 2:38 AM Peter Maydell <peter.maydell@linaro.org> wrote: > On Tue, 9 Jun 2020 at 08:31, Cédric Le Goater <clg@kaod.org> wrote: > > The first series was nicely presented I think, but you can extend it in > v2. > > Documentation needs an update in : > > > > docs/system/target-arm.rst > > To expand on that: the new boards should have at least some basic > documentation in a new docs/system/arm/something.rst (we have > one .rst file usually for each "family" of boards which are > similar enough to make sense to document as a group), which is > added to the toctree in target-arm.rst (note that it is supposed > to be kept in alpha-order-of-document-title-text). aspeed.rst should > give an idea of what ought to be documented: a basic summary of > what the machine is, what is supported, what is not implemented, > any machine options that the board has, that sort of thing. > Thanks for the feedback. I will include documentation in v2 of this patchset, and also address your other comments. Havard
On Mon, Jun 8, 2020 at 6:39 PM Joel Stanley <joel@jms.id.au> wrote: > I had a look and they appear good to me. Note that I'm less in to the > gory details of Qemu than some of our other reviewers, so you should > seek a more detailed review from someone else. > > I look forward further support so I can test the OpenBMC kernel > against Nuvoton boards in the same way as the Aspeed ones. > Great to hear that, and thanks for your review. I hope to post an updated patchset soon. Havard