| Message ID | 20200530073418.577210-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3bab76807d952aaed4209d80fa3389517c2a1d37 |
| Headers | show |
| Series | scsi: eesox: Fix different dev_id between 'request_irq()' and 'free_irq()' | expand |
On Sat, 30 May 2020 09:34:18 +0200, Christophe JAILLET wrote: > The dev_id used in 'request_irq()' and 'free_irq()' should match. > So use 'host' in both cases. Applied to 5.8/scsi-queue, thanks! [1/1] scsi: eesox: Fix different dev_id between request_irq() and free_irq() https://git.kernel.org/mkp/scsi/c/3bab76807d95
Le 10/06/2020 à 04:41, Martin K. Petersen a écrit : > On Sat, 30 May 2020 09:34:18 +0200, Christophe JAILLET wrote: > >> The dev_id used in 'request_irq()' and 'free_irq()' should match. >> So use 'host' in both cases. > Applied to 5.8/scsi-queue, thanks! > > [1/1] scsi: eesox: Fix different dev_id between request_irq() and free_irq() > https://git.kernel.org/mkp/scsi/c/3bab76807d95 > Please revert, the patch is bogus, as spotted by Russell King - ARM Linux admin <linux@armlinux.org.uk>. See [1]. I'll try to send the correct fix by this week-end. CJ [1]: https://marc.info/?l=linux-scsi&m=159083184215730&w=4
diff --git a/drivers/scsi/arm/eesox.c b/drivers/scsi/arm/eesox.c index 6e204a2e0c8d..af0bb401ca23 100644 --- a/drivers/scsi/arm/eesox.c +++ b/drivers/scsi/arm/eesox.c @@ -546,7 +546,7 @@ static int eesoxscsi_probe(struct expansion_card *ec, const struct ecard_id *id) if (ret) goto out_free; - ret = request_irq(ec->irq, eesoxscsi_intr, 0, "eesoxscsi", info); + ret = request_irq(ec->irq, eesoxscsi_intr, 0, "eesoxscsi", host); if (ret) { printk("scsi%d: IRQ%d not free: %d\n", host->host_no, ec->irq, ret);
The dev_id used in 'request_irq()' and 'free_irq()' should match. So use 'host' in both cases. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/scsi/arm/eesox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)