[1/1] MAINTAINERS: Adjust sh4 maintainership

Commit Message

Aleksandar Markovic June 10, 2020, 10:17 p.m. UTC

This patch transfers sh4 sections to Yoshinori Sato, who is best
positioned in the community to assume their maintainership. He is
the maintainer of the related target rx.

Further adjustments, reorganizations, and improvements of sh4
sections are left to the future maintainer to be devised and
executed, as he deems suitable.

Aurealien and Magnus are deleted from some sections from the
MAINTAINERS file with this patch. However, they will not be
deleted from QEMU Hall of Fame, where their names will always
be carved in stone as QEMU pioneers and granddadies.

Acked-by: Aurelien Jarno <[e-mail]>
Acked-by: Magnus Damm <[e-mail]>
Acked-by: Yoshinori Sato <[e-mail]>
Signed-off-by: Aleksandar Markovic <[e-mail]>
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Philippe Mathieu-Daudé June 10, 2020, 10:51 p.m. UTC | #1

On 6/11/20 12:17 AM, Aleksandar Markovic wrote:
> This patch transfers sh4 sections to Yoshinori Sato, who is best
> positioned in the community to assume their maintainership.

https://www.mail-archive.com/[e-mail]/msg708235.html

"BTW, you also dictate there Yoshimoto that to do and
 what not to do. Why?"

I suppose you meant Yoshinori? Again I'm didn't want to appear
as dictating, I spend hours trying to raise the quality of the
RX hardware model to be sure it'd be merged. You can not say
otherwise, see the latest series posted:
https://www.mail-archive.com/[e-mail]/msg708317.html

We can not say likewise with the AVR port you almost killed,
asking changes then disappearing, letting other contributors
stuck.

> He is
> the maintainer of the related target rx.
> 
> Further adjustments, reorganizations, and improvements of sh4
> sections are left to the future maintainer to be devised and
> executed, as he deems suitable.
> 
> Aurealien and Magnus are deleted from some sections from the

Typo 'Aurelien'.

> MAINTAINERS file with this patch. However, they will not be
> deleted from QEMU Hall of Fame, where their names will always
> be carved in stone as QEMU pioneers and granddadies.

Typo 'granddaddies'.

> 
> Acked-by: Aurelien Jarno <[e-mail]>
> Acked-by: Magnus Damm <[e-mail]>
> Acked-by: Yoshinori Sato <[e-mail]>
> Signed-off-by: Aleksandar Markovic <[e-mail]>
> ---
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6e7890ce82..7ddb6db38c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -296,7 +296,7 @@ F: tests/tcg/s390x/
>  L: [e-mail]
>  
>  SH4 TCG CPUs
> -M: Aurelien Jarno <[e-mail]>
> +M: Yoshinori Sato <[e-mail]>
>  S: Odd Fixes

'Maintained'? See:

https://www.mail-archive.com/[e-mail]/msg710928.html

>  F: target/sh4/
>  F: hw/sh4/
> @@ -1251,14 +1251,14 @@ F: include/hw/riscv/opentitan.h
>  SH4 Machines
>  ------------
>  R2D
> -M: Magnus Damm <[e-mail]>
> +M: Yoshinori Sato <[e-mail]>
>  S: Maintained
>  F: hw/sh4/r2d.c
>  F: hw/intc/sh_intc.c
>  F: hw/timer/sh_timer.c
>  
>  Shix
> -M: Magnus Damm <[e-mail]>
> +M: Yoshinori Sato <[e-mail]>
>  S: Odd Fixes

Ditto 'Maintained'?

Whichever status Yoshinori like:
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>

>  F: hw/sh4/shix.c
>  
>

Aleksandar Markovic June 10, 2020, 11:41 p.m. UTC | #2

чет, 11. јун 2020. у 00:51 Philippe Mathieu-Daudé <[e-mail]> је
написао/ла:
>
> On 6/11/20 12:17 AM, Aleksandar Markovic wrote:
> > This patch transfers sh4 sections to Yoshinori Sato, who is best
> > positioned in the community to assume their maintainership.
>
> https://www.mail-archive.com/[e-mail]/msg708235.html
>
> "BTW, you also dictate there Yoshimoto that to do and
>  what not to do. Why?"
>
> I suppose you meant Yoshinori? Again I'm didn't want to appear
> as dictating, I spend hours trying to raise the quality of the
> RX hardware model to be sure it'd be merged. You can not say
> otherwise, see the latest series posted:
> https://www.mail-archive.com/[e-mail]/msg708317.html
>
> We can not say likewise with the AVR port you almost killed,
> asking changes then disappearing, letting other contributors
> stuck.
>
> > He is
> > the maintainer of the related target rx.
> >
> > Further adjustments, reorganizations, and improvements of sh4
> > sections are left to the future maintainer to be devised and
> > executed, as he deems suitable.
> >
> > Aurealien and Magnus are deleted from some sections from the
>
> Typo 'Aurelien'.
>
> > MAINTAINERS file with this patch. However, they will not be
> > deleted from QEMU Hall of Fame, where their names will always
> > be carved in stone as QEMU pioneers and granddadies.
>
> Typo 'granddaddies'.
>
> >
> > Acked-by: Aurelien Jarno <[e-mail]>
> > Acked-by: Magnus Damm <[e-mail]>
> > Acked-by: Yoshinori Sato <[e-mail]>
> > Signed-off-by: Aleksandar Markovic <[e-mail]>
> > ---
> >  MAINTAINERS | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6e7890ce82..7ddb6db38c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -296,7 +296,7 @@ F: tests/tcg/s390x/
> >  L: [e-mail]
> >
> >  SH4 TCG CPUs
> > -M: Aurelien Jarno <[e-mail]>
> > +M: Yoshinori Sato <[e-mail]>
> >  S: Odd Fixes
>
> 'Maintained'? See:
>
> https://www.mail-archive.com/[e-mail]/msg710928.html
>
> >  F: target/sh4/
> >  F: hw/sh4/
> > @@ -1251,14 +1251,14 @@ F: include/hw/riscv/opentitan.h
> >  SH4 Machines
> >  ------------
> >  R2D
> > -M: Magnus Damm <[e-mail]>
> > +M: Yoshinori Sato <[e-mail]>
> >  S: Maintained
> >  F: hw/sh4/r2d.c
> >  F: hw/intc/sh_intc.c
> >  F: hw/timer/sh_timer.c
> >
> >  Shix
> > -M: Magnus Damm <[e-mail]>
> > +M: Yoshinori Sato <[e-mail]>
> >  S: Odd Fixes
>
> Ditto 'Maintained'?
>
> Whichever status Yoshinori like:
> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
>

Thank you!

> >  F: hw/sh4/shix.c
> >
> >
>

Thomas Huth June 11, 2020, 8:25 a.m. UTC | #3

On 11/06/2020 00.17, Aleksandar Markovic wrote:
> This patch transfers sh4 sections to Yoshinori Sato, who is best
> positioned in the community to assume their maintainership. He is
> the maintainer of the related target rx.
> 
> Further adjustments, reorganizations, and improvements of sh4
> sections are left to the future maintainer to be devised and
> executed, as he deems suitable.
> 
> Aurealien and Magnus are deleted from some sections from the
> MAINTAINERS file with this patch. However, they will not be
> deleted from QEMU Hall of Fame, where their names will always
> be carved in stone as QEMU pioneers and granddadies.
> 
> Acked-by: Aurelien Jarno <[e-mail]>
> Acked-by: Magnus Damm <[e-mail]>
> Acked-by: Yoshinori Sato <[e-mail]>

They more or less "acked" Philippe's patch, but I don't think you can
conclude from that that they agree to your changes automatically, too.
So please don't put "Acked-by"s into your completely new patch that you
did not gather yourself.

> Signed-off-by: Aleksandar Markovic <[e-mail]>
> ---
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6e7890ce82..7ddb6db38c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -296,7 +296,7 @@ F: tests/tcg/s390x/
>  L: [e-mail]
>  
>  SH4 TCG CPUs
> -M: Aurelien Jarno <[e-mail]>
> +M: Yoshinori Sato <[e-mail]>
>  S: Odd Fixes
>  F: target/sh4/
>  F: hw/sh4/
> @@ -1251,14 +1251,14 @@ F: include/hw/riscv/opentitan.h
>  SH4 Machines
>  ------------
>  R2D
> -M: Magnus Damm <[e-mail]>
> +M: Yoshinori Sato <[e-mail]>
>  S: Maintained
>  F: hw/sh4/r2d.c
>  F: hw/intc/sh_intc.c
>  F: hw/timer/sh_timer.c

Magnus said that he is still interested in R2D, just does not have the
time anymore to actively maintain it. So I think it is a bad idea if you
completely remove him here. His line should be changed from "M:" to "R:"
instead unless he explicitely states that he wants to completely be removed.

 Thomas

Aleksandar Markovic June 11, 2020, 9:19 a.m. UTC | #4

чет, 11. јун 2020. у 10:25 Thomas Huth <[e-mail]> је написао/ла:
>
> On 11/06/2020 00.17, Aleksandar Markovic wrote:
> > This patch transfers sh4 sections to Yoshinori Sato, who is best
> > positioned in the community to assume their maintainership. He is
> > the maintainer of the related target rx.
> >
> > Further adjustments, reorganizations, and improvements of sh4
> > sections are left to the future maintainer to be devised and
> > executed, as he deems suitable.
> >
> > Aurealien and Magnus are deleted from some sections from the
> > MAINTAINERS file with this patch. However, they will not be
> > deleted from QEMU Hall of Fame, where their names will always
> > be carved in stone as QEMU pioneers and granddadies.
> >
> > Acked-by: Aurelien Jarno <[e-mail]>
> > Acked-by: Magnus Damm <[e-mail]>
> > Acked-by: Yoshinori Sato <[e-mail]>
>
> They more or less "acked" Philippe's patch, but I don't think you can
> conclude from that that they agree to your changes automatically, too.
> So please don't put "Acked-by"s into your completely new patch that you
> did not gather yourself.
>

I disagree. I carefully studied their responses and they, as a rule, acked-by
the general approach, not a particular patch. I will keep Acked-by:s unless
some of them objects.

> > Signed-off-by: Aleksandar Markovic <[e-mail]>
> > ---
> >  MAINTAINERS | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6e7890ce82..7ddb6db38c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -296,7 +296,7 @@ F: tests/tcg/s390x/
> >  L: [e-mail]
> >
> >  SH4 TCG CPUs
> > -M: Aurelien Jarno <[e-mail]>
> > +M: Yoshinori Sato <[e-mail]>
> >  S: Odd Fixes
> >  F: target/sh4/
> >  F: hw/sh4/
> > @@ -1251,14 +1251,14 @@ F: include/hw/riscv/opentitan.h
> >  SH4 Machines
> >  ------------
> >  R2D
> > -M: Magnus Damm <[e-mail]>
> > +M: Yoshinori Sato <[e-mail]>
> >  S: Maintained
> >  F: hw/sh4/r2d.c
> >  F: hw/intc/sh_intc.c
> >  F: hw/timer/sh_timer.c
>
> Magnus said that he is still interested in R2D, just does not have the
> time anymore to actively maintain it. So I think it is a bad idea if you
> completely remove him here. His line should be changed from "M:" to "R:"
> instead unless he explicitely states that he wants to completely be removed.
>

Fair enough. I will mention him as R: in the next version.

Thanks,
Aleksandar

>  Thomas
>

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 6e7890ce82..7ddb6db38c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -296,7 +296,7 @@  F: tests/tcg/s390x/
 L: [e-mail]
 
 SH4 TCG CPUs
-M: Aurelien Jarno <[e-mail]>
+M: Yoshinori Sato <[e-mail]>
 S: Odd Fixes
 F: target/sh4/
 F: hw/sh4/
@@ -1251,14 +1251,14 @@  F: include/hw/riscv/opentitan.h
 SH4 Machines
 ------------
 R2D
-M: Magnus Damm <[e-mail]>
+M: Yoshinori Sato <[e-mail]>
 S: Maintained
 F: hw/sh4/r2d.c
 F: hw/intc/sh_intc.c
 F: hw/timer/sh_timer.c
 
 Shix
-M: Magnus Damm <[e-mail]>
+M: Yoshinori Sato <[e-mail]>
 S: Odd Fixes
 F: hw/sh4/shix.c