mbox series

[v3,0/8] Enable HDR on MCA LSPCON based Gen9 devices

Message ID 20200610191232.11620-1-uma.shankar@intel.com (mailing list archive)
Headers show
Series Enable HDR on MCA LSPCON based Gen9 devices | expand

Message

Shankar, Uma June 10, 2020, 7:12 p.m. UTC
Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR
support for MCA and Parade LSPCON based GEN9 devices.

SOC will drive LSPCON as DP and send HDR metadata as standard
DP SDP packets. LSPCON will be set to operate in PCON mode,
will receive the metadata and create Dynamic Range and
Mastering Infoframe (DRM packets) and send it to HDR capable
HDMI sink devices.

v2: Fixed Ville's review comments. Suppressed some warnings.
Patch 8 of the series is marked "Not for Merge" and is just for
reference to userspace people to incorporate in order to support
10bit content with 4K@60 resolutions.

v3: Added Infoframe readout support for DRM infoframes.
Addressed Jani Nikula's review comments.

Note: Patch 8 of the series is for reference to userspace, not to be
merged to driver.

Uma Shankar (8):
  drm/i915/display: Add HDR Capability detection for LSPCON
  drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon
  drm/i915/display: Attach HDR property for capable Gen9 devices
  drm/i915/display: Enable BT2020 for HDR on LSPCON devices
  drm/i915/display: Enable HDR for Parade based lspcon
  drm/i915/display: Implement infoframes readback for LSPCON
  drm/i915/display: Implement DRM infoframe read for LSPCON
  drm/i915/display: [NOT FOR MERGE] Reduce blanking to support
    4k60@10bpp for LSPCON

 .../drm/i915/display/intel_display_types.h    |   1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  17 ++
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  20 +++
 drivers/gpu/drm/i915/display/intel_lspcon.c   | 158 ++++++++++++++++--
 drivers/gpu/drm/i915/display/intel_lspcon.h   |   9 +-
 5 files changed, 189 insertions(+), 16 deletions(-)

Comments

Shankar, Uma June 11, 2020, 5:08 a.m. UTC | #1
> -----Original Message-----
> From: Patchwork <patchwork@emeril.freedesktop.org>
> Sent: Thursday, June 11, 2020 1:22 AM
> To: Shankar, Uma <uma.shankar@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ Fi.CI.BAT: failure for Enable HDR on MCA LSPCON based Gen9 devices
> (rev3)
> 
> == Series Details ==
> 
> Series: Enable HDR on MCA LSPCON based Gen9 devices (rev3)
> URL   : https://patchwork.freedesktop.org/series/68081/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8611 -> Patchwork_17922
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_17922 absolutely need to be
>   verified manually.
> 
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_17922, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_17922/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_17922:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_exec_suspend@basic-s3:
>     - fi-tgl-u2:          NOTRUN -> [FAIL][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-tgl-
> u2/igt@gem_exec_suspend@basic-s3.html

Hi Lakshmi,
This failure doesn't seem to be related to my changes. Can you please check and help report.

Regards,
Uma Shankar

> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_17922 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@i915_pm_rpm@module-reload:
>     - fi-byt-j1900:       [PASS][2] -> [DMESG-WARN][3] ([i915#1982])
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-byt-
> j1900/igt@i915_pm_rpm@module-reload.html
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-byt-
> j1900/igt@i915_pm_rpm@module-reload.html
> 
> 
> #### Possible fixes ####
> 
>   * igt@i915_pm_rpm@module-reload:
>     - fi-cml-s:           [DMESG-WARN][4] ([i915#1982]) -> [PASS][5]
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-cml-
> s/igt@i915_pm_rpm@module-reload.html
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-cml-
> s/igt@i915_pm_rpm@module-reload.html
> 
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>     - fi-bsw-n3050:       [DMESG-WARN][6] ([i915#1982]) -> [PASS][7]
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-bsw-
> n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-bsw-
> n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>     - fi-bsw-kefka:       [DMESG-WARN][8] ([i915#1982]) -> [PASS][9]
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-bsw-
> kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-bsw-
> kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
> 
> 
> #### Warnings ####
> 
>   * igt@gem_exec_suspend@basic-s0:
>     - fi-kbl-x1275:       [DMESG-WARN][10] ([i915#62] / [i915#92]) -> [DMESG-
> WARN][11] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-kbl-
> x1275/igt@gem_exec_suspend@basic-s0.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-kbl-
> x1275/igt@gem_exec_suspend@basic-s0.html
> 
>   * igt@kms_flip@basic-flip-vs-modeset@a-dp1:
>     - fi-kbl-x1275:       [DMESG-WARN][12] ([i915#62] / [i915#92]) -> [DMESG-
> WARN][13] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-kbl-
> x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-kbl-
> x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
> 
>   * igt@kms_force_connector_basic@force-edid:
>     - fi-kbl-x1275:       [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) ->
> [DMESG-WARN][15] ([i915#62] / [i915#92]) +8 similar issues
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-kbl-
> x1275/igt@kms_force_connector_basic@force-edid.html
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-kbl-
> x1275/igt@kms_force_connector_basic@force-edid.html
> 
> 
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
>   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
>   [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
>   [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
> 
> 
> Participating hosts (48 -> 43)
> ------------------------------
> 
>   Additional (2): fi-kbl-7560u fi-tgl-u2
>   Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-
> byt-clapper fi-bdw-samus
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_8611 -> Patchwork_17922
> 
>   CI-20190529: 20190529
>   CI_DRM_8611: b87354483fa40fef86da19ade9bfe9349f0cf6d5 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5702: d16ad07e7f2a028e14d61f570931c87fa5ce404c @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_17922: 0903ebe28a8fb9c912916613977b2e77d83eac8c @
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> 0903ebe28a8f drm/i915/display: [NOT FOR MERGE] Reduce blanking to support
> 4k60@10bpp for LSPCON e67c4219c55f drm/i915/display: Implement DRM
> infoframe read for LSPCON 90fe2351734a drm/i915/display: Implement
> infoframes readback for LSPCON 7aab4641b28f drm/i915/display: Enable HDR for
> Parade based lspcon
> e71a13eb3147 drm/i915/display: Enable BT2020 for HDR on LSPCON devices
> 5940d801abf4 drm/i915/display: Attach HDR property for capable Gen9 devices
> ae1436b72a1c drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon
> 292e80f577e6 drm/i915/display: Add HDR Capability detection for LSPCON
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_17922/index.html
Vudum, Lakshminarayana June 11, 2020, 5:51 a.m. UTC | #2
Results are re-reported.

-----Original Message-----
From: Shankar, Uma <uma.shankar@intel.com> 
Sent: Thursday, June 11, 2020 8:08 AM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: RE: ✗ Fi.CI.BAT: failure for Enable HDR on MCA LSPCON based Gen9 devices (rev3)



> -----Original Message-----
> From: Patchwork <patchwork@emeril.freedesktop.org>
> Sent: Thursday, June 11, 2020 1:22 AM
> To: Shankar, Uma <uma.shankar@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ Fi.CI.BAT: failure for Enable HDR on MCA LSPCON based Gen9 
> devices
> (rev3)
> 
> == Series Details ==
> 
> Series: Enable HDR on MCA LSPCON based Gen9 devices (rev3)
> URL   : https://patchwork.freedesktop.org/series/68081/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8611 -> Patchwork_17922 
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_17922 absolutely need to be
>   verified manually.
> 
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_17922, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_17922/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_17922:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_exec_suspend@basic-s3:
>     - fi-tgl-u2:          NOTRUN -> [FAIL][1]
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-tgl-
> u2/igt@gem_exec_suspend@basic-s3.html

Hi Lakshmi,
This failure doesn't seem to be related to my changes. Can you please check and help report.

Regards,
Uma Shankar

> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_17922 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@i915_pm_rpm@module-reload:
>     - fi-byt-j1900:       [PASS][2] -> [DMESG-WARN][3] ([i915#1982])
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-byt-
> j1900/igt@i915_pm_rpm@module-reload.html
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-byt-
> j1900/igt@i915_pm_rpm@module-reload.html
> 
> 
> #### Possible fixes ####
> 
>   * igt@i915_pm_rpm@module-reload:
>     - fi-cml-s:           [DMESG-WARN][4] ([i915#1982]) -> [PASS][5]
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-cml-
> s/igt@i915_pm_rpm@module-reload.html
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-cml-
> s/igt@i915_pm_rpm@module-reload.html
> 
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>     - fi-bsw-n3050:       [DMESG-WARN][6] ([i915#1982]) -> [PASS][7]
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-bsw-
> n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-bsw-
> n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>     - fi-bsw-kefka:       [DMESG-WARN][8] ([i915#1982]) -> [PASS][9]
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-bsw-
> kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-bsw-
> kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
> 
> 
> #### Warnings ####
> 
>   * igt@gem_exec_suspend@basic-s0:
>     - fi-kbl-x1275:       [DMESG-WARN][10] ([i915#62] / [i915#92]) -> [DMESG-
> WARN][11] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-kbl-
> x1275/igt@gem_exec_suspend@basic-s0.html
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-kbl-
> x1275/igt@gem_exec_suspend@basic-s0.html
> 
>   * igt@kms_flip@basic-flip-vs-modeset@a-dp1:
>     - fi-kbl-x1275:       [DMESG-WARN][12] ([i915#62] / [i915#92]) -> [DMESG-
> WARN][13] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-kbl-
> x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-kbl-
> x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
> 
>   * igt@kms_force_connector_basic@force-edid:
>     - fi-kbl-x1275:       [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) ->
> [DMESG-WARN][15] ([i915#62] / [i915#92]) +8 similar issues
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8611/fi-kbl-
> x1275/igt@kms_force_connector_basic@force-edid.html
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17922/fi-kbl-
> x1275/igt@kms_force_connector_basic@force-edid.html
> 
> 
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
>   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
>   [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
>   [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
> 
> 
> Participating hosts (48 -> 43)
> ------------------------------
> 
>   Additional (2): fi-kbl-7560u fi-tgl-u2
>   Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-
> byt-clapper fi-bdw-samus
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_8611 -> Patchwork_17922
> 
>   CI-20190529: 20190529
>   CI_DRM_8611: b87354483fa40fef86da19ade9bfe9349f0cf6d5 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5702: d16ad07e7f2a028e14d61f570931c87fa5ce404c @ 
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_17922: 0903ebe28a8fb9c912916613977b2e77d83eac8c @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> 0903ebe28a8f drm/i915/display: [NOT FOR MERGE] Reduce blanking to 
> support 4k60@10bpp for LSPCON e67c4219c55f drm/i915/display: Implement 
> DRM infoframe read for LSPCON 90fe2351734a drm/i915/display: Implement 
> infoframes readback for LSPCON 7aab4641b28f drm/i915/display: Enable 
> HDR for Parade based lspcon
> e71a13eb3147 drm/i915/display: Enable BT2020 for HDR on LSPCON devices
> 5940d801abf4 drm/i915/display: Attach HDR property for capable Gen9 
> devices ae1436b72a1c drm/i915/display: Enable HDR on gen9 devices with 
> MCA Lspcon
> 292e80f577e6 drm/i915/display: Add HDR Capability detection for LSPCON
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_17922/index.html
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.