| Message ID | 20200524023815.21789-1-jonathan@marek.ca (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts | expand |
On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > few changes. Notably, the HDK865 dts has regulator config changed a bit based > on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). Can you please elaborate on this discrepancy? I do remember seeing something odd when looking at this, but it seems like I didn't document it anywhere... Thanks, Bjorn > > Jonathan Marek (6): > arm64: dts: qcom: sm8150: add apps_smmu node > arm64: dts: qcom: sm8250: add apps_smmu node > arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes > arm64: dts: qcom: sm8250: Add USB and PHY device nodes > arm64: dts: qcom: add sm8150 hdk dts > arm64: dts: qcom: add sm8250 hdk dts > > arch/arm64/boot/dts/qcom/Makefile | 2 + > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ > arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ > 5 files changed, 1384 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts > > -- > 2.26.1 >
On 5/28/20 11:05 PM, Bjorn Andersson wrote: > On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: > >> Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. >> >> Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a >> few changes. Notably, the HDK865 dts has regulator config changed a bit based >> on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). > > Can you please elaborate on this discrepancy? I do remember seeing > something odd when looking at this, but it seems like I didn't document > it anywhere... > > Thanks, > Bjorn > Mainly there's a few regulators with different min/max voltage values. For example with l16a, downstream has min/max 3024000/3304000 but upstream sm8250-mtp has 2704000/2960000. I also added l18a. >> >> Jonathan Marek (6): >> arm64: dts: qcom: sm8150: add apps_smmu node >> arm64: dts: qcom: sm8250: add apps_smmu node >> arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes >> arm64: dts: qcom: sm8250: Add USB and PHY device nodes >> arm64: dts: qcom: add sm8150 hdk dts >> arm64: dts: qcom: add sm8250 hdk dts >> >> arch/arm64/boot/dts/qcom/Makefile | 2 + >> arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ >> arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ >> 5 files changed, 1384 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts >> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts >> >> -- >> 2.26.1 >>
On Thu 28 May 20:15 PDT 2020, Jonathan Marek wrote: > On 5/28/20 11:05 PM, Bjorn Andersson wrote: > > On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: > > > > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > > > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > > > few changes. Notably, the HDK865 dts has regulator config changed a bit based > > > on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). > > > > Can you please elaborate on this discrepancy? I do remember seeing > > something odd when looking at this, but it seems like I didn't document > > it anywhere... > > > > Thanks, > > Bjorn > > > > Mainly there's a few regulators with different min/max voltage values. For > example with l16a, downstream has min/max 3024000/3304000 but upstream > sm8250-mtp has 2704000/2960000. I also added l18a. > Thanks, we'll double check these. Regards, Bjorn > > > > > > Jonathan Marek (6): > > > arm64: dts: qcom: sm8150: add apps_smmu node > > > arm64: dts: qcom: sm8250: add apps_smmu node > > > arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes > > > arm64: dts: qcom: sm8250: Add USB and PHY device nodes > > > arm64: dts: qcom: add sm8150 hdk dts > > > arm64: dts: qcom: add sm8250 hdk dts > > > > > > arch/arm64/boot/dts/qcom/Makefile | 2 + > > > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ > > > arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ > > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ > > > 5 files changed, 1384 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts > > > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts > > > > > > -- > > > 2.26.1 > > >
Hi, On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > I've tested this series on an SM8250 based board and able to get Type C (USB0) working. There are also couple of Type A ports (USB1) on that board behind a USB hub. It is probing fine but I don't see any activity while connecting a USB device. Will continue to debug and once I get them working, I'll add my Tested-by tag. Thanks, Mani > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > few changes. Notably, the HDK865 dts has regulator config changed a bit based > on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). > > Jonathan Marek (6): > arm64: dts: qcom: sm8150: add apps_smmu node > arm64: dts: qcom: sm8250: add apps_smmu node > arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes > arm64: dts: qcom: sm8250: Add USB and PHY device nodes > arm64: dts: qcom: add sm8150 hdk dts > arm64: dts: qcom: add sm8250 hdk dts > > arch/arm64/boot/dts/qcom/Makefile | 2 + > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ > arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ > 5 files changed, 1384 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts > > -- > 2.26.1 >
On 6/4/20 9:52 AM, Manivannan Sadhasivam wrote: > Hi, > > On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: >> Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. >> > > I've tested this series on an SM8250 based board and able to get Type C (USB0) > working. There are also couple of Type A ports (USB1) on that board behind a > USB hub. It is probing fine but I don't see any activity while connecting a > USB device. Will continue to debug and once I get them working, I'll add my > Tested-by tag. > HDK865 also has a couple Type A ports, I am using them with devices already plugged in during boot and I haven't hit a problem like that, but I think I've seen the same issue when hotplugging. IIRC the behavior was a bit weird, like plugging a device in the Type A port (USB1) nothing would happen, but unplugging/replugging the type C port (USB0) would cause the Type A port device to start working.. Have you tried with the devices already plugged in before booting? > Thanks, > Mani > >> Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a >> few changes. Notably, the HDK865 dts has regulator config changed a bit based >> on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). >> >> Jonathan Marek (6): >> arm64: dts: qcom: sm8150: add apps_smmu node >> arm64: dts: qcom: sm8250: add apps_smmu node >> arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes >> arm64: dts: qcom: sm8250: Add USB and PHY device nodes >> arm64: dts: qcom: add sm8150 hdk dts >> arm64: dts: qcom: add sm8250 hdk dts >> >> arch/arm64/boot/dts/qcom/Makefile | 2 + >> arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ >> arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ >> 5 files changed, 1384 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts >> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts >> >> -- >> 2.26.1 >>
On Thu, Jun 04, 2020 at 10:06:19AM -0400, Jonathan Marek wrote: > On 6/4/20 9:52 AM, Manivannan Sadhasivam wrote: > > Hi, > > > > On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: > > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > > > > I've tested this series on an SM8250 based board and able to get Type C (USB0) > > working. There are also couple of Type A ports (USB1) on that board behind a > > USB hub. It is probing fine but I don't see any activity while connecting a > > USB device. Will continue to debug and once I get them working, I'll add my > > Tested-by tag. > > > > HDK865 also has a couple Type A ports, I am using them with devices already > plugged in during boot and I haven't hit a problem like that, but I think > I've seen the same issue when hotplugging. IIRC the behavior was a bit > weird, like plugging a device in the Type A port (USB1) nothing would > happen, but unplugging/replugging the type C port (USB0) would cause the > Type A port device to start working.. > > Have you tried with the devices already plugged in before booting? > Tried it but no luck :/ Also plugging and removing Type C doesn't make any difference. Thanks, Mani > > Thanks, > > Mani > > > > > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > > > few changes. Notably, the HDK865 dts has regulator config changed a bit based > > > on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). > > > > > > Jonathan Marek (6): > > > arm64: dts: qcom: sm8150: add apps_smmu node > > > arm64: dts: qcom: sm8250: add apps_smmu node > > > arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes > > > arm64: dts: qcom: sm8250: Add USB and PHY device nodes > > > arm64: dts: qcom: add sm8150 hdk dts > > > arm64: dts: qcom: add sm8250 hdk dts > > > > > > arch/arm64/boot/dts/qcom/Makefile | 2 + > > > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ > > > arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ > > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ > > > 5 files changed, 1384 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts > > > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts > > > > > > -- > > > 2.26.1 > > >
On 6/4/20 11:58 AM, Manivannan Sadhasivam wrote: > On Thu, Jun 04, 2020 at 10:06:19AM -0400, Jonathan Marek wrote: >> On 6/4/20 9:52 AM, Manivannan Sadhasivam wrote: >>> Hi, >>> >>> On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: >>>> Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. >>>> >>> >>> I've tested this series on an SM8250 based board and able to get Type C (USB0) >>> working. There are also couple of Type A ports (USB1) on that board behind a >>> USB hub. It is probing fine but I don't see any activity while connecting a >>> USB device. Will continue to debug and once I get them working, I'll add my >>> Tested-by tag. >>> >> >> HDK865 also has a couple Type A ports, I am using them with devices already >> plugged in during boot and I haven't hit a problem like that, but I think >> I've seen the same issue when hotplugging. IIRC the behavior was a bit >> weird, like plugging a device in the Type A port (USB1) nothing would >> happen, but unplugging/replugging the type C port (USB0) would cause the >> Type A port device to start working.. >> >> Have you tried with the devices already plugged in before booting? >> > > Tried it but no luck :/ Also plugging and removing Type C doesn't make any > difference. > This one might be obvious, but do you have 5V power coming out of the type A ports? > Thanks, > Mani > >>> Thanks, >>> Mani >>> >>>> Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a >>>> few changes. Notably, the HDK865 dts has regulator config changed a bit based >>>> on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). >>>> >>>> Jonathan Marek (6): >>>> arm64: dts: qcom: sm8150: add apps_smmu node >>>> arm64: dts: qcom: sm8250: add apps_smmu node >>>> arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes >>>> arm64: dts: qcom: sm8250: Add USB and PHY device nodes >>>> arm64: dts: qcom: add sm8150 hdk dts >>>> arm64: dts: qcom: add sm8250 hdk dts >>>> >>>> arch/arm64/boot/dts/qcom/Makefile | 2 + >>>> arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ >>>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ >>>> arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ >>>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ >>>> 5 files changed, 1384 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts >>>> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts >>>> >>>> -- >>>> 2.26.1 >>>>
On Thu, Jun 04, 2020 at 07:22:21PM +0530, Manivannan Sadhasivam wrote: > Hi, > > On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > I've tested this series on an SM8250 based board and able to get Type C (USB0) > working. There are also couple of Type A ports (USB1) on that board behind a > USB hub. It is probing fine but I don't see any activity while connecting a > USB device. Will continue to debug and once I get them working, I'll add my > Tested-by tag. > So it turned out that I forgot to enable one regulator which kept the USB hub powered down. After enabling that, both Type A ports are working. Hence, Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > Thanks, > Mani > > > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > > few changes. Notably, the HDK865 dts has regulator config changed a bit based > > on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). > > > > Jonathan Marek (6): > > arm64: dts: qcom: sm8150: add apps_smmu node > > arm64: dts: qcom: sm8250: add apps_smmu node > > arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes > > arm64: dts: qcom: sm8250: Add USB and PHY device nodes > > arm64: dts: qcom: add sm8150 hdk dts > > arm64: dts: qcom: add sm8250 hdk dts > > > > arch/arm64/boot/dts/qcom/Makefile | 2 + > > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ > > arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ > > 5 files changed, 1384 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts > > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts > > > > -- > > 2.26.1 > >
On 6/11/20 2:05 PM, Manivannan Sadhasivam wrote: > On Thu, Jun 04, 2020 at 07:22:21PM +0530, Manivannan Sadhasivam wrote: >> Hi, >> >> On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: >>> Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. >>> >> >> I've tested this series on an SM8250 based board and able to get Type C (USB0) >> working. There are also couple of Type A ports (USB1) on that board behind a >> USB hub. It is probing fine but I don't see any activity while connecting a >> USB device. Will continue to debug and once I get them working, I'll add my >> Tested-by tag. >> > > So it turned out that I forgot to enable one regulator which kept the USB hub > powered down. After enabling that, both Type A ports are working. Hence, > > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Thanks, > Mani > Thanks for testing it. Your Tested-by only applies to the relevant patches (patches 2 and 4 in this version) right? And can I also add your Tested-by tag to my other series (https://patchwork.kernel.org/cover/11567095/) which this depends on? >> Thanks, >> Mani >> >>> Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a >>> few changes. Notably, the HDK865 dts has regulator config changed a bit based >>> on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). >>> >>> Jonathan Marek (6): >>> arm64: dts: qcom: sm8150: add apps_smmu node >>> arm64: dts: qcom: sm8250: add apps_smmu node >>> arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes >>> arm64: dts: qcom: sm8250: Add USB and PHY device nodes >>> arm64: dts: qcom: add sm8150 hdk dts >>> arm64: dts: qcom: add sm8250 hdk dts >>> >>> arch/arm64/boot/dts/qcom/Makefile | 2 + >>> arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ >>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ >>> arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ >>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ >>> 5 files changed, 1384 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts >>> >>> -- >>> 2.26.1 >>>
On Thu, Jun 11, 2020 at 02:14:43PM -0400, Jonathan Marek wrote: > On 6/11/20 2:05 PM, Manivannan Sadhasivam wrote: > > On Thu, Jun 04, 2020 at 07:22:21PM +0530, Manivannan Sadhasivam wrote: > > > Hi, > > > > > > On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: > > > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > > > > > > > I've tested this series on an SM8250 based board and able to get Type C (USB0) > > > working. There are also couple of Type A ports (USB1) on that board behind a > > > USB hub. It is probing fine but I don't see any activity while connecting a > > > USB device. Will continue to debug and once I get them working, I'll add my > > > Tested-by tag. > > > > > > > So it turned out that I forgot to enable one regulator which kept the USB hub > > powered down. After enabling that, both Type A ports are working. Hence, > > > > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > Thanks, > > Mani > > > > Thanks for testing it. Your Tested-by only applies to the relevant patches > (patches 2 and 4 in this version) right? And can I also add your Tested-by > tag to my other series (https://patchwork.kernel.org/cover/11567095/) which > this depends on? > Sure. You can add it for all SM8250 USB patches. Thanks, Mani > > > Thanks, > > > Mani > > > > > > > Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a > > > > few changes. Notably, the HDK865 dts has regulator config changed a bit based > > > > on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). > > > > > > > > Jonathan Marek (6): > > > > arm64: dts: qcom: sm8150: add apps_smmu node > > > > arm64: dts: qcom: sm8250: add apps_smmu node > > > > arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes > > > > arm64: dts: qcom: sm8250: Add USB and PHY device nodes > > > > arm64: dts: qcom: add sm8150 hdk dts > > > > arm64: dts: qcom: add sm8250 hdk dts > > > > > > > > arch/arm64/boot/dts/qcom/Makefile | 2 + > > > > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ > > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ > > > > arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ > > > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ > > > > 5 files changed, 1384 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts > > > > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts > > > > > > > > -- > > > > 2.26.1 > > > >