| Message ID | 1591665267-37713-1-git-send-email-sugar.zhang@rock-chips.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Patches to improve transfer efficiency for Rockchip SoCs. | expand |
Good Evening, I am currently testing this on the rk3399-rockpro64, and it appears to fully fix the gmac problem without using txpbl. PCIe also seems to be more stable at high load. I need to conduct long term testing, but it seems to be doing very well. Unfortunately it doesn't fix the rk3328 gmac controller. Tested-by: Peter Geis <pgwipeout@gmail.com> On Mon, Jun 8, 2020 at 9:15 PM Sugar Zhang <sugar.zhang@rock-chips.com> wrote: > > > > Changes in v2: > - fix FATAL ERROR: Unable to parse input tree > > Sugar Zhang (13): > dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP' > dmaengine: pl330: Add quirk 'arm,pl330-periph-burst' > dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' > ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac > ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac > ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac > ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac > ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac > arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac > arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac > arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac > arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac > arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac > > .../devicetree/bindings/dma/arm-pl330.txt | 1 + > arch/arm/boot/dts/rk3036.dtsi | 1 + > arch/arm/boot/dts/rk322x.dtsi | 1 + > arch/arm/boot/dts/rk3288.dtsi | 3 ++ > arch/arm/boot/dts/rk3xxx.dtsi | 3 ++ > arch/arm/boot/dts/rv1108.dtsi | 1 + > arch/arm64/boot/dts/rockchip/px30.dtsi | 1 + > arch/arm64/boot/dts/rockchip/rk3308.dtsi | 2 + > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + > arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 + > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 + > drivers/dma/pl330.c | 44 +++++++++++++++------- > 12 files changed, 49 insertions(+), 13 deletions(-) > > -- > 2.7.4 > > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Thu, Jun 11, 2020 at 9:06 PM Peter Geis <pgwipeout@gmail.com> wrote: > > Good Evening, > > I am currently testing this on the rk3399-rockpro64, and it appears to > fully fix the gmac problem without using txpbl. > PCIe also seems to be more stable at high load. > I need to conduct long term testing, but it seems to be doing very well. Belay that, it does make it harder to trigger, but the issue still remains on the rk3399. > > Unfortunately it doesn't fix the rk3328 gmac controller. > > Tested-by: Peter Geis <pgwipeout@gmail.com> > > On Mon, Jun 8, 2020 at 9:15 PM Sugar Zhang <sugar.zhang@rock-chips.com> wrote: > > > > > > > > Changes in v2: > > - fix FATAL ERROR: Unable to parse input tree > > > > Sugar Zhang (13): > > dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP' > > dmaengine: pl330: Add quirk 'arm,pl330-periph-burst' > > dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' > > ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac > > ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac > > ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac > > ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac > > ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac > > arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac > > arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac > > arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac > > arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac > > arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac > > > > .../devicetree/bindings/dma/arm-pl330.txt | 1 + > > arch/arm/boot/dts/rk3036.dtsi | 1 + > > arch/arm/boot/dts/rk322x.dtsi | 1 + > > arch/arm/boot/dts/rk3288.dtsi | 3 ++ > > arch/arm/boot/dts/rk3xxx.dtsi | 3 ++ > > arch/arm/boot/dts/rv1108.dtsi | 1 + > > arch/arm64/boot/dts/rockchip/px30.dtsi | 1 + > > arch/arm64/boot/dts/rockchip/rk3308.dtsi | 2 + > > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + > > arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 + > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 + > > drivers/dma/pl330.c | 44 +++++++++++++++------- > > 12 files changed, 49 insertions(+), 13 deletions(-) > > > > -- > > 2.7.4 > > > > > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi Peter, Thanks for testing! but, as I know, GMAC does not use the general dma(pl330) for data transfer, so, these patchs should not be helpful for your case. 在 2020/6/12 9:15, Peter Geis 写道: > On Thu, Jun 11, 2020 at 9:06 PM Peter Geis <pgwipeout@gmail.com> wrote: >> Good Evening, >> >> I am currently testing this on the rk3399-rockpro64, and it appears to >> fully fix the gmac problem without using txpbl. >> PCIe also seems to be more stable at high load. >> I need to conduct long term testing, but it seems to be doing very well. > Belay that, it does make it harder to trigger, but the issue still > remains on the rk3399. > >> Unfortunately it doesn't fix the rk3328 gmac controller. >> >> Tested-by: Peter Geis <pgwipeout@gmail.com> >> >> On Mon, Jun 8, 2020 at 9:15 PM Sugar Zhang <sugar.zhang@rock-chips.com> wrote: >>> >>> >>> Changes in v2: >>> - fix FATAL ERROR: Unable to parse input tree >>> >>> Sugar Zhang (13): >>> dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP' >>> dmaengine: pl330: Add quirk 'arm,pl330-periph-burst' >>> dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' >>> ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac >>> ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac >>> ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac >>> ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac >>> ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac >>> arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac >>> arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac >>> arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac >>> arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac >>> arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac >>> >>> .../devicetree/bindings/dma/arm-pl330.txt | 1 + >>> arch/arm/boot/dts/rk3036.dtsi | 1 + >>> arch/arm/boot/dts/rk322x.dtsi | 1 + >>> arch/arm/boot/dts/rk3288.dtsi | 3 ++ >>> arch/arm/boot/dts/rk3xxx.dtsi | 3 ++ >>> arch/arm/boot/dts/rv1108.dtsi | 1 + >>> arch/arm64/boot/dts/rockchip/px30.dtsi | 1 + >>> arch/arm64/boot/dts/rockchip/rk3308.dtsi | 2 + >>> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + >>> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 + >>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 + >>> drivers/dma/pl330.c | 44 +++++++++++++++------- >>> 12 files changed, 49 insertions(+), 13 deletions(-) >>> >>> -- >>> 2.7.4 >>> >>> >>> >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >