diff mbox series

mgmt:syncing configuration commands to the documentation.

Message ID 20200611002345.148620-1-alainm@chromium.org (mailing list archive)
State Accepted
Headers show
Series mgmt:syncing configuration commands to the documentation. | expand

Commit Message

Alain Michaud June 11, 2020, 12:23 a.m. UTC 
This patch simply fixes the definition names (and corresponding
implemenation) to the adopted documentation.

---

 lib/mgmt.h    | 26 +++++++++++++++++++-------
 src/adapter.c | 16 ++++++++--------
 2 files changed, 27 insertions(+), 15 deletions(-)

Comments

bluez.test.bot@gmail.com June 11, 2020, 12:35 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:TYPO_SPELLING: 'implemenation' may be misspelled - perhaps 'implementation'?
#7: 
implemenation) to the adopted documentation.

ERROR:INITIALISED_STATIC: do not initialise statics to false
#64: FILE: src/adapter.c:123:
+static bool kernel_set_system_config = false;

- total: 1 errors, 1 warnings, 90 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



---
Regards,
Linux Bluetooth
bluez.test.bot@gmail.com June 11, 2020, 12:35 a.m. UTC | #2 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkgitlint Failed

Outputs:
1: T3 Title has trailing punctuation (.): "mgmt:syncing configuration commands to the documentation."



---
Regards,
Linux Bluetooth
Marcel Holtmann June 12, 2020, 7:51 p.m. UTC | #3 
Hi Alain,

> This patch simply fixes the definition names (and corresponding
> implemenation) to the adopted documentation.
> 
> ---
> 
> lib/mgmt.h    | 26 +++++++++++++++++++-------
> src/adapter.c | 16 ++++++++--------
> 2 files changed, 27 insertions(+), 15 deletions(-)

patch has been applied.

Regards

Marcel
diff mbox series

Patch

diff --git a/lib/mgmt.h b/lib/mgmt.h
index 2f78d75bf..eb5dd862d 100644
--- a/lib/mgmt.h
+++ b/lib/mgmt.h
@@ -628,22 +628,34 @@  struct mgmt_rp_set_exp_feature {
 	uint32_t flags;
 } __packed;
 
-#define MGMT_OP_READ_DEFAULT_SYSTEM_PARAMETERS	0x004b
+#define MGMT_OP_READ_DEF_SYSTEM_CONFIG	0x004b
 
-struct mgmt_system_parameter_tlv {
+struct mgmt_tlv {
 	uint16_t type;
 	uint8_t  length;
 	uint8_t  value[];
 } __packed;
 
-struct mgmt_rp_read_default_system_parameters {
-	uint8_t  parameters[0]; /* mgmt_system_parameter_tlv */
+struct mgmt_rp_read_default_system_config {
+	uint8_t parameters[0]; /* mgmt_tlv */
 } __packed;
 
-#define MGMT_OP_SET_DEFAULT_SYSTEM_PARAMETERS	0x004c
+#define MGMT_OP_SET_DEF_SYSTEM_CONFIG	0x004c
 
-struct mgmt_cp_set_default_system_parameters {
-	uint8_t  parameters[0]; /* mgmt_system_parameter_tlv */
+struct mgmt_cp_set_default_system_config {
+	uint8_t parameters[0]; /* mgmt_tlv */
+} __packed;
+
+#define MGMT_OP_READ_DEF_RUNTIME_CONFIG	0x004d
+
+struct mgmt_rp_read_default_runtime_config {
+	uint8_t parameters[0]; /* mgmt_tlv */
+} __packed;
+
+#define MGMT_OP_SET_DEF_RUNTIME_CONFIG	0x004e
+
+struct mgmt_cp_set_default_runtime_config {
+	uint8_t parameters[0]; /* mgmt_tlv */
 } __packed;
 
 #define MGMT_EV_CMD_COMPLETE		0x0001
diff --git a/src/adapter.c b/src/adapter.c
index 64815ecd2..31b80b19d 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -120,7 +120,7 @@  static bool kernel_conn_control = false;
 
 static bool kernel_blocked_keys_supported = false;
 
-static bool kernel_set_system_params = false;
+static bool kernel_set_system_config = false;
 
 static GList *adapter_list = NULL;
 static unsigned int adapter_remaining = 0;
@@ -4171,7 +4171,7 @@  static void probe_devices(void *user_data)
 static void load_default_system_params(struct btd_adapter *adapter)
 {
 	struct {
-		struct mgmt_system_parameter_tlv entry;
+		struct mgmt_tlv entry;
 		union {
 			uint16_t u16;
 		};
@@ -4180,7 +4180,7 @@  static void load_default_system_params(struct btd_adapter *adapter)
 	size_t len = 0;
 	unsigned int err;
 
-	if (!main_opts.default_params.num_entries || !kernel_set_system_params)
+	if (!main_opts.default_params.num_entries || !kernel_set_system_config)
 		return;
 
 	params = malloc0(sizeof(*params) *
@@ -4414,11 +4414,11 @@  static void load_default_system_params(struct btd_adapter *adapter)
 		len += sizeof(params[i].u16);
 	}
 
-	err = mgmt_send(adapter->mgmt, MGMT_OP_SET_DEFAULT_SYSTEM_PARAMETERS,
+	err = mgmt_send(adapter->mgmt, MGMT_OP_SET_DEF_SYSTEM_CONFIG,
 			adapter->dev_id, len, params, NULL, NULL, NULL);
 	if (!err)
 		btd_error(adapter->dev_id,
-				"Failed to set default system params for hci%u",
+				"Failed to set default system config for hci%u",
 				adapter->dev_id);
 
 	free(params);
@@ -9426,9 +9426,9 @@  static void read_commands_complete(uint8_t status, uint16_t length,
 			DBG("kernel supports the set_blocked_keys op");
 			kernel_blocked_keys_supported = true;
 			break;
-		case MGMT_OP_SET_DEFAULT_SYSTEM_PARAMETERS:
-			DBG("kernel supports set system params");
-			kernel_set_system_params = true;
+		case MGMT_OP_SET_DEF_SYSTEM_CONFIG:
+			DBG("kernel supports set system confic");
+			kernel_set_system_config = true;
 			break;
 		default:
 			break;