mbox series

[0/4] spi: bcm63xx: add BMIPS support

Message ID 20200615080309.2897694-1-noltari@gmail.com (mailing list archive)
Headers show
Series spi: bcm63xx: add BMIPS support | expand

Message

Álvaro Fernández Rojas June 15, 2020, 8:03 a.m. UTC
BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318,
BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268).

Álvaro Fernández Rojas (4):
  spi: bcm63xx-spi: add reset support
  spi: bcm63xx-spi: allow building for BMIPS
  spi: bcm63xx-hsspi: add reset support
  spi: bcm63xx-hsspi: allow building for BMIPS

 drivers/spi/Kconfig             |  4 ++--
 drivers/spi/spi-bcm63xx-hsspi.c | 17 +++++++++++++++++
 drivers/spi/spi-bcm63xx.c       | 17 +++++++++++++++++
 3 files changed, 36 insertions(+), 2 deletions(-)

Comments

Álvaro Fernández Rojas June 15, 2020, 9:09 a.m. UTC | #1
BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318,
BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268).

v2: use devm_reset_control_get_exclusive

Álvaro Fernández Rojas (4):
  spi: bcm63xx-spi: add reset support
  spi: bcm63xx-spi: allow building for BMIPS
  spi: bcm63xx-hsspi: add reset support
  spi: bcm63xx-hsspi: allow building for BMIPS

 drivers/spi/Kconfig             |  4 ++--
 drivers/spi/spi-bcm63xx-hsspi.c | 17 +++++++++++++++++
 drivers/spi/spi-bcm63xx.c       | 17 +++++++++++++++++
 3 files changed, 36 insertions(+), 2 deletions(-)
Mark Brown June 15, 2020, 11:26 a.m. UTC | #2
On Mon, Jun 15, 2020 at 11:09:39AM +0200, Álvaro Fernández Rojas wrote:
> BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318,
> BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268).

Please don't send new versions of patches in reply to old ones, it makes
it hard to keep track of what's going on and can bury things back in a
mailbox.
Florian Fainelli June 15, 2020, 4:27 p.m. UTC | #3
Hi Alvaro,

On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote:
> BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318,
> BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268).
> 
> v2: use devm_reset_control_get_exclusive

We would also need to write a binding document for these two
controllers, as they appear to be missing, and this would document the
reset property.

I also believe that you should be making this property optional since
not all SoCs do have a dedicated reset controller line for SPI/HSSPI (if
at all).

Thank you!
Mark Brown June 15, 2020, 11:41 p.m. UTC | #4
On Mon, 15 Jun 2020 11:09:39 +0200, Álvaro Fernández Rojas wrote:
> BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318,
> BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268).
> 
> v2: use devm_reset_control_get_exclusive
> 
> Álvaro Fernández Rojas (4):
>   spi: bcm63xx-spi: add reset support
>   spi: bcm63xx-spi: allow building for BMIPS
>   spi: bcm63xx-hsspi: add reset support
>   spi: bcm63xx-hsspi: allow building for BMIPS
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/4] spi: bcm63xx-spi: add reset support
      (no commit info)
[2/4] spi: bcm63xx-spi: allow building for BMIPS
      commit: 3a521450ff218ddac9b2c15fcd2bcadab56ff79d
[3/4] spi: bcm63xx-hsspi: add reset support
      (no commit info)
[4/4] spi: bcm63xx-hsspi: allow building for BMIPS
      commit: ba2137f3dbce5e530eba0c67d37a758b42eb26f8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark