diff mbox series

[v4,3/3] ARM: dts: bcm2711: Add HDMI DVP

Message ID e22222ca7f41b960e9bb1a31e0dd2de95b8c0cd1.1591867332.git-series.maxime@cerno.tech (mailing list archive)
State Mainlined
Commit 25c6f3960764b266a609281341f889a06d045039
Headers show
Series clk: bcm: Add BCM2711 DVP driver | expand

Commit Message

Maxime Ripard June 11, 2020, 9:23 a.m. UTC
Now that we have a driver for the DVP, let's add its DT node.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 arch/arm/boot/dts/bcm2711.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Nicolas Saenz Julienne June 15, 2020, 4:26 p.m. UTC | #1
On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote:
> Now that we have a driver for the DVP, let's add its DT node.
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---

I can take this patch, but I guess the rest should go trough the clock tree.
Is it OK with you?

Regards,
Nicolas
Maxime Ripard June 16, 2020, 12:16 p.m. UTC | #2
Hi Nicolas,

On Mon, Jun 15, 2020 at 06:26:19PM +0200, Nicolas Saenz Julienne wrote:
> On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote:
> > Now that we have a driver for the DVP, let's add its DT node.
> > 
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> 
> I can take this patch, but I guess the rest should go trough the clock tree.
> Is it OK with you?

We have a build dependency on the reset framework for that driver, so it
should rather go through the reset tree (or Philipp should make an
immutable branch that the clk maintainers can merge).

Maxime
Philipp Zabel June 16, 2020, 12:56 p.m. UTC | #3
Hi Maxime,

On Tue, 2020-06-16 at 14:16 +0200, Maxime Ripard wrote:
> Hi Nicolas,
> 
> On Mon, Jun 15, 2020 at 06:26:19PM +0200, Nicolas Saenz Julienne wrote:
> > On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote:
> > > Now that we have a driver for the DVP, let's add its DT node.
> > > 
> > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > ---
> > 
> > I can take this patch, but I guess the rest should go trough the clock tree.
> > Is it OK with you?
> 
> We have a build dependency on the reset framework for that driver, so it
> should rather go through the reset tree (or Philipp should make an
> immutable branch that the clk maintainers can merge).

I've prepared an immutable branch that these patches could be based on
and that could be merged into the clk tree:

The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:

  Linux 5.8-rc1 (2020-06-14 12:45:04 -0700)

are available in the Git repository at:

  git://git.pengutronix.de/git/pza/linux reset/simple

for you to fetch changes up to a9701376ed0fb61a5be4bb438daf26bd9cfa24b5:

  reset: simple: Add reset callback (2020-06-16 14:19:57 +0200)

----------------------------------------------------------------
Maxime Ripard (2):
      reset: Move reset-simple header out of drivers/reset
      reset: simple: Add reset callback

 drivers/reset/reset-simple.c                    | 23 +++++++++++++++++++++--
 drivers/reset/reset-socfpga.c                   |  3 +--
 drivers/reset/reset-sunxi.c                     |  3 +--
 drivers/reset/reset-uniphier-glue.c             |  3 +--
 {drivers => include/linux}/reset/reset-simple.h |  7 +++++++
 5 files changed, 31 insertions(+), 8 deletions(-)
 rename {drivers => include/linux}/reset/reset-simple.h (74%)

regards
Philipp
Maxime Ripard June 16, 2020, 1:33 p.m. UTC | #4
On Tue, Jun 16, 2020 at 02:56:55PM +0200, Philipp Zabel wrote:
> Hi Maxime,
> 
> On Tue, 2020-06-16 at 14:16 +0200, Maxime Ripard wrote:
> > Hi Nicolas,
> > 
> > On Mon, Jun 15, 2020 at 06:26:19PM +0200, Nicolas Saenz Julienne wrote:
> > > On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote:
> > > > Now that we have a driver for the DVP, let's add its DT node.
> > > > 
> > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > > ---
> > > 
> > > I can take this patch, but I guess the rest should go trough the clock tree.
> > > Is it OK with you?
> > 
> > We have a build dependency on the reset framework for that driver, so it
> > should rather go through the reset tree (or Philipp should make an
> > immutable branch that the clk maintainers can merge).
> 
> I've prepared an immutable branch that these patches could be based on
> and that could be merged into the clk tree:
> 
> The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:
> 
>   Linux 5.8-rc1 (2020-06-14 12:45:04 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.pengutronix.de/git/pza/linux reset/simple
> 
> for you to fetch changes up to a9701376ed0fb61a5be4bb438daf26bd9cfa24b5:
> 
>   reset: simple: Add reset callback (2020-06-16 14:19:57 +0200)
> 
> ----------------------------------------------------------------
> Maxime Ripard (2):
>       reset: Move reset-simple header out of drivers/reset
>       reset: simple: Add reset callback
> 
>  drivers/reset/reset-simple.c                    | 23 +++++++++++++++++++++--
>  drivers/reset/reset-socfpga.c                   |  3 +--
>  drivers/reset/reset-sunxi.c                     |  3 +--
>  drivers/reset/reset-uniphier-glue.c             |  3 +--
>  {drivers => include/linux}/reset/reset-simple.h |  7 +++++++
>  5 files changed, 31 insertions(+), 8 deletions(-)
>  rename {drivers => include/linux}/reset/reset-simple.h (74%)

Awesome, thanks!
Maxime
Stephen Boyd June 20, 2020, 12:10 a.m. UTC | #5
Quoting Philipp Zabel (2020-06-16 05:56:55)
> Hi Maxime,
> 
> On Tue, 2020-06-16 at 14:16 +0200, Maxime Ripard wrote:
> > Hi Nicolas,
> > 
> > On Mon, Jun 15, 2020 at 06:26:19PM +0200, Nicolas Saenz Julienne wrote:
> > > On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote:
> > > > Now that we have a driver for the DVP, let's add its DT node.
> > > > 
> > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > > > ---
> > > 
> > > I can take this patch, but I guess the rest should go trough the clock tree.
> > > Is it OK with you?
> > 
> > We have a build dependency on the reset framework for that driver, so it
> > should rather go through the reset tree (or Philipp should make an
> > immutable branch that the clk maintainers can merge).
> 
> I've prepared an immutable branch that these patches could be based on
> and that could be merged into the clk tree:
> 
> The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:
> 
>   Linux 5.8-rc1 (2020-06-14 12:45:04 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.pengutronix.de/git/pza/linux reset/simple
> 
> for you to fetch changes up to a9701376ed0fb61a5be4bb438daf26bd9cfa24b5:
> 
>   reset: simple: Add reset callback (2020-06-16 14:19:57 +0200)
> 

Thanks. I've pulled it into clk-next.
Nicolas Saenz Julienne July 6, 2020, 4:53 p.m. UTC | #6
On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote:
> Now that we have a driver for the DVP, let's add its DT node.
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---

Applied for-next,

Thanks,
Nicolas
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index a91cf68e3c4c..00bcaed1be32 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -12,6 +12,13 @@ 
 
 	interrupt-parent = <&gicv2>;
 
+	clk_108MHz: clk-108M {
+		#clock-cells = <0>;
+		compatible = "fixed-clock";
+		clock-frequency = <108000000>;
+		clock-output-names = "108MHz-clock";
+	};
+
 	soc {
 		/*
 		 * Defined ranges:
@@ -244,6 +251,14 @@ 
 		hvs@7e400000 {
 			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
 		};
+
+		dvp: clock@7ef00000 {
+			compatible = "brcm,brcm2711-dvp";
+			reg = <0x7ef00000 0x10>;
+			clocks = <&clk_108MHz>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+		};
 	};
 
 	/*