mbox series

[0/2] MCA and EDAC updates for AMD Family 17h, Model 60h

Message ID 20200607043709.48178-1-hengqing.hu@gmail.com (mailing list archive)
Headers show
Series MCA and EDAC updates for AMD Family 17h, Model 60h | expand

Message

Jacky Hu June 7, 2020, 4:37 a.m. UTC
This patchset adds MCA and EDAC support for AMD Family 17h, Model 60h.

Also k10temp works with 4800h

k10temp-pci-00c3
Adapter: PCI adapter
Vcore:         1.55 V
Vsoc:          1.55 V
Tctl:         +49.6°C
Tdie:         +49.6°C
Icore:         0.00 A
Isoc:          0.00 A

Jacky Hu (2):
  x86/amd_nb: Add Family 17h, Model 60h PCI IDs
  EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh

 arch/x86/kernel/amd_nb.c  |  5 +++++
 drivers/edac/amd64_edac.c | 14 ++++++++++++++
 drivers/edac/amd64_edac.h |  3 +++
 drivers/hwmon/k10temp.c   |  2 ++
 include/linux/pci_ids.h   |  1 +
 5 files changed, 25 insertions(+)

Comments

Borislav Petkov June 15, 2020, 11:59 a.m. UTC | #1
+ Yazen and linux-hwmon.

On Sun, Jun 07, 2020 at 12:37:07PM +0800, Jacky Hu wrote:
> This patchset adds MCA and EDAC support for AMD Family 17h, Model 60h.
> 
> Also k10temp works with 4800h
> 
> k10temp-pci-00c3
> Adapter: PCI adapter
> Vcore:         1.55 V
> Vsoc:          1.55 V
> Tctl:         +49.6°C
> Tdie:         +49.6°C
> Icore:         0.00 A
> Isoc:          0.00 A
> 
> Jacky Hu (2):
>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
> 
>  arch/x86/kernel/amd_nb.c  |  5 +++++
>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
>  drivers/edac/amd64_edac.h |  3 +++
>  drivers/hwmon/k10temp.c   |  2 ++
>  include/linux/pci_ids.h   |  1 +
>  5 files changed, 25 insertions(+)
> 
> -- 
> 2.27.0
>
Guenter Roeck June 15, 2020, 3:01 p.m. UTC | #2
On 6/15/20 4:59 AM, Borislav Petkov wrote:
> + Yazen and linux-hwmon.
> 
> On Sun, Jun 07, 2020 at 12:37:07PM +0800, Jacky Hu wrote:
>> This patchset adds MCA and EDAC support for AMD Family 17h, Model 60h.
>>
>> Also k10temp works with 4800h
>>
>> k10temp-pci-00c3
>> Adapter: PCI adapter
>> Vcore:         1.55 V
>> Vsoc:          1.55 V
>> Tctl:         +49.6°C
>> Tdie:         +49.6°C
>> Icore:         0.00 A
>> Isoc:          0.00 A
>>

Looks like we may have to black-list current measurements
for that chip, though.

Guenter

>> Jacky Hu (2):
>>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
>>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
>>
>>  arch/x86/kernel/amd_nb.c  |  5 +++++
>>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
>>  drivers/edac/amd64_edac.h |  3 +++
>>  drivers/hwmon/k10temp.c   |  2 ++
>>  include/linux/pci_ids.h   |  1 +
>>  5 files changed, 25 insertions(+)
>>
>> -- 
>> 2.27.0
>>
>
Yazen Ghannam June 16, 2020, 2:11 p.m. UTC | #3
On Mon, Jun 15, 2020 at 07:59:50AM -0400, Borislav Petkov wrote:
> + Yazen and linux-hwmon.
> 
> On Sun, Jun 07, 2020 at 12:37:07PM +0800, Jacky Hu wrote:
> > This patchset adds MCA and EDAC support for AMD Family 17h, Model 60h.
> > 
> > Also k10temp works with 4800h
> > 
> > k10temp-pci-00c3
> > Adapter: PCI adapter
> > Vcore:         1.55 V
> > Vsoc:          1.55 V
> > Tctl:         +49.6°C
> > Tdie:         +49.6°C
> > Icore:         0.00 A
> > Isoc:          0.00 A
> > 
> > Jacky Hu (2):
> >   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
> >   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
> > 
> >  arch/x86/kernel/amd_nb.c  |  5 +++++
> >  drivers/edac/amd64_edac.c | 14 ++++++++++++++
> >  drivers/edac/amd64_edac.h |  3 +++
> >  drivers/hwmon/k10temp.c   |  2 ++
> >  include/linux/pci_ids.h   |  1 +
> >  5 files changed, 25 insertions(+)
> >

PCI IDs and EDAC look good to me.

Acked-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen
Borislav Petkov June 16, 2020, 2:35 p.m. UTC | #4
On Mon, Jun 15, 2020 at 08:01:22AM -0700, Guenter Roeck wrote:
> Looks like we may have to black-list current measurements
> for that chip, though.
> 
> Guenter
> 
> >> Jacky Hu (2):
> >>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
> >>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
> >>
> >>  arch/x86/kernel/amd_nb.c  |  5 +++++
> >>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
> >>  drivers/edac/amd64_edac.h |  3 +++
> >>  drivers/hwmon/k10temp.c   |  2 ++

... meaning I should not take the k10temp changes yet? I can drop them
and take the rest...

Thx.
Guenter Roeck June 16, 2020, 2:46 p.m. UTC | #5
On 6/16/20 7:35 AM, Borislav Petkov wrote:
> On Mon, Jun 15, 2020 at 08:01:22AM -0700, Guenter Roeck wrote:
>> Looks like we may have to black-list current measurements
>> for that chip, though.
>>
>> Guenter
>>
>>>> Jacky Hu (2):
>>>>   x86/amd_nb: Add Family 17h, Model 60h PCI IDs
>>>>   EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh
>>>>
>>>>  arch/x86/kernel/amd_nb.c  |  5 +++++
>>>>  drivers/edac/amd64_edac.c | 14 ++++++++++++++
>>>>  drivers/edac/amd64_edac.h |  3 +++
>>>>  drivers/hwmon/k10temp.c   |  2 ++
> 
> ... meaning I should not take the k10temp changes yet? I can drop them
> and take the rest...
> 

No, that is independent. It is more like a note to myself. I'll have to get
debug dumps from someone with affected chip(s), and for that to work
support for those chips has to be enabled in k10temp.

Thanks,
Guenter
Borislav Petkov June 16, 2020, 2:55 p.m. UTC | #6
On Tue, Jun 16, 2020 at 07:46:36AM -0700, Guenter Roeck wrote:
> No, that is independent. It is more like a note to myself. I'll have to get
> debug dumps from someone with affected chip(s), and for that to work
> support for those chips has to be enabled in k10temp.

Ok, then, will take those patches as is.

Thx.