diff mbox series

[V2] ARM: dts: am335x-pocketbeagle: Fix mmc0 Write Protect

Message ID 20200609214521.GB2995279@x1 (mailing list archive)
State New, archived
Headers show
Series [V2] ARM: dts: am335x-pocketbeagle: Fix mmc0 Write Protect | expand

Commit Message

Drew Fustini June 9, 2020, 9:45 p.m. UTC 
AM3358 pin mcasp0_aclkr (ZCZ ball B13) [0] is routed to P1.31 header [1]
Mode 4 of this pin is mmc0_sdwp (SD Write Protect).  A signal connected
to P1.31 may accidentally trigger mmc0 write protection.  To avoid this
situation, do not put mcasp0_aclkr in mode 4 (mmc0_sdwp) by default.

[0] http://www.ti.com/lit/ds/symlink/am3358.pdf
[1] https://github.com/beagleboard/pocketbeagle/wiki/System-Reference-Manual#531_Expansion_Headers

Fixes: 047905376a16 (ARM: dts: Add am335x-pocketbeagle)
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
V2 change:
- correct P1.13 to P1.31, apologies for not catching that in V1

 arch/arm/boot/dts/am335x-pocketbeagle.dts | 1 -
 1 file changed, 1 deletion(-)

--
2.25.1

Comments

Tony Lindgren June 16, 2020, 4:10 p.m. UTC | #1 
* Drew Fustini <drew@beagleboard.org> [200609 14:46]:
> AM3358 pin mcasp0_aclkr (ZCZ ball B13) [0] is routed to P1.31 header [1]
> Mode 4 of this pin is mmc0_sdwp (SD Write Protect).  A signal connected
> to P1.31 may accidentally trigger mmc0 write protection.  To avoid this
> situation, do not put mcasp0_aclkr in mode 4 (mmc0_sdwp) by default.
> 
> [0] http://www.ti.com/lit/ds/symlink/am3358.pdf
> [1] https://github.com/beagleboard/pocketbeagle/wiki/System-Reference-Manual#531_Expansion_Headers
> 
> Fixes: 047905376a16 (ARM: dts: Add am335x-pocketbeagle)
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> V2 change:
> - correct P1.13 to P1.31, apologies for not catching that in V1

Thanks (manually) applying into fixes. Your outgoing mail server has replaced
the tabs in the patch with spaces making it not apply FYI.

Regards,

Tony
Drew Fustini June 16, 2020, 4:19 p.m. UTC | #2 
On Tue, Jun 16, 2020 at 09:10:24AM -0700, Tony Lindgren wrote:
> * Drew Fustini <drew@beagleboard.org> [200609 14:46]:
> > AM3358 pin mcasp0_aclkr (ZCZ ball B13) [0] is routed to P1.31 header [1]
> > Mode 4 of this pin is mmc0_sdwp (SD Write Protect).  A signal connected
> > to P1.31 may accidentally trigger mmc0 write protection.  To avoid this
> > situation, do not put mcasp0_aclkr in mode 4 (mmc0_sdwp) by default.
> > 
> > [0] http://www.ti.com/lit/ds/symlink/am3358.pdf
> > [1] https://github.com/beagleboard/pocketbeagle/wiki/System-Reference-Manual#531_Expansion_Headers
> > 
> > Fixes: 047905376a16 (ARM: dts: Add am335x-pocketbeagle)
> > Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> > Signed-off-by: Drew Fustini <drew@beagleboard.org>
> > ---
> > V2 change:
> > - correct P1.13 to P1.31, apologies for not catching that in V1
> 
> Thanks (manually) applying into fixes. Your outgoing mail server has replaced
> the tabs in the patch with spaces making it not apply FYI.
> 
> Regards,
> 
> Tony

Thanks, Tony.

That is werid about the spaces.  I use mutt to send mail via smtp.google.com
(beagleboard.org is gsuite).  I'll inspect more closely next time.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/am335x-pocketbeagle.dts b/arch/arm/boot/dts/am335x-pocketbeagle.dts
index 4da719098028..f0b222201b86 100644
--- a/arch/arm/boot/dts/am335x-pocketbeagle.dts
+++ b/arch/arm/boot/dts/am335x-pocketbeagle.dts
@@ -88,7 +88,6 @@  AM33XX_PADCONF(AM335X_PIN_MMC0_DAT2, PIN_INPUT_PULLUP, MUX_MODE0)
                        AM33XX_PADCONF(AM335X_PIN_MMC0_DAT3, PIN_INPUT_PULLUP, MUX_MODE0)
                        AM33XX_PADCONF(AM335X_PIN_MMC0_CMD, PIN_INPUT_PULLUP, MUX_MODE0)
                        AM33XX_PADCONF(AM335X_PIN_MMC0_CLK, PIN_INPUT_PULLUP, MUX_MODE0)
-                       AM33XX_PADCONF(AM335X_PIN_MCASP0_ACLKR, PIN_INPUT, MUX_MODE4)           /* (B12) mcasp0_aclkr.mmc0_sdwp */
                >;
        };