[0/3] Refactor prealloc_file_extent_cluster

Message

Nikolay Borisov June 17, 2020, 9:10 a.m. UTC

Those 3 minor patches refactor prealloc_file_extent_cluster by:

1. Removing useless check
2. Re-order code around to make heavyweight operations outside of inode lock,
(not that it matters for performance) and also get rid of the out label
3. Switch a while to a for loop to make the loop intentino more explicit.


Nikolay Borisov (3):
  btrfs: Remove hole  check in prealloc_file_extent_cluster
  btrfs: Perform data management operations outside of inode lock
  btrfs: Use for loop in prealloc_file_extent_cluster

 fs/btrfs/relocation.c | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

--
2.17.1

Comments

David Sterba June 17, 2020, 4:38 p.m. UTC | #1

On Wed, Jun 17, 2020 at 12:10:41PM +0300, Nikolay Borisov wrote:
> Those 3 minor patches refactor prealloc_file_extent_cluster by:
> 
> 1. Removing useless check
> 2. Re-order code around to make heavyweight operations outside of inode lock,
> (not that it matters for performance) and also get rid of the out label
> 3. Switch a while to a for loop to make the loop intentino more explicit.
> 
> 
> Nikolay Borisov (3):
>   btrfs: Remove hole  check in prealloc_file_extent_cluster
>   btrfs: Perform data management operations outside of inode lock
>   btrfs: Use for loop in prealloc_file_extent_cluster

Added to misc-next, thanks.