| Message ID | 20200611211144.9421-4-luca@lucaceresoli.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/5] dt-bindings: fpga: xilinx-slave-serial: valid for the 7 Series too | expand |
On Thu, Jun 11, 2020 at 11:11:43PM +0200, Luca Ceresoli wrote: > The INIT_B is used by the 6 and 7 series to report the programming status, > providing more control and information about programming errors. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt > index 9f103f3872e8..a049082e1513 100644 > --- a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt > +++ b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt > @@ -16,6 +16,10 @@ Required properties: > - prog_b-gpios: config pin (referred to as PROGRAM_B in the manual) > - done-gpios: config status pin (referred to as DONE in the manual) > > +Optional properties: > +- init_b-gpios: initialization status and configuration error pin > + (referred to as INIT_B in the manual) Don't use '_' in property names: init-b-gpios > + > Example for full FPGA configuration: > > fpga-region0 { > @@ -40,7 +44,8 @@ Example for full FPGA configuration: > spi-max-frequency = <60000000>; > spi-cpha; > reg = <0>; > - done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; > prog_b-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>; > + init_b-gpios = <&gpio0 28 GPIO_ACTIVE_LOW>; > + done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; > }; > }; > -- > 2.27.0 >
Hi Rob, Moritz, On 18/06/20 00:39, Rob Herring wrote: > On Thu, Jun 11, 2020 at 11:11:43PM +0200, Luca Ceresoli wrote: >> The INIT_B is used by the 6 and 7 series to report the programming status, >> providing more control and information about programming errors. >> >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> >> --- >> .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> index 9f103f3872e8..a049082e1513 100644 >> --- a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> +++ b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt >> @@ -16,6 +16,10 @@ Required properties: >> - prog_b-gpios: config pin (referred to as PROGRAM_B in the manual) >> - done-gpios: config status pin (referred to as DONE in the manual) >> >> +Optional properties: >> +- init_b-gpios: initialization status and configuration error pin >> + (referred to as INIT_B in the manual) > > Don't use '_' in property names: > > init-b-gpios OK, will fix. Moritz, please don't apply this version of patches 4 and 5 if you still haven't done so. Now what about the existing prog_b-gpios property? Should we just leave it as is for backward compatibility, or is there a migration path to fix it as well? Thanks.
On Wed, Jun 17, 2020 at 11:47 PM Luca Ceresoli <luca@lucaceresoli.net> wrote: > > Hi Rob, Moritz, > > On 18/06/20 00:39, Rob Herring wrote: > > On Thu, Jun 11, 2020 at 11:11:43PM +0200, Luca Ceresoli wrote: > >> The INIT_B is used by the 6 and 7 series to report the programming status, > >> providing more control and information about programming errors. > >> > >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > >> --- > >> .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt > >> index 9f103f3872e8..a049082e1513 100644 > >> --- a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt > >> +++ b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt > >> @@ -16,6 +16,10 @@ Required properties: > >> - prog_b-gpios: config pin (referred to as PROGRAM_B in the manual) > >> - done-gpios: config status pin (referred to as DONE in the manual) > >> > >> +Optional properties: > >> +- init_b-gpios: initialization status and configuration error pin > >> + (referred to as INIT_B in the manual) > > > > Don't use '_' in property names: > > > > init-b-gpios > > OK, will fix. > > Moritz, please don't apply this version of patches 4 and 5 if you still > haven't done so. > > Now what about the existing prog_b-gpios property? Should we just leave > it as is for backward compatibility, or is there a migration path to fix > it as well? Just leave it. Rob
diff --git a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt index 9f103f3872e8..a049082e1513 100644 --- a/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt +++ b/Documentation/devicetree/bindings/fpga/xilinx-slave-serial.txt @@ -16,6 +16,10 @@ Required properties: - prog_b-gpios: config pin (referred to as PROGRAM_B in the manual) - done-gpios: config status pin (referred to as DONE in the manual) +Optional properties: +- init_b-gpios: initialization status and configuration error pin + (referred to as INIT_B in the manual) + Example for full FPGA configuration: fpga-region0 { @@ -40,7 +44,8 @@ Example for full FPGA configuration: spi-max-frequency = <60000000>; spi-cpha; reg = <0>; - done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; prog_b-gpios = <&gpio0 29 GPIO_ACTIVE_LOW>; + init_b-gpios = <&gpio0 28 GPIO_ACTIVE_LOW>; + done-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; }; };
The INIT_B is used by the 6 and 7 series to report the programming status, providing more control and information about programming errors. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- .../devicetree/bindings/fpga/xilinx-slave-serial.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)