| Message ID | 20200623025106.31273-28-afaerber@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: Realtek DHC SoC info | expand |
On 23/06/2020 03:51, Andreas Färber wrote: > It's "an unsigned" but "a U". > Similarly, "an entry" but "a binary entry". > > While at it, also drop superfluous articles for negative and zero. > > Fixes: 8b977c5498b8 ("nvmem: core: add nvmem_cell_read_u64") > Fixes: 0a9b2d1ce422 ("nvmem: core: add nvmem_cell_read_u16") > Fixes: d026d70a2e94 ("nvmem: core: Add nvmem_cell_read_u32") > Fixes: f1f50eca5f90 ("nvmem: Introduce devm_nvmem_(un)register()") > Fixes: eace75cfdcf7 ("nvmem: Add a simple NVMEM framework for nvmem providers") > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > In theory, for clean backports this would need to be split into 5 pieces... > Not sure whether anyone would actually do that for help text? > Dropping the Fixes headers might be an alternative. TBH, it adds lot of confusion while automatically back-porting these patches! For now I have removed these Fixes tags and applied. As I do not feel this is going to add any value in back-porting this grammar fixes!! --srini > > v2: New > > drivers/nvmem/core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index fc480d636be2..95bed31391cd 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -573,7 +573,7 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem) > > /** > * nvmem_register() - Register a nvmem device for given nvmem_config. > - * Also creates an binary entry in /sys/bus/nvmem/devices/dev-name/nvmem > + * Also creates a binary entry in /sys/bus/nvmem/devices/dev-name/nvmem > * > * @config: nvmem device configuration with which nvmem device is created. > * > @@ -728,7 +728,7 @@ static void devm_nvmem_release(struct device *dev, void *res) > /** > * devm_nvmem_register() - Register a managed nvmem device for given > * nvmem_config. > - * Also creates an binary entry in /sys/bus/nvmem/devices/dev-name/nvmem > + * Also creates a binary entry in /sys/bus/nvmem/devices/dev-name/nvmem > * > * @dev: Device that uses the nvmem device. > * @config: nvmem device configuration with which nvmem device is created. > @@ -772,7 +772,7 @@ static int devm_nvmem_match(struct device *dev, void *res, void *data) > * @dev: Device that uses the nvmem device. > * @nvmem: Pointer to previously registered nvmem device. > * > - * Return: Will be an negative on error or a zero on success. > + * Return: Will be negative on error or zero on success. > */ > int devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem) > { > @@ -1375,7 +1375,7 @@ static int nvmem_cell_read_common(struct device *dev, const char *cell_id, > } > > /** > - * nvmem_cell_read_u16() - Read a cell value as an u16 > + * nvmem_cell_read_u16() - Read a cell value as a u16 > * > * @dev: Device that requests the nvmem cell. > * @cell_id: Name of nvmem cell to read. > @@ -1390,7 +1390,7 @@ int nvmem_cell_read_u16(struct device *dev, const char *cell_id, u16 *val) > EXPORT_SYMBOL_GPL(nvmem_cell_read_u16); > > /** > - * nvmem_cell_read_u32() - Read a cell value as an u32 > + * nvmem_cell_read_u32() - Read a cell value as a u32 > * > * @dev: Device that requests the nvmem cell. > * @cell_id: Name of nvmem cell to read. > @@ -1405,7 +1405,7 @@ int nvmem_cell_read_u32(struct device *dev, const char *cell_id, u32 *val) > EXPORT_SYMBOL_GPL(nvmem_cell_read_u32); > > /** > - * nvmem_cell_read_u64() - Read a cell value as an u64 > + * nvmem_cell_read_u64() - Read a cell value as a u64 > * > * @dev: Device that requests the nvmem cell. > * @cell_id: Name of nvmem cell to read. >
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index fc480d636be2..95bed31391cd 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -573,7 +573,7 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem) /** * nvmem_register() - Register a nvmem device for given nvmem_config. - * Also creates an binary entry in /sys/bus/nvmem/devices/dev-name/nvmem + * Also creates a binary entry in /sys/bus/nvmem/devices/dev-name/nvmem * * @config: nvmem device configuration with which nvmem device is created. * @@ -728,7 +728,7 @@ static void devm_nvmem_release(struct device *dev, void *res) /** * devm_nvmem_register() - Register a managed nvmem device for given * nvmem_config. - * Also creates an binary entry in /sys/bus/nvmem/devices/dev-name/nvmem + * Also creates a binary entry in /sys/bus/nvmem/devices/dev-name/nvmem * * @dev: Device that uses the nvmem device. * @config: nvmem device configuration with which nvmem device is created. @@ -772,7 +772,7 @@ static int devm_nvmem_match(struct device *dev, void *res, void *data) * @dev: Device that uses the nvmem device. * @nvmem: Pointer to previously registered nvmem device. * - * Return: Will be an negative on error or a zero on success. + * Return: Will be negative on error or zero on success. */ int devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem) { @@ -1375,7 +1375,7 @@ static int nvmem_cell_read_common(struct device *dev, const char *cell_id, } /** - * nvmem_cell_read_u16() - Read a cell value as an u16 + * nvmem_cell_read_u16() - Read a cell value as a u16 * * @dev: Device that requests the nvmem cell. * @cell_id: Name of nvmem cell to read. @@ -1390,7 +1390,7 @@ int nvmem_cell_read_u16(struct device *dev, const char *cell_id, u16 *val) EXPORT_SYMBOL_GPL(nvmem_cell_read_u16); /** - * nvmem_cell_read_u32() - Read a cell value as an u32 + * nvmem_cell_read_u32() - Read a cell value as a u32 * * @dev: Device that requests the nvmem cell. * @cell_id: Name of nvmem cell to read. @@ -1405,7 +1405,7 @@ int nvmem_cell_read_u32(struct device *dev, const char *cell_id, u32 *val) EXPORT_SYMBOL_GPL(nvmem_cell_read_u32); /** - * nvmem_cell_read_u64() - Read a cell value as an u64 + * nvmem_cell_read_u64() - Read a cell value as a u64 * * @dev: Device that requests the nvmem cell. * @cell_id: Name of nvmem cell to read.
It's "an unsigned" but "a U". Similarly, "an entry" but "a binary entry". While at it, also drop superfluous articles for negative and zero. Fixes: 8b977c5498b8 ("nvmem: core: add nvmem_cell_read_u64") Fixes: 0a9b2d1ce422 ("nvmem: core: add nvmem_cell_read_u16") Fixes: d026d70a2e94 ("nvmem: core: Add nvmem_cell_read_u32") Fixes: f1f50eca5f90 ("nvmem: Introduce devm_nvmem_(un)register()") Fixes: eace75cfdcf7 ("nvmem: Add a simple NVMEM framework for nvmem providers") Signed-off-by: Andreas Färber <afaerber@suse.de> --- In theory, for clean backports this would need to be split into 5 pieces... Not sure whether anyone would actually do that for help text? Dropping the Fixes headers might be an alternative. v2: New drivers/nvmem/core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)