mbox series

[0/4] btrfs-progs: get rid of btrfs_raid_profile_table

Message ID 20200623141019.23991-1-jth@kernel.org (mailing list archive)
Headers show
Series btrfs-progs: get rid of btrfs_raid_profile_table | expand

Message

Johannes Thumshirn June 23, 2020, 2:10 p.m. UTC
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>

As promised here's the removal of btrfs_raid_profile_table which helped as a
intermediate step to refactor the raid specific settings in block group
creation in progs.

As Qu remindet me of the outstanding debts this morning, I decided to go ahead
and pay my debt today.

It will not be the last refactoring round in this area though, as the
btrfs-progs side and the kernel side still diverge a lot.

This series passes a full 'make test' run from btrfs-progs.

Johannes Thumshirn (4):
  btrfs-progs: use sub_stripes property from btrfs_raid_attr
  btrfs-progs: use minimal number of stripes from btrfs_raid_attr
  btrfs-progs: remove unused btrfs_raid_profile::max_stripes
  btrfs-progs: remove btrfs_raid_profile_table

 volumes.c | 71 +++++--------------------------------------------------
 1 file changed, 6 insertions(+), 65 deletions(-)

Comments

David Sterba June 23, 2020, 3:45 p.m. UTC | #1
On Tue, Jun 23, 2020 at 04:10:15PM +0200, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> As promised here's the removal of btrfs_raid_profile_table which helped as a
> intermediate step to refactor the raid specific settings in block group
> creation in progs.
> 
> As Qu remindet me of the outstanding debts this morning, I decided to go ahead
> and pay my debt today.
> 
> It will not be the last refactoring round in this area though, as the
> btrfs-progs side and the kernel side still diverge a lot.

Thanks, all look good. This level of granularity makes review easy and
as said before, the intermediate patches are ok esp when the code
diverged.