diff mbox

[5/7] omap: iovmm: remove unused functionality

Message ID 20110818.131928.751866371806910622.Hiroshi.DOYU@nokia.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hiroshi DOYU Aug. 18, 2011, 10:19 a.m. UTC 
Hi Ohad,

From: ext Ohad Ben-Cohen <ohad@wizery.com>
Subject: [PATCH 5/7] omap: iovmm: remove unused functionality
Date: Thu, 18 Aug 2011 02:10:06 +0300

> Remove unused functionality from OMAP's iovmm module.
> 
> The intention is to eventually completely replace iovmm with the
> generic DMA-API, so new code that'd need this iovmm functionality
> will have to extend the DMA-API instead.

Maybe it's better to remove the comments explaining unnecessary
functions too. Now the function comparison table doesn't make sense....

From c42c675f62241099a10e4610640e6a60fb111f1f Mon Sep 17 00:00:00 2001
From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Date: Thu, 18 Aug 2011 13:13:53 +0300
Subject: [PATCH 1/1] omap: iommu: remove obsolete comments

Remove ones referring to non-existing functions.

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 drivers/iommu/omap-iovmm.c |   36 +-----------------------------------
 1 files changed, 1 insertions(+), 35 deletions(-)

Comments

Ohad Ben Cohen Aug. 18, 2011, 10:23 a.m. UTC | #1 
On Thu, Aug 18, 2011 at 1:19 PM, Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> Maybe it's better to remove the comments explaining unnecessary
> functions too. Now the function comparison table doesn't make sense....

Sure, will do.

> From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> Date: Thu, 18 Aug 2011 13:13:53 +0300
> Subject: [PATCH 1/1] omap: iommu: remove obsolete comments
>
> Remove ones referring to non-existing functions.

I think it might be better to squash it with the original patch though
- are you ok with it ?

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hiroshi DOYU Aug. 18, 2011, 12:45 p.m. UTC | #2 
From: ext Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH 5/7] omap: iovmm: remove unused functionality
Date: Thu, 18 Aug 2011 13:23:44 +0300

> On Thu, Aug 18, 2011 at 1:19 PM, Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
>> Maybe it's better to remove the comments explaining unnecessary
>> functions too. Now the function comparison table doesn't make sense....
> 
> Sure, will do.
> 
>> From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
>> Date: Thu, 18 Aug 2011 13:13:53 +0300
>> Subject: [PATCH 1/1] omap: iommu: remove obsolete comments
>>
>> Remove ones referring to non-existing functions.
> 
> I think it might be better to squash it with the original patch though
> - are you ok with it ?

Sure.

> 
> Thanks,
> Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c
index 81b713a..2db655c 100644
--- a/drivers/iommu/omap-iovmm.c
+++ b/drivers/iommu/omap-iovmm.c
@@ -1,7 +1,7 @@ 
 /*
  * omap iommu: simple virtual address space management
  *
- * Copyright (C) 2008-2009 Nokia Corporation
+ * Copyright (C) 2008-2009, 2011 Nokia Corporation
  *
  * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
  *
@@ -25,40 +25,6 @@ 
 
 #include <plat/iopgtable.h>
 
-/*
- * A device driver needs to create address mappings between:
- *
- * - iommu/device address
- * - physical address
- * - mpu virtual address
- *
- * There are 4 possible patterns for them:
- *
- *    |iova/			  mapping		iommu_		page
- *    | da	pa	va	(d)-(p)-(v)		function	type
- *  ---------------------------------------------------------------------------
- *  1 | c	c	c	 1 - 1 - 1	  _kmap() / _kunmap()	s
- *  2 | c	c,a	c	 1 - 1 - 1	_kmalloc()/ _kfree()	s
- *  3 | c	d	c	 1 - n - 1	  _vmap() / _vunmap()	s
- *  4 | c	d,a	c	 1 - n - 1	_vmalloc()/ _vfree()	n*
- *
- *
- *	'iova':	device iommu virtual address
- *	'da':	alias of 'iova'
- *	'pa':	physical address
- *	'va':	mpu virtual address
- *
- *	'c':	contiguous memory area
- *	'd':	discontiguous memory area
- *	'a':	anonymous memory allocation
- *	'()':	optional feature
- *
- *	'n':	a normal page(4KB) size is used.
- *	's':	multiple iommu superpage(16MB, 1MB, 64KB, 4KB) size is used.
- *
- *	'*':	not yet, but feasible.
- */
-
 static struct kmem_cache *iovm_area_cachep;
 
 /* return total bytes of sg buffers */