| Message ID | 20200612125402.18393-1-merlijn@wizzup.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add SW_MACHINE_COVER key | expand |
On Fri 2020-06-12 14:53:57, Merlijn Wajer wrote: > this series adds the sw_machine_cover key, and changes the nokia n900 dts to > expose the key via gpio-keys. > > before, this gpio was used as card detect gpio, causing the card not to show up > if the phone was booted without cover, see this thread on linux-omap: > > n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18) > > since there is no realistic use for using this gpio as card detect, instead > expose it to userspace via gpio-keys. there are no event type for machine covers > yet, so add that first. > > the key should be 1 when the cover is closed, and 0 when the cover is open. > > starting the nokia n900 with the cover removed, putting the cover in place: > > event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1 > > removing the cover again, exposing mmc1 and the battery: > > event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0 Looks good to me. Acked-by: Pavel Machek <pavel@ucw.cz> Pavel
On Fri, Jun 12, 2020 at 02:53:57PM +0200, Merlijn Wajer wrote: Applied, thank you.
this series adds the sw_machine_cover key, and changes the nokia n900 dts to expose the key via gpio-keys. before, this gpio was used as card detect gpio, causing the card not to show up if the phone was booted without cover, see this thread on linux-omap: n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18) since there is no realistic use for using this gpio as card detect, instead expose it to userspace via gpio-keys. there are no event type for machine covers yet, so add that first. the key should be 1 when the cover is closed, and 0 when the cover is open. starting the nokia n900 with the cover removed, putting the cover in place: event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1 removing the cover again, exposing mmc1 and the battery: event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0 Merlijn Wajer (2): Input: add `SW_MACHINE_COVER` ARM: dts: n900: remove mmc1 card detect gpio arch/arm/boot/dts/omap3-n900.dts | 12 ++++++++---- include/linux/mod_devicetable.h | 2 +- include/uapi/linux/input-event-codes.h | 3 ++- 3 files changed, 11 insertions(+), 6 deletions(-)