mbox series

[v3,0/6] Make fstests support new behavior of DAX

Message ID 20200630135951.21202-1-yangx.jy@cn.fujitsu.com (mailing list archive)
Headers show
Series Make fstests support new behavior of DAX | expand

Message

Xiao Yang June 30, 2020, 1:59 p.m. UTC
The new behavior of DAX on xfs/ext4 has been merged into main kernel
tree/ext4-dax branch so it is time for fstests to support new behavior
of DAX.

References:
https://lkml.org/lkml/2019/10/20/96
https://lkml.org/lkml/2020/5/28/949

Xiao Yang (6):
  common/rc: Introduce new helpers for DAX mount options and
    FS_XFLAG_DAX
  fstests: Use _require_scratch_dax_mountopt() and
    _require_scratch_dax_iflag()
  common/rc: Remove unused _require_scratch_dax()
  generic/223: Don't clear all mkfs options for _scratch_mkfs_geom()
    roughly
  generic/413, xfs/260: Improve format operation for PMD fault testing
  xfs/260: Move and update xfs/260

 common/rc                      | 60 ++++++++++++++++++++++++----
 tests/ext4/030                 |  2 +-
 tests/ext4/031                 |  4 +-
 tests/generic/223              |  1 -
 tests/generic/413              | 12 ++----
 tests/generic/462              |  2 +-
 tests/{xfs/260 => generic/603} | 71 +++++++++++++++++-----------------
 tests/generic/603.out          |  2 +
 tests/generic/group            |  1 +
 tests/xfs/260.out              |  2 -
 tests/xfs/group                |  1 -
 11 files changed, 97 insertions(+), 61 deletions(-)
 rename tests/{xfs/260 => generic/603} (54%)
 create mode 100644 tests/generic/603.out
 delete mode 100644 tests/xfs/260.out

Comments

Ira Weiny June 30, 2020, 8:34 p.m. UTC | #1
On Tue, Jun 30, 2020 at 09:59:45PM +0800, Xiao Yang wrote:
> The new behavior of DAX on xfs/ext4 has been merged into main kernel
> tree/ext4-dax branch so it is time for fstests to support new behavior
> of DAX.
> 
> References:
> https://lkml.org/lkml/2019/10/20/96
> https://lkml.org/lkml/2020/5/28/949
> 
> Xiao Yang (6):
>   common/rc: Introduce new helpers for DAX mount options and
>     FS_XFLAG_DAX
>   fstests: Use _require_scratch_dax_mountopt() and
>     _require_scratch_dax_iflag()
>   common/rc: Remove unused _require_scratch_dax()

Have the first 3 patches changed?  If not you could have added my Reviewed-by
from v2?[1]

Not sure if I need to look at them or not.

Ira

[1]
https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#mb0235e57045c4f7a3bc70c7745f2b7065bb3e3c1
https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#ma472463b67a354484a054cf0c0c1bf3c8567937b
https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#m5d44764e500370ceb4a350b4ae0df9bec8c08b56


>   generic/223: Don't clear all mkfs options for _scratch_mkfs_geom()
>     roughly
>   generic/413, xfs/260: Improve format operation for PMD fault testing
>   xfs/260: Move and update xfs/260
> 
>  common/rc                      | 60 ++++++++++++++++++++++++----
>  tests/ext4/030                 |  2 +-
>  tests/ext4/031                 |  4 +-
>  tests/generic/223              |  1 -
>  tests/generic/413              | 12 ++----
>  tests/generic/462              |  2 +-
>  tests/{xfs/260 => generic/603} | 71 +++++++++++++++++-----------------
>  tests/generic/603.out          |  2 +
>  tests/generic/group            |  1 +
>  tests/xfs/260.out              |  2 -
>  tests/xfs/group                |  1 -
>  11 files changed, 97 insertions(+), 61 deletions(-)
>  rename tests/{xfs/260 => generic/603} (54%)
>  create mode 100644 tests/generic/603.out
>  delete mode 100644 tests/xfs/260.out
> 
> -- 
> 2.21.0
> 
> 
>
Xiao Yang July 1, 2020, 1:10 a.m. UTC | #2
On 2020/7/1 4:34, Ira Weiny wrote:
> On Tue, Jun 30, 2020 at 09:59:45PM +0800, Xiao Yang wrote:
>> The new behavior of DAX on xfs/ext4 has been merged into main kernel
>> tree/ext4-dax branch so it is time for fstests to support new behavior
>> of DAX.
>>
>> References:
>> https://lkml.org/lkml/2019/10/20/96
>> https://lkml.org/lkml/2020/5/28/949
>>
>> Xiao Yang (6):
>>    common/rc: Introduce new helpers for DAX mount options and
>>      FS_XFLAG_DAX
>>    fstests: Use _require_scratch_dax_mountopt() and
>>      _require_scratch_dax_iflag()
>>    common/rc: Remove unused _require_scratch_dax()
> Have the first 3 patches changed?  If not you could have added my Reviewed-by
> from v2?[1]
>
> Not sure if I need to look at them or not.
Hi Ira,

I didn't change the first 3 patches.
Sorry, I forget to add your Reviewed-by and will add it in v4 patch.

Best Regards,
Xiao Yang
> Ira
>
> [1]
> https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#mb0235e57045c4f7a3bc70c7745f2b7065bb3e3c1
> https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#ma472463b67a354484a054cf0c0c1bf3c8567937b
> https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#m5d44764e500370ceb4a350b4ae0df9bec8c08b56
>
>
>>    generic/223: Don't clear all mkfs options for _scratch_mkfs_geom()
>>      roughly
>>    generic/413, xfs/260: Improve format operation for PMD fault testing
>>    xfs/260: Move and update xfs/260
>>
>>   common/rc                      | 60 ++++++++++++++++++++++++----
>>   tests/ext4/030                 |  2 +-
>>   tests/ext4/031                 |  4 +-
>>   tests/generic/223              |  1 -
>>   tests/generic/413              | 12 ++----
>>   tests/generic/462              |  2 +-
>>   tests/{xfs/260 =>  generic/603} | 71 +++++++++++++++++-----------------
>>   tests/generic/603.out          |  2 +
>>   tests/generic/group            |  1 +
>>   tests/xfs/260.out              |  2 -
>>   tests/xfs/group                |  1 -
>>   11 files changed, 97 insertions(+), 61 deletions(-)
>>   rename tests/{xfs/260 =>  generic/603} (54%)
>>   create mode 100644 tests/generic/603.out
>>   delete mode 100644 tests/xfs/260.out
>>
>> -- 
>> 2.21.0
>>
>>
>>
>
> .
>
Ira Weiny July 1, 2020, 4:07 p.m. UTC | #3
On Wed, Jul 01, 2020 at 09:10:15AM +0800, Xiao Yang wrote:
> On 2020/7/1 4:34, Ira Weiny wrote:
> > On Tue, Jun 30, 2020 at 09:59:45PM +0800, Xiao Yang wrote:
> > > The new behavior of DAX on xfs/ext4 has been merged into main kernel
> > > tree/ext4-dax branch so it is time for fstests to support new behavior
> > > of DAX.
> > > 
> > > References:
> > > https://lkml.org/lkml/2019/10/20/96
> > > https://lkml.org/lkml/2020/5/28/949
> > > 
> > > Xiao Yang (6):
> > >    common/rc: Introduce new helpers for DAX mount options and
> > >      FS_XFLAG_DAX
> > >    fstests: Use _require_scratch_dax_mountopt() and
> > >      _require_scratch_dax_iflag()
> > >    common/rc: Remove unused _require_scratch_dax()
> > Have the first 3 patches changed?  If not you could have added my Reviewed-by
> > from v2?[1]
> > 
> > Not sure if I need to look at them or not.
> Hi Ira,
> 
> I didn't change the first 3 patches.
> Sorry, I forget to add your Reviewed-by and will add it in v4 patch.

Cool!  NP I just did not want to go through them if I did not have to!  :-D

Ira

> 
> Best Regards,
> Xiao Yang
> > Ira
> > 
> > [1]
> > https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#mb0235e57045c4f7a3bc70c7745f2b7065bb3e3c1
> > https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#ma472463b67a354484a054cf0c0c1bf3c8567937b
> > https://lore.kernel.org/fstests/b0d5803e-81e4-bb14-f47b-44036284577e@163.com/T/#m5d44764e500370ceb4a350b4ae0df9bec8c08b56
> > 
> > 
> > >    generic/223: Don't clear all mkfs options for _scratch_mkfs_geom()
> > >      roughly
> > >    generic/413, xfs/260: Improve format operation for PMD fault testing
> > >    xfs/260: Move and update xfs/260
> > > 
> > >   common/rc                      | 60 ++++++++++++++++++++++++----
> > >   tests/ext4/030                 |  2 +-
> > >   tests/ext4/031                 |  4 +-
> > >   tests/generic/223              |  1 -
> > >   tests/generic/413              | 12 ++----
> > >   tests/generic/462              |  2 +-
> > >   tests/{xfs/260 =>  generic/603} | 71 +++++++++++++++++-----------------
> > >   tests/generic/603.out          |  2 +
> > >   tests/generic/group            |  1 +
> > >   tests/xfs/260.out              |  2 -
> > >   tests/xfs/group                |  1 -
> > >   11 files changed, 97 insertions(+), 61 deletions(-)
> > >   rename tests/{xfs/260 =>  generic/603} (54%)
> > >   create mode 100644 tests/generic/603.out
> > >   delete mode 100644 tests/xfs/260.out
> > > 
> > > -- 
> > > 2.21.0
> > > 
> > > 
> > > 
> > 
> > .
> > 
> 
> 
>