| Message ID | 20200620133207.26849-3-aleksandar.qemu.devel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | checkpatch: Do appropriate kernel->qemu renaming | expand |
On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> wrote: > > It is odd that we inform user that, for example, his current working > directory is not kernel root, when, in face, we mean qemu root. > > Replace that and few other similar odd user messages. > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > scripts/checkpatch.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Regardless of my comments on the cover letter, for user facing messages this makes sense, especially since it's only 3 lines. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On Sat, Jun 20, 2020 at 9:32 AM Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> wrote: > > It is odd that we inform user that, for example, his current working > directory is not kernel root, when, in face, we mean qemu root. > > Replace that and few other similar odd user messages. > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- Paolo, Stefan, Michael, Are some of you willing to select this patch for your queues? I could include it in my mips queue, scheduled to be sent soon, but I certainly don't want to be seen intruding into someone else's area. Truly yours, Aleksandar > scripts/checkpatch.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index c760c5a4a9..f46c18e413 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -49,7 +49,7 @@ Version: $V > > Options: > -q, --quiet quiet > - --no-tree run without a kernel tree > + --no-tree run without a qemu tree > --no-signoff do not check for 'Signed-off-by' line > --patch treat FILE as patchfile > --branch treat args as GIT revision list > @@ -57,7 +57,7 @@ Options: > --terse one line per report > -f, --file treat FILE as regular source file > --strict fail if only warnings are found > - --root=PATH PATH to the kernel tree root > + --root=PATH PATH to the qemu tree root > --no-summary suppress the per-file summary > --mailback only produce a report in case of warnings/errors > --summary-file include the filename in summary > @@ -203,7 +203,7 @@ if ($tree) { > } > > if (!defined $root) { > - print "Must be run from the top-level dir. of a kernel tree\n"; > + print "Must be run from the top-level dir. of a qemu tree\n"; > exit(2); > } > } > -- > 2.20.1 >
On 20/06/20 17:04, Peter Maydell wrote: > On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic > <aleksandar.qemu.devel@gmail.com> wrote: >> >> It is odd that we inform user that, for example, his current working >> directory is not kernel root, when, in face, we mean qemu root. >> >> Replace that and few other similar odd user messages. >> >> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> --- >> scripts/checkpatch.pl | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > Regardless of my comments on the cover letter, for user facing > messages this makes sense, especially since it's only 3 lines. > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > thanks > -- PMM > Queued, thanks. paolo
On Wed, Jul 1, 2020 at 4:20 PM Paolo Bonzini <pbonzini@redhat.com> wrote: > > On 20/06/20 17:04, Peter Maydell wrote: > > On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic > > <aleksandar.qemu.devel@gmail.com> wrote: > >> > >> It is odd that we inform user that, for example, his current working > >> directory is not kernel root, when, in face, we mean qemu root. > >> > >> Replace that and few other similar odd user messages. > >> > >> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >> --- > >> scripts/checkpatch.pl | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Regardless of my comments on the cover letter, for user facing > > messages this makes sense, especially since it's only 3 lines. > > > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > > > thanks > > -- PMM > > > > Queued, thanks. > Thanks a lot, Paolo. There is though one spelling mistake in my commit message: s/face/fact Truly yours, Aleksandar > paolo >
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c760c5a4a9..f46c18e413 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -49,7 +49,7 @@ Version: $V Options: -q, --quiet quiet - --no-tree run without a kernel tree + --no-tree run without a qemu tree --no-signoff do not check for 'Signed-off-by' line --patch treat FILE as patchfile --branch treat args as GIT revision list @@ -57,7 +57,7 @@ Options: --terse one line per report -f, --file treat FILE as regular source file --strict fail if only warnings are found - --root=PATH PATH to the kernel tree root + --root=PATH PATH to the qemu tree root --no-summary suppress the per-file summary --mailback only produce a report in case of warnings/errors --summary-file include the filename in summary @@ -203,7 +203,7 @@ if ($tree) { } if (!defined $root) { - print "Must be run from the top-level dir. of a kernel tree\n"; + print "Must be run from the top-level dir. of a qemu tree\n"; exit(2); } }
It is odd that we inform user that, for example, his current working directory is not kernel root, when, in face, we mean qemu root. Replace that and few other similar odd user messages. Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)