| Message ID | 20200707101642.1747944-1-lee.jones@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Clean-up ASoC's W=1 build warnings | expand |
On Tue, Jul 07, 2020 at 11:16:14AM +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Please coordinate with Pierre (CCed) who is also submitting patches for this issue, there's a whole bunch in flight already.
On Tue, 07 Jul 2020, Mark Brown wrote: > On Tue, Jul 07, 2020 at 11:16:14AM +0100, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > Please coordinate with Pierre (CCed) who is also submitting patches for > this issue, there's a whole bunch in flight already. Well that's frustrating. Some of these issues have been present for years. It's quite the coincidence that we both submitted these this week!
On Tue, Jul 07, 2020 at 11:37:35AM +0100, Lee Jones wrote: > Some of these issues have been present for years. It's quite the > coincidence that we both submitted these this week! I'm guessing you've both been inspired by the 0day bot turning W=1 warnings on without having first done a cleanup run :/
On 7/7/20 5:40 AM, Mark Brown wrote: > On Tue, Jul 07, 2020 at 11:37:35AM +0100, Lee Jones wrote: > >> Some of these issues have been present for years. It's quite the >> coincidence that we both submitted these this week! > > I'm guessing you've both been inspired by the 0day bot turning W=1 > warnings on without having first done a cleanup run :/ Yep, I was tired of seeing my email polluted with trivial problems last week, as well as seeing dead code that reviewers miss but tools don't. Lee, do you mind if I merge your v2 series and my own v2, and then resubmit what hasn't been merged by Mark?
On Tue, 7 Jul 2020, 16:44 Pierre-Louis Bossart, < pierre-louis.bossart@linux.intel.com> wrote: > > > On 7/7/20 5:40 AM, Mark Brown wrote: > > On Tue, Jul 07, 2020 at 11:37:35AM +0100, Lee Jones wrote: > > > >> Some of these issues have been present for years. It's quite the > >> coincidence that we both submitted these this week! > > > > I'm guessing you've both been inspired by the 0day bot turning W=1 > > warnings on without having first done a cleanup run :/ > > Yep, I was tired of seeing my email polluted with trivial problems last > week, as well as seeing dead code that reviewers miss but tools don't. > > Lee, do you mind if I merge your v2 series and my own v2, and then > resubmit what hasn't been merged by Mark? > Go for it. >
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. After these patches are applied, the build system no longer complains about any W=0 nor W=1 level warnings in sound/soc. Hurrah! Lee Jones (28): ASoC: atmel: atmel-pcm-dma: Demote function header which is clearly not kerneldoc ASoC: atmel: atmel_ssc_dai: Demote function header which is clearly not kerneldoc ASoC: fsl: fsl-asoc-card: Use correct format when providing struct documentation ASoC: fsl: fsl_asrc: Demote obvious misuse of kerneldoc to standard comment blocks ASoC: fsl: fsl_ssi: Demote obvious misuse of kerneldoc to standard comment blocks ASoC: fsl: fsl_ssi_dbg: Demote obvious misuse of kerneldoc to standard comment blocks ASoC: fsl: fsl_spdif: Use correct formatting when denoting struct documentation ASoC: fsl: fsl_spdif: Update 'struct fsl_spdif_priv's descriptions ASoC: fsl: fsl_esai: Fix a bunch of kerneldoc issues ASoC: fsl: fsl_esai: Add descriptions for 'tx_mask' and 'rx_mask' to 'fsl_esai' ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header ASoC: codecs: ak4458: Remove set but never checked variable 'ret' ASoC: qcom: qdsp6: q6asm: Provide documentation for WMA 'codec_profile' ASoC: samsung: pcm: Demote half-documented kerneldoc header ASoC: samsung: spdif: Fix 3 misspelled struct properties ASoC: sunxi: sun4i-i2s: Demote half-documented kerneldoc header ASoC: uniphier: aio-core: Fix incorrectly named struct property and remove another ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' ASoC: codecs: da7210: Fix formatting issues in da7210_set_dai_pll() header ASoC: soc-ac97: Demote seemingly unintentional kerneldoc header ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost_tlv' ASoC: codecs: rt5631: Demote misuse of kerneldoc to standard comment blocks ASoC: codecs: rt5659: Remove many unused const variables ASoC: codecs: tlv320aic26: Demote seemingly unintentional kerneldoc header ASoC: codecs: wm8400: Remove a bunch of unused variables sound/soc/atmel/atmel-pcm-dma.c | 2 +- sound/soc/atmel/atmel_ssc_dai.c | 2 +- sound/soc/codecs/ak4458.c | 6 +++--- sound/soc/codecs/da7210.c | 12 ++++++----- sound/soc/codecs/jz4770.c | 1 - sound/soc/codecs/rt5631.c | 12 +++++------ sound/soc/codecs/rt5659.c | 37 --------------------------------- sound/soc/codecs/tlv320aic26.c | 2 +- sound/soc/codecs/wm8400.c | 12 ----------- sound/soc/fsl/fsl-asoc-card.c | 16 +++++++------- sound/soc/fsl/fsl_asrc.c | 28 ++++++++++++------------- sound/soc/fsl/fsl_esai.c | 19 ++++++++++------- sound/soc/fsl/fsl_spdif.c | 5 +++-- sound/soc/fsl/fsl_ssi.c | 28 ++++++++++++------------- sound/soc/fsl/fsl_ssi_dbg.c | 4 ++-- sound/soc/pxa/pxa-ssp.c | 2 +- sound/soc/qcom/qdsp6/q6asm.c | 1 + sound/soc/samsung/pcm.c | 2 +- sound/soc/samsung/spdif.c | 6 +++--- sound/soc/soc-ac97.c | 2 +- sound/soc/sti/uniperif.h | 2 +- sound/soc/sunxi/sun4i-i2s.c | 2 +- sound/soc/sunxi/sun4i-spdif.c | 2 +- sound/soc/ti/omap-mcbsp-st.c | 3 +-- sound/soc/uniphier/aio-core.c | 7 +++---- sound/soc/ux500/ux500_msp_i2s.c | 8 +++---- 26 files changed, 89 insertions(+), 134 deletions(-)