| Message ID | 20200708003209.4737-1-cphealy@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: zii-ultra: update MDIO speed and preamble device | expand |
Hi Chris, On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <cphealy@gmail.com> wrote: > #address-cells = <1>; > #size-cells = <0>; > status = "okay"; > + suppress-preamble; > + clock-frequency = <12500000>; Sorry, I missed this in the previous review. The recommendation is to have status = okay as the last property. Please move suppress-preamble and clock-frequency = <12500000> prior to status = "okay"
On Tue, Jul 7, 2020 at 5:41 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Chris, > > On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <cphealy@gmail.com> wrote: > > > #address-cells = <1>; > > #size-cells = <0>; > > status = "okay"; > > + suppress-preamble; > > + clock-frequency = <12500000>; > > Sorry, I missed this in the previous review. > > The recommendation is to have status = okay as the last property. > > Please move suppress-preamble and clock-frequency = <12500000> prior > to status = "okay" Will do in the next version.
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi index 6a55165bd76a..98aa67a4c040 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi @@ -132,6 +132,8 @@ #address-cells = <1>; #size-cells = <0>; status = "okay"; + suppress-preamble; + clock-frequency = <12500000>; switch: switch@0 { compatible = "marvell,mv88e6085";
Update MDIO configuration with zii-ultra device to fully utilize MDIO endpoint capabilities. Device supports 12.5MHz clock and doesn't require MDIO preamble. Signed-off-by: Chris Healy <cphealy@gmail.com> --- v2: - Fix subject line to reference zii-ultra: - Get rid of "=<1>;" from suppress-preamble lines arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++ 1 file changed, 2 insertions(+)