| Message ID | 20200707184730.3047754-2-hskinnemoen@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines | expand |
On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > Add a config symbol for the NPCM7xx BMC SoC family that subsequent > patches can use in Makefiles. > > Reviewed-by: Tyrone Ting <kfting@nuvoton.com> > Acked-by: Joel Stanley <joel@jms.id.au> > Signed-off-by: Havard Skinnemoen <hskinnemoen@google.com> > --- > default-configs/arm-softmmu.mak | 1 + > hw/arm/Kconfig | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 8fc09a4a51..9a94ebd0be 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -27,6 +27,7 @@ CONFIG_GUMSTIX=y > CONFIG_SPITZ=y > CONFIG_TOSA=y > CONFIG_Z2=y > +CONFIG_NPCM7XX=y I'd squash this in patch 6: "Add two NPCM7xx-based machines" > CONFIG_COLLIE=y > CONFIG_ASPEED_SOC=y > CONFIG_NETDUINO2=y > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 4a224a6351..a31d0d282f 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -354,6 +354,14 @@ config XLNX_VERSAL > select VIRTIO_MMIO > select UNIMP > > +config NPCM7XX > + bool > + select A9MPCORE > + select ARM_GIC > + select PL310 # cache controller > + select SERIAL > + select UNIMP And this in patch 5: "Add NPCM730 and NPCM750 SoC models" > + > config FSL_IMX25 > bool > select IMX >
On Wed, Jul 8, 2020 at 9:56 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > +config NPCM7XX > > + bool > > + select A9MPCORE > > + select ARM_GIC > > + select PL310 # cache controller > > + select SERIAL > > + select UNIMP > > And this in patch 5: "Add NPCM730 and NPCM750 SoC models" Is it still OK for earlier patches to use $(CONFIG_NPCM7XX) in Makefiles?
On 7/8/20 6:58 PM, Havard Skinnemoen wrote: > On Wed, Jul 8, 2020 at 9:56 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >>> +config NPCM7XX >>> + bool >>> + select A9MPCORE >>> + select ARM_GIC >>> + select PL310 # cache controller >>> + select SERIAL >>> + select UNIMP >> >> And this in patch 5: "Add NPCM730 and NPCM750 SoC models" > > Is it still OK for earlier patches to use $(CONFIG_NPCM7XX) in Makefiles? > I haven't reviewed them yet, so no. I'd do this way: - Add to the first peripheral that requires $(CONFIG_NPCM7XX): config NPCM7XX bool - Then when you add the SoC, complete with: select A9MPCORE select ARM_GIC select PL310 # cache controller select SERIAL select UNIMP
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak index 8fc09a4a51..9a94ebd0be 100644 --- a/default-configs/arm-softmmu.mak +++ b/default-configs/arm-softmmu.mak @@ -27,6 +27,7 @@ CONFIG_GUMSTIX=y CONFIG_SPITZ=y CONFIG_TOSA=y CONFIG_Z2=y +CONFIG_NPCM7XX=y CONFIG_COLLIE=y CONFIG_ASPEED_SOC=y CONFIG_NETDUINO2=y diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 4a224a6351..a31d0d282f 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -354,6 +354,14 @@ config XLNX_VERSAL select VIRTIO_MMIO select UNIMP +config NPCM7XX + bool + select A9MPCORE + select ARM_GIC + select PL310 # cache controller + select SERIAL + select UNIMP + config FSL_IMX25 bool select IMX