| Message ID | 20200708095500.13694-1-grandmaster@al2klimov.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e46d8cb5f147955d77b0517f4bcb45e128d75525 |
| Headers | show |
| Series | Replace HTTP links with HTTPS ones: USB MASS STORAGE DRIVER | expand |
On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > If both the HTTP and HTTPS versions > return 200 OK and serve the same content: > Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> Your subject lines are very odd compared to all patches for this subsystem, as well as all other kernel subsystems. Any reason you are doing it this way and not the normal and standard method of: USB: storage: replace http links with https That would look more uniform as well as not shout at anyone. thanks, greg k-h
Am 08.07.20 um 12:39 schrieb Greg KH: > On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: >> Rationale: >> Reduces attack surface on kernel devs opening the links for MITM >> as HTTPS traffic is much harder to manipulate. >> >> Deterministic algorithm: >> For each file: >> If not .svg: >> For each line: >> If doesn't contain `\bxmlns\b`: >> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: >> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: >> If both the HTTP and HTTPS versions >> return 200 OK and serve the same content: >> Replace HTTP with HTTPS. >> >> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > > Your subject lines are very odd compared to all patches for this > subsystem, as well as all other kernel subsystems. Any reason you are > doing it this way and not the normal and standard method of: > USB: storage: replace http links with https > > That would look more uniform as well as not shout at anyone. > > thanks, > > greg k-h > Hi, I'm very sorry. As Torvalds has merged 93431e0607e5 and many of you devs (including big maintainers like David Miller) just applied this stuff, I assumed that's OK. And now I've rolled out tens of patches via shell loop... *sigh* As this is the third (I think) change request like this, I assume this rule applies to all subsystems – right? Best, AK
On Wed, Jul 08, 2020 at 08:41:54PM +0200, Alexander A. Klimov wrote: > > > Am 08.07.20 um 12:39 schrieb Greg KH: > > On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: > > > Rationale: > > > Reduces attack surface on kernel devs opening the links for MITM > > > as HTTPS traffic is much harder to manipulate. > > > > > > Deterministic algorithm: > > > For each file: > > > If not .svg: > > > For each line: > > > If doesn't contain `\bxmlns\b`: > > > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > > > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > > > If both the HTTP and HTTPS versions > > > return 200 OK and serve the same content: > > > Replace HTTP with HTTPS. > > > > > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > > > > Your subject lines are very odd compared to all patches for this > > subsystem, as well as all other kernel subsystems. Any reason you are > > doing it this way and not the normal and standard method of: > > USB: storage: replace http links with https > > > > That would look more uniform as well as not shout at anyone. > > > > thanks, > > > > greg k-h > > > Hi, > > I'm very sorry. > > As Torvalds has merged 93431e0607e5 and many of you devs (including big > maintainers like David Miller) just applied this stuff, I assumed that's OK. > > And now I've rolled out tens of patches via shell loop... *sigh* > > As this is the third (I think) change request like this, I assume this rule > applies to all subsystems – right? Yes, you should try to emulate what the subsystem does, look at other patches for the same files, but the format I suggested is almost always the correct one. If not, I'm sure maintainers will be glad to tell you otherwise :) thanks, greg k-h
On Thu, Jul 09, 2020 at 08:14:09AM +0200, Greg KH wrote: > On Wed, Jul 08, 2020 at 08:41:54PM +0200, Alexander A. Klimov wrote: > > > > > > Am 08.07.20 um 12:39 schrieb Greg KH: > > > On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: > > > > Rationale: > > > > Reduces attack surface on kernel devs opening the links for MITM > > > > as HTTPS traffic is much harder to manipulate. > > > > > > > > Deterministic algorithm: > > > > For each file: > > > > If not .svg: > > > > For each line: > > > > If doesn't contain `\bxmlns\b`: > > > > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > > > > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > > > > If both the HTTP and HTTPS versions > > > > return 200 OK and serve the same content: > > > > Replace HTTP with HTTPS. > > > > > > > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > > > > > > Your subject lines are very odd compared to all patches for this > > > subsystem, as well as all other kernel subsystems. Any reason you are > > > doing it this way and not the normal and standard method of: > > > USB: storage: replace http links with https > > > > > > That would look more uniform as well as not shout at anyone. I would agree. The OpenRISC patch for this series says: "OPENRISC ARCHITECTURE:..." Here it would just be "openrisc:..." I think fixing the whole series is needed. Greg is not the only on complaining. Ideally, I think, it would be good to have this sent out as a series i.e [PATCH 3/55] rather than individual patches so this could be discussed as a whole. -Stafford > > > thanks, > > > > > > greg k-h > > > > > Hi, > > > > I'm very sorry. > > > > As Torvalds has merged 93431e0607e5 and many of you devs (including big > > maintainers like David Miller) just applied this stuff, I assumed that's OK. > > > > And now I've rolled out tens of patches via shell loop... *sigh* > > > > As this is the third (I think) change request like this, I assume this rule > > applies to all subsystems – right? > > Yes, you should try to emulate what the subsystem does, look at other > patches for the same files, but the format I suggested is almost always > the correct one. If not, I'm sure maintainers will be glad to tell you > otherwise :)
Am 10.07.20 um 12:36 schrieb Stafford Horne: > On Thu, Jul 09, 2020 at 08:14:09AM +0200, Greg KH wrote: >> On Wed, Jul 08, 2020 at 08:41:54PM +0200, Alexander A. Klimov wrote: >>> >>> >>> Am 08.07.20 um 12:39 schrieb Greg KH: >>>> On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: >>>>> Rationale: >>>>> Reduces attack surface on kernel devs opening the links for MITM >>>>> as HTTPS traffic is much harder to manipulate. >>>>> >>>>> Deterministic algorithm: >>>>> For each file: >>>>> If not .svg: >>>>> For each line: >>>>> If doesn't contain `\bxmlns\b`: >>>>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: >>>>> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: >>>>> If both the HTTP and HTTPS versions >>>>> return 200 OK and serve the same content: >>>>> Replace HTTP with HTTPS. >>>>> >>>>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> >>>> >>>> Your subject lines are very odd compared to all patches for this >>>> subsystem, as well as all other kernel subsystems. Any reason you are >>>> doing it this way and not the normal and standard method of: >>>> USB: storage: replace http links with https >>>> >>>> That would look more uniform as well as not shout at anyone. > > I would agree. The OpenRISC patch for this series says: > "OPENRISC ARCHITECTURE:..." > > Here it would just be "openrisc:..." I think fixing the whole series is needed. > Greg is not the only on complaining. > > Ideally, I think, it would be good to have this sent out as a series i.e [PATCH 3/55] > rather than individual patches so this could be discussed as a whole. 1) To who? As right now? As right now plus Torvalds, KH, Miller, etc.? As right now, but all-to-all? 2) Apropos "series" and "as whole"... I stumbled over `git log --oneline |grep -Fwe treewide` and am wondering: *Shouldn't all of these patches even begin with "treewide: "?* E.g.: "treewide: Replace HTTP links with HTTPS ones: GCC PLUGINS" > > -Stafford > >>>> thanks, >>>> >>>> greg k-h >>>> >>> Hi, >>> >>> I'm very sorry. >>> >>> As Torvalds has merged 93431e0607e5 and many of you devs (including big >>> maintainers like David Miller) just applied this stuff, I assumed that's OK. >>> >>> And now I've rolled out tens of patches via shell loop... *sigh* >>> >>> As this is the third (I think) change request like this, I assume this rule >>> applies to all subsystems – right? >> >> Yes, you should try to emulate what the subsystem does, look at other >> patches for the same files, but the format I suggested is almost always >> the correct one. If not, I'm sure maintainers will be glad to tell you >> otherwise :) > >
On Fri, Jul 10, 2020 at 09:36:03PM +0200, Alexander A. Klimov wrote: > > > Am 10.07.20 um 12:36 schrieb Stafford Horne: > > On Thu, Jul 09, 2020 at 08:14:09AM +0200, Greg KH wrote: > > > On Wed, Jul 08, 2020 at 08:41:54PM +0200, Alexander A. Klimov wrote: > > > > > > > > > > > > Am 08.07.20 um 12:39 schrieb Greg KH: > > > > > On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: > > > > > > Rationale: > > > > > > Reduces attack surface on kernel devs opening the links for MITM > > > > > > as HTTPS traffic is much harder to manipulate. > > > > > > > > > > > > Deterministic algorithm: > > > > > > For each file: > > > > > > If not .svg: > > > > > > For each line: > > > > > > If doesn't contain `\bxmlns\b`: > > > > > > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > > > > > > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > > > > > > If both the HTTP and HTTPS versions > > > > > > return 200 OK and serve the same content: > > > > > > Replace HTTP with HTTPS. > > > > > > > > > > > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > > > > > > > > > > Your subject lines are very odd compared to all patches for this > > > > > subsystem, as well as all other kernel subsystems. Any reason you are > > > > > doing it this way and not the normal and standard method of: > > > > > USB: storage: replace http links with https > > > > > > > > > > That would look more uniform as well as not shout at anyone. > > > > I would agree. The OpenRISC patch for this series says: > > "OPENRISC ARCHITECTURE:..." > > > > Here it would just be "openrisc:..." I think fixing the whole series is needed. > > Greg is not the only on complaining. > > > > Ideally, I think, it would be good to have this sent out as a series i.e [PATCH 3/55] > > rather than individual patches so this could be discussed as a whole. > 1) To who? As right now? As right now plus Torvalds, KH, Miller, etc.? > As right now, but all-to-all? Make sure you have a cover letter explaining what you expect. You can ask maintainers to pick up individual patches by mentioning that in the cover letter. You can use `git send-email --cc-cmd` so each patch goes only to the maintainers, for example: send-email --to linux-kernel@vger.kernel.org --cc-cmd scripts/get_maintainers.pl` > 2) Apropos "series" and "as whole"... I stumbled over I stumble over "apropos". :) > `git log --oneline |grep -Fwe treewide` > and am wondering: > *Shouldn't all of these patches even begin with "treewide: "?* > E.g.: "treewide: Replace HTTP links with HTTPS ones: GCC PLUGINS" As Greg said that is not what patch subjects loo like. - GCC PLUGINS: is not correct, remove it. - treewide: may work, but as you want individual maintainers to pick up the patches put a subsystem in the subject as maintainers like. - The rest of the text should be lowercase "replace http links with https" Have a look at other patch subject lines based on the file you are editing. For example: $ git log --oneline -- Documentation/kbuild/gcc-plugins.rst 2020-03-10 2b4cbd5c9505 Jonathan Corbet docs: move gcc-plugins to the kbuild manual $ git log --oneline -- scripts/Makefile.gcc-plugins 2019-03-04 81a56f6dcd20 Kees Cook gcc-plugins: structleak: Generalize to all variable types 2018-12-29 668c35f69cc7 Linus Torvalds Merge tag 'kbuild-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild 2018-12-12 189af4657186 Ard Biesheuvel ARM: smp: add support for per-task stack canaries 2018-12-01 ce2fd53a10c7 Masahiro Yamada kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile 2018-09-04 10e9ae9fabaf Alexander Popov gcc-plugins: Add STACKLEAK plugin for tracking the kernel stack 2018-07-24 7ccb95e8fe91 Kees Cook gcc-plugins: Regularize Makefile.gcc-plugins 2018-07-02 c17d6179ad5a Masahiro Yamada gcc-plugins: remove unused GCC_PLUGIN_SUBDIR 2018-06-11 59f53855babf Masahiro Yamada gcc-plugins: test plugin support in Kconfig and clean up Makefile 2018-06-11 8034c2fb1225 Masahiro Yamada gcc-plugins: move GCC version check for PowerPC to Kconfig 2018-06-11 5aadfdeb8de0 Masahiro Yamada kcov: test compiler capability in Kconfig and correct dependency So you will have: docs: replace http links with https gcc-plugins: replace http links with https -Stafford > > > > -Stafford > > > > > > > thanks, > > > > > > > > > > greg k-h > > > > > > > > > Hi, > > > > > > > > I'm very sorry. > > > > > > > > As Torvalds has merged 93431e0607e5 and many of you devs (including big > > > > maintainers like David Miller) just applied this stuff, I assumed that's OK. > > > > > > > > And now I've rolled out tens of patches via shell loop... *sigh* > > > > > > > > As this is the third (I think) change request like this, I assume this rule > > > > applies to all subsystems – right? > > > > > > Yes, you should try to emulate what the subsystem does, look at other > > > patches for the same files, but the format I suggested is almost always > > > the correct one. If not, I'm sure maintainers will be glad to tell you > > > otherwise :) > > > >
Am 10.07.20 um 22:55 schrieb Stafford Horne: > On Fri, Jul 10, 2020 at 09:36:03PM +0200, Alexander A. Klimov wrote: >> >> >> Am 10.07.20 um 12:36 schrieb Stafford Horne: >>> On Thu, Jul 09, 2020 at 08:14:09AM +0200, Greg KH wrote: >>>> On Wed, Jul 08, 2020 at 08:41:54PM +0200, Alexander A. Klimov wrote: >>>>> >>>>> >>>>> Am 08.07.20 um 12:39 schrieb Greg KH: >>>>>> On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: >>>>>>> Rationale: >>>>>>> Reduces attack surface on kernel devs opening the links for MITM >>>>>>> as HTTPS traffic is much harder to manipulate. >>>>>>> >>>>>>> Deterministic algorithm: >>>>>>> For each file: >>>>>>> If not .svg: >>>>>>> For each line: >>>>>>> If doesn't contain `\bxmlns\b`: >>>>>>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: >>>>>>> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: >>>>>>> If both the HTTP and HTTPS versions >>>>>>> return 200 OK and serve the same content: >>>>>>> Replace HTTP with HTTPS. >>>>>>> >>>>>>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> >>>>>> >>>>>> Your subject lines are very odd compared to all patches for this >>>>>> subsystem, as well as all other kernel subsystems. Any reason you are >>>>>> doing it this way and not the normal and standard method of: >>>>>> USB: storage: replace http links with https >>>>>> >>>>>> That would look more uniform as well as not shout at anyone. >>> >>> I would agree. The OpenRISC patch for this series says: >>> "OPENRISC ARCHITECTURE:..." >>> >>> Here it would just be "openrisc:..." I think fixing the whole series is needed. >>> Greg is not the only on complaining. >>> >>> Ideally, I think, it would be good to have this sent out as a series i.e [PATCH 3/55] >>> rather than individual patches so this could be discussed as a whole. >> 1) To who? As right now? As right now plus Torvalds, KH, Miller, etc.? >> As right now, but all-to-all? > > Make sure you have a cover letter explaining what you expect. > > You can ask maintainers to pick up individual patches by mentioning that in the > cover letter. > > You can use `git send-email --cc-cmd` so each patch goes only to the > maintainers, for example: > > send-email --to linux-kernel@vger.kernel.org --cc-cmd scripts/get_maintainers.pl` > >> 2) Apropos "series" and "as whole"... I stumbled over > > I stumble over "apropos". :) > >> `git log --oneline |grep -Fwe treewide` >> and am wondering: >> *Shouldn't all of these patches even begin with "treewide: "?* >> E.g.: "treewide: Replace HTTP links with HTTPS ones: GCC PLUGINS" > > As Greg said that is not what patch subjects loo like. > > - GCC PLUGINS: is not correct, remove it. > - treewide: may work, but as you want individual maintainers to pick up the patches put > a subsystem in the subject as maintainers like. No, I don't "want" to have this or that particular recipient. I'd just like to get my changes in master. You say like if I send to individual maintainers, I have to take their subject likes. OK... But if I use "treewide:" – who do I send to (if not to individual maintainers per patch)? > - The rest of the text should be lowercase "replace http links with https" > > Have a look at other patch subject lines based on the file you are editing. For example: > > $ git log --oneline -- Documentation/kbuild/gcc-plugins.rst > 2020-03-10 2b4cbd5c9505 Jonathan Corbet docs: move gcc-plugins to the kbuild manual > > $ git log --oneline -- scripts/Makefile.gcc-plugins > 2019-03-04 81a56f6dcd20 Kees Cook gcc-plugins: structleak: Generalize to all variable types > 2018-12-29 668c35f69cc7 Linus Torvalds Merge tag 'kbuild-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild > 2018-12-12 189af4657186 Ard Biesheuvel ARM: smp: add support for per-task stack canaries > 2018-12-01 ce2fd53a10c7 Masahiro Yamada kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile > 2018-09-04 10e9ae9fabaf Alexander Popov gcc-plugins: Add STACKLEAK plugin for tracking the kernel stack > 2018-07-24 7ccb95e8fe91 Kees Cook gcc-plugins: Regularize Makefile.gcc-plugins > 2018-07-02 c17d6179ad5a Masahiro Yamada gcc-plugins: remove unused GCC_PLUGIN_SUBDIR > 2018-06-11 59f53855babf Masahiro Yamada gcc-plugins: test plugin support in Kconfig and clean up Makefile > 2018-06-11 8034c2fb1225 Masahiro Yamada gcc-plugins: move GCC version check for PowerPC to Kconfig > 2018-06-11 5aadfdeb8de0 Masahiro Yamada kcov: test compiler capability in Kconfig and correct dependency > > > So you will have: > > docs: replace http links with https > gcc-plugins: replace http links with https > > -Stafford > >>> >>> -Stafford >>> >>>>>> thanks, >>>>>> >>>>>> greg k-h >>>>>> >>>>> Hi, >>>>> >>>>> I'm very sorry. >>>>> >>>>> As Torvalds has merged 93431e0607e5 and many of you devs (including big >>>>> maintainers like David Miller) just applied this stuff, I assumed that's OK. >>>>> >>>>> And now I've rolled out tens of patches via shell loop... *sigh* >>>>> >>>>> As this is the third (I think) change request like this, I assume this rule >>>>> applies to all subsystems – right? >>>> >>>> Yes, you should try to emulate what the subsystem does, look at other >>>> patches for the same files, but the format I suggested is almost always >>>> the correct one. If not, I'm sure maintainers will be glad to tell you >>>> otherwise :) >>> >>>
On Fri, 10 Jul 2020 21:36:03 +0200 "Alexander A. Klimov" <grandmaster@al2klimov.de> wrote: > 2) Apropos "series" and "as whole"... I stumbled over > `git log --oneline |grep -Fwe treewide` > and am wondering: > *Shouldn't all of these patches even begin with "treewide: "?* > E.g.: "treewide: Replace HTTP links with HTTPS ones: GCC PLUGINS" No, this isn't something that needs to be done across the tree all at once. Keep going through the appropriate maintainers as you have, but do please try to adjust your subject lines to match what they do. jon
Am 10.07.20 um 23:35 schrieb Jonathan Corbet: > On Fri, 10 Jul 2020 21:36:03 +0200 > "Alexander A. Klimov" <grandmaster@al2klimov.de> wrote: > >> 2) Apropos "series" and "as whole"... I stumbled over >> `git log --oneline |grep -Fwe treewide` >> and am wondering: >> *Shouldn't all of these patches even begin with "treewide: "?* >> E.g.: "treewide: Replace HTTP links with HTTPS ones: GCC PLUGINS" > > No, this isn't something that needs to be done across the tree all at > once. Keep going through the appropriate maintainers as you have, but do If we do treewide only if needed... why is this treewide: git log --oneline |grep -Fwe 'treewide: Replace GPLv2 boilerplate/reference with SPDX' > please try to adjust your subject lines to match what they do. > > jon >
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig index 5335a7ff5d14..d17b60a644ef 100644 --- a/drivers/usb/storage/Kconfig +++ b/drivers/usb/storage/Kconfig @@ -57,7 +57,7 @@ config USB_STORAGE_FREECOM tristate "Freecom USB/ATAPI Bridge support" help Support for the Freecom USB to IDE/ATAPI adaptor. - Freecom has a web page at <http://www.freecom.de/>. + Freecom has a web page at <https://www.freecom.de/>. If this driver is compiled as a module, it will be named ums-freecom. diff --git a/drivers/usb/storage/freecom.c b/drivers/usb/storage/freecom.c index 34e7eaff1174..3d5f7d0ff0f1 100644 --- a/drivers/usb/storage/freecom.c +++ b/drivers/usb/storage/freecom.c @@ -11,7 +11,7 @@ * * This driver was developed with information provided in FREECOM's USB * Programmers Reference Guide. For further information contact Freecom - * (http://www.freecom.de/) + * (https://www.freecom.de/) */ #include <linux/module.h> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index b6a9a7451620..220ae2c356ee 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h @@ -44,7 +44,7 @@ * mode. Existing userspace solutions are superior. * * New mode switching devices should instead be added to the database - * maintained at http://www.draisberghof.de/usb_modeswitch/ + * maintained at https://www.draisberghof.de/usb_modeswitch/ */ #if !defined(CONFIG_USB_STORAGE_SDDR09) && \
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master (Actually letting a shell for loop submit all this stuff for me.) If there are any URLs to be removed completely or at least not HTTPSified: Just clearly say so and I'll *undo my change*. See also: https://lkml.org/lkml/2020/6/27/64 If there are any valid, but yet not changed URLs: See: https://lkml.org/lkml/2020/6/26/837 If you apply the patch, please let me know. drivers/usb/storage/Kconfig | 2 +- drivers/usb/storage/freecom.c | 2 +- drivers/usb/storage/unusual_devs.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)