| Message ID | 380c0494-ed02-b2be-65b0-d385627fb894@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Tue, Jun 2, 2020 at 1:52 PM Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > Since we lack the hardware (or proper emulator setup) for > testing needed changes add FIXMEs to document the issues > (so at least they are not forgotten). > > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:52 PM Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: >> Since we lack the hardware (or proper emulator setup) for >> testing needed changes add FIXMEs to document the issues >> (so at least they are not forgotten). >> >> Cc: Al Viro <viro@zeniv.linux.org.uk> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied to drm-misc-next tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
Index: b/drivers/video/fbdev/amifb.c =================================================================== --- a/drivers/video/fbdev/amifb.c +++ b/drivers/video/fbdev/amifb.c @@ -1892,6 +1892,7 @@ static int ami_get_var_cursorinfo(struct | ((datawords >> 15) & 1)); datawords <<= 1; #endif + /* FIXME: check the return value + test the change */ put_user(color, data++); } if (bits > 0) { @@ -1962,6 +1963,7 @@ static int ami_set_var_cursorinfo(struct bits = 16; words = delta; datawords = 0; for (width = (short)var->width - 1; width >= 0; width--) { unsigned long tdata = 0; + /* FIXME: check the return value + test the change */ get_user(tdata, data); data++; #ifdef __mc68000__
Since we lack the hardware (or proper emulator setup) for testing needed changes add FIXMEs to document the issues (so at least they are not forgotten). Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- v2: - rebased on top of updated patch #1/2 drivers/video/fbdev/amifb.c | 2 ++ 1 file changed, 2 insertions(+)