| Message ID | 20200710154935.697190-2-philippe.schenker@toradex.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 20-07-10 17:49:33, Philippe Schenker wrote: > Chipidea depends on some hardware signals to be there in order > for runtime-pm to work well. Add the possibility to disable runtime > power management that is necessary for certain boards. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > --- > > drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c > index 5ae16368a0c7..5078d0695eb7 100644 > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > @@ -434,6 +434,9 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) > usb_phy_init(pdata.usb_phy); > } > > + if (of_property_read_bool(np, "disable-runtime-pm")) > + pdata.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM; > + > if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM) > data->supports_runtime_pm = true; > The changes are OK, you may add some descriptions like Fabio suggested, eg, your use cases.
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 5ae16368a0c7..5078d0695eb7 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -434,6 +434,9 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) usb_phy_init(pdata.usb_phy); } + if (of_property_read_bool(np, "disable-runtime-pm")) + pdata.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM; + if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM) data->supports_runtime_pm = true;
Chipidea depends on some hardware signals to be there in order for runtime-pm to work well. Add the possibility to disable runtime power management that is necessary for certain boards. Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++ 1 file changed, 3 insertions(+)