| Message ID | 87v9iq6x9x.fsf@x220.int.ebiederm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Implementing kernel_execve | expand |
On Tue, Jul 14, 2020 at 08:28:42AM -0500, Eric W. Biederman wrote: > > The general convention in the linux kernel is to define a pointer > member as "type *name". The declaration of struct linux_binprm has > several pointer defined as "type * name". Update them to the > form of "type *name" for consistency. > > Suggested-by: Kees Cook <keescook@chromium.org> > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Reviewed-by: Kees Cook <keescook@chromium.org>
On Tue, Jul 14, 2020 at 08:28:42AM -0500, Eric W. Biederman wrote: > > The general convention in the linux kernel is to define a pointer > member as "type *name". The declaration of struct linux_binprm has > several pointer defined as "type * name". Update them to the > form of "type *name" for consistency. > > Suggested-by: Kees Cook <keescook@chromium.org> > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h index 7c27d7b57871..eb5cb8df5485 100644 --- a/include/linux/binfmts.h +++ b/include/linux/binfmts.h @@ -45,15 +45,15 @@ struct linux_binprm { #ifdef __alpha__ unsigned int taso:1; #endif - struct file * executable; /* Executable to pass to the interpreter */ - struct file * interpreter; - struct file * file; + struct file *executable; /* Executable to pass to the interpreter */ + struct file *interpreter; + struct file *file; struct cred *cred; /* new credentials */ int unsafe; /* how unsafe this exec is (mask of LSM_UNSAFE_*) */ unsigned int per_clear; /* bits to clear in current->personality */ int argc, envc; - const char * filename; /* Name of binary as seen by procps */ - const char * interp; /* Name of the binary really executed. Most + const char *filename; /* Name of binary as seen by procps */ + const char *interp; /* Name of the binary really executed. Most of the time same as filename, but could be different for binfmt_{misc,script} */ unsigned interp_flags;
The general convention in the linux kernel is to define a pointer member as "type *name". The declaration of struct linux_binprm has several pointer defined as "type * name". Update them to the form of "type *name" for consistency. Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> --- include/linux/binfmts.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)