mbox series

[v2,0/5] dmaengine: ti: k3-udma: cleanups for 5.8

Message ID 20200707102352.28773-1-peter.ujfalusi@ti.com (mailing list archive)
Headers show
Series dmaengine: ti: k3-udma: cleanups for 5.8 | expand

Message

Peter Ujfalusi July 7, 2020, 10:23 a.m. UTC
Hi Vinod,

Changes since v1:
- drop the check against NULL for uc in the IO functions as pointed out by
  Grygorii

Tested on top of linux-next, but they apply (with offsets) on top of
dmaengine/next.

Few patches to clean up the code mostly with the exception of removing the use
of ring_get_occ() from udma_pop_from_ring().

This series should not conflict with Grygorii's ringacc update patch, they touch
the code in different areas.

Regards,
Peter
---
Peter Ujfalusi (5):
  dmaengine: ti: k3-udma: Remove dma_sync_single calls for descriptors
  dmaengine: ti: k3-udma: Do not use ring_get_occ in udma_pop_from_ring
  dmaengine: ti: k3-udma: Use common defines for TCHANRT/RCHANRT
    registers
  dmaengine: ti: k3-udma-private: Use udma_read/write for register
    access
  dmaengine: ti: k3-udma: Use udma_chan instead of tchan/rchan for IO
    functions

 drivers/dma/ti/k3-udma-glue.c    |  79 +++++------
 drivers/dma/ti/k3-udma-private.c |   8 +-
 drivers/dma/ti/k3-udma.c         | 236 +++++++++++++------------------
 drivers/dma/ti/k3-udma.h         |  61 +++-----
 4 files changed, 161 insertions(+), 223 deletions(-)

Comments

Grygorii Strashko July 7, 2020, 12:57 p.m. UTC | #1
On 07/07/2020 13:23, Peter Ujfalusi wrote:
> Hi Vinod,
> 
> Changes since v1:
> - drop the check against NULL for uc in the IO functions as pointed out by
>    Grygorii
> 
> Tested on top of linux-next, but they apply (with offsets) on top of
> dmaengine/next.
> 
> Few patches to clean up the code mostly with the exception of removing the use
> of ring_get_occ() from udma_pop_from_ring().
> 
> This series should not conflict with Grygorii's ringacc update patch, they touch
> the code in different areas.
> 
> Regards,
> Peter
> ---
> Peter Ujfalusi (5):
>    dmaengine: ti: k3-udma: Remove dma_sync_single calls for descriptors
>    dmaengine: ti: k3-udma: Do not use ring_get_occ in udma_pop_from_ring
>    dmaengine: ti: k3-udma: Use common defines for TCHANRT/RCHANRT
>      registers
>    dmaengine: ti: k3-udma-private: Use udma_read/write for register
>      access
>    dmaengine: ti: k3-udma: Use udma_chan instead of tchan/rchan for IO
>      functions
> 
>   drivers/dma/ti/k3-udma-glue.c    |  79 +++++------
>   drivers/dma/ti/k3-udma-private.c |   8 +-
>   drivers/dma/ti/k3-udma.c         | 236 +++++++++++++------------------
>   drivers/dma/ti/k3-udma.h         |  61 +++-----
>   4 files changed, 161 insertions(+), 223 deletions(-)
> 

Thank you
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Vinod Koul July 15, 2020, 6:07 a.m. UTC | #2
On 07-07-20, 13:23, Peter Ujfalusi wrote:
> Hi Vinod,
> 
> Changes since v1:
> - drop the check against NULL for uc in the IO functions as pointed out by
>   Grygorii

Applied all, thanks