mbox series

[0/8] Various cleanups

Message ID 20200715095217.441885-1-damien.lemoal@wdc.com (mailing list archive)
Headers show
Series Various cleanups | expand

Message

Damien Le Moal July 15, 2020, 9:52 a.m. UTC 
Mike,

These patches fix various compilation warnings showing up when compiling
with W=1. The last patch addresses a static checker warning (C=1
compilation). There are a lot more of these code checker warnings
remaining that probably could be addressed, some seem to be false
positive though.

Damien Le Moal (8):
  dm raid5: Remove set but unused variable
  dm raid5: Fix compilation warning
  md: Fix compilation warning
  dm raid10: Fix compilation warning
  dm verity: Fix compilation warning
  dm raid: Remove empty if statement
  dm ioctl: Fix compilation warning
  dm init: Set file local variable static

 drivers/md/dm-init.c              |  2 +-
 drivers/md/dm-ioctl.c             |  2 +-
 drivers/md/dm-raid.c              |  2 --
 drivers/md/dm-verity-verify-sig.h | 14 +++++++-------
 drivers/md/md.c                   | 12 ++++++------
 drivers/md/raid10.c               |  4 ++--
 drivers/md/raid5-cache.c          |  4 +---
 drivers/md/raid5.c                | 12 ++++++------
 8 files changed, 24 insertions(+), 28 deletions(-)

Comments

Mike Snitzer July 15, 2020, 1:42 p.m. UTC | #1 
On Wed, Jul 15 2020 at  5:52am -0400,
Damien Le Moal <damien.lemoal@wdc.com> wrote:

> Mike,
> 
> These patches fix various compilation warnings showing up when compiling
> with W=1. The last patch addresses a static checker warning (C=1
> compilation). There are a lot more of these code checker warnings
> remaining that probably could be addressed, some seem to be false
> positive though.
> 
> Damien Le Moal (8):
>   dm raid5: Remove set but unused variable
>   dm raid5: Fix compilation warning
>   md: Fix compilation warning
>   dm raid10: Fix compilation warning
>   dm verity: Fix compilation warning
>   dm raid: Remove empty if statement
>   dm ioctl: Fix compilation warning
>   dm init: Set file local variable static
> 
>  drivers/md/dm-init.c              |  2 +-
>  drivers/md/dm-ioctl.c             |  2 +-
>  drivers/md/dm-raid.c              |  2 --
>  drivers/md/dm-verity-verify-sig.h | 14 +++++++-------

OK, thanks.

>  drivers/md/md.c                   | 12 ++++++------
>  drivers/md/raid10.c               |  4 ++--
>  drivers/md/raid5-cache.c          |  4 +---
>  drivers/md/raid5.c                | 12 ++++++------

But these need to be routed through the MD.

Mike

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Damien Le Moal July 15, 2020, 11:03 p.m. UTC | #2 
On 2020/07/15 22:43, Mike Snitzer wrote:
> On Wed, Jul 15 2020 at  5:52am -0400,
> Damien Le Moal <damien.lemoal@wdc.com> wrote:
> 
>> Mike,
>>
>> These patches fix various compilation warnings showing up when compiling
>> with W=1. The last patch addresses a static checker warning (C=1
>> compilation). There are a lot more of these code checker warnings
>> remaining that probably could be addressed, some seem to be false
>> positive though.
>>
>> Damien Le Moal (8):
>>   dm raid5: Remove set but unused variable
>>   dm raid5: Fix compilation warning
>>   md: Fix compilation warning
>>   dm raid10: Fix compilation warning
>>   dm verity: Fix compilation warning
>>   dm raid: Remove empty if statement
>>   dm ioctl: Fix compilation warning
>>   dm init: Set file local variable static
>>
>>  drivers/md/dm-init.c              |  2 +-
>>  drivers/md/dm-ioctl.c             |  2 +-
>>  drivers/md/dm-raid.c              |  2 --
>>  drivers/md/dm-verity-verify-sig.h | 14 +++++++-------
> 
> OK, thanks.
> 
>>  drivers/md/md.c                   | 12 ++++++------
>>  drivers/md/raid10.c               |  4 ++--
>>  drivers/md/raid5-cache.c          |  4 +---
>>  drivers/md/raid5.c                | 12 ++++++------
> 
> But these need to be routed through the MD.

Oops. Yes ! Will do. Thanks !

> 
> Mike
> 
>