| Message ID | 20200716062427.71763-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8b34a2895bb7f791ce6bebc1737373e9475c58b2 |
| Headers | show |
| Series | phy: sun4i-usb: explicitly include gpio/consumer.h | expand |
On Thu, Jul 16, 2020 at 2:24 PM Vinod Koul <vkoul@kernel.org> wrote: > > Driver uses GPIO functions but doesn't include the header explcitly. Add > that to fix build errors when GPIOLIB is disabled. > > drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit > declaration of function ‘gpiod_get_value_cansleep’; did you mean > ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration] > drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit > declaration of function ‘devm_gpiod_get_optional’; did you mean > ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration] > drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: ‘GPIOD_IN’ > undeclared (first use in this function); did you mean ‘GPIOF_IN’? > drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit > declaration of function ‘gpiod_to_irq’; did you mean ‘gpio_to_irq’? > [-Werror=implicit-function-declaration] > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> Maybe add Fixes: ba4bdc9e1dc0 ("PHY: sunxi: Add driver for sunxi usb phy") ? Though it probably doesn't apply cleanly on the oldest stable kernel due to the extcon-provider header. Either way, Acked-by: Chen-Yu Tsai <wens@csie.org>
On 7/15/20 11:24 PM, Vinod Koul wrote: > Driver uses GPIO functions but doesn't include the header explcitly. Add > that to fix build errors when GPIOLIB is disabled. > > drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit > declaration of function ‘gpiod_get_value_cansleep’; did you mean > ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration] > drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit > declaration of function ‘devm_gpiod_get_optional’; did you mean > ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration] > drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: ‘GPIOD_IN’ > undeclared (first use in this function); did you mean ‘GPIOF_IN’? > drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit > declaration of function ‘gpiod_to_irq’; did you mean ‘gpio_to_irq’? > [-Werror=implicit-function-declaration] > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > drivers/phy/allwinner/phy-sun4i-usb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c > index 7e09ad6a0b42..585d0a59e712 100644 > --- a/drivers/phy/allwinner/phy-sun4i-usb.c > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > @@ -16,6 +16,7 @@ > #include <linux/delay.h> > #include <linux/err.h> > #include <linux/extcon-provider.h> > +#include <linux/gpio/consumer.h> > #include <linux/io.h> > #include <linux/interrupt.h> > #include <linux/kernel.h> >
diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index 7e09ad6a0b42..585d0a59e712 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -16,6 +16,7 @@ #include <linux/delay.h> #include <linux/err.h> #include <linux/extcon-provider.h> +#include <linux/gpio/consumer.h> #include <linux/io.h> #include <linux/interrupt.h> #include <linux/kernel.h>
Driver uses GPIO functions but doesn't include the header explcitly. Add that to fix build errors when GPIOLIB is disabled. drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit declaration of function ‘gpiod_get_value_cansleep’; did you mean ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration] drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit declaration of function ‘devm_gpiod_get_optional’; did you mean ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration] drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: ‘GPIOD_IN’ undeclared (first use in this function); did you mean ‘GPIOF_IN’? drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit declaration of function ‘gpiod_to_irq’; did you mean ‘gpio_to_irq’? [-Werror=implicit-function-declaration] Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/phy/allwinner/phy-sun4i-usb.c | 1 + 1 file changed, 1 insertion(+)