| Message ID | 20200716144927.7193-1-nsaenzjulienne@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/v3d: Use platform_get_irq_optional() to get optional IRQs | expand |
On Thu, Jul 16, 2020 at 7:51 AM Nicolas Saenz Julienne <nsaenzjulienne@suse.de> wrote: > > Aside from being more correct, the non optional version of the function > prints an error when failing to find the IRQ. > > Fixes: eea9b97b4504 ("drm/v3d: Add support for V3D v4.2") > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > --- > drivers/gpu/drm/v3d/v3d_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/v3d/v3d_irq.c b/drivers/gpu/drm/v3d/v3d_irq.c > index c88686489b88..0be2eb7876be 100644 > --- a/drivers/gpu/drm/v3d/v3d_irq.c > +++ b/drivers/gpu/drm/v3d/v3d_irq.c > @@ -217,7 +217,7 @@ v3d_irq_init(struct v3d_dev *v3d) > V3D_CORE_WRITE(core, V3D_CTL_INT_CLR, V3D_CORE_IRQS); > V3D_WRITE(V3D_HUB_INT_CLR, V3D_HUB_IRQS); > > - irq1 = platform_get_irq(v3d_to_pdev(v3d), 1); > + irq1 = platform_get_irq_optional(v3d_to_pdev(v3d), 1); > if (irq1 == -EPROBE_DEFER) > return irq1; > if (irq1 > 0) { > -- Reviewed-by: Eric Anholt <eric@anholt.net>
diff --git a/drivers/gpu/drm/v3d/v3d_irq.c b/drivers/gpu/drm/v3d/v3d_irq.c index c88686489b88..0be2eb7876be 100644 --- a/drivers/gpu/drm/v3d/v3d_irq.c +++ b/drivers/gpu/drm/v3d/v3d_irq.c @@ -217,7 +217,7 @@ v3d_irq_init(struct v3d_dev *v3d) V3D_CORE_WRITE(core, V3D_CTL_INT_CLR, V3D_CORE_IRQS); V3D_WRITE(V3D_HUB_INT_CLR, V3D_HUB_IRQS); - irq1 = platform_get_irq(v3d_to_pdev(v3d), 1); + irq1 = platform_get_irq_optional(v3d_to_pdev(v3d), 1); if (irq1 == -EPROBE_DEFER) return irq1; if (irq1 > 0) {
Aside from being more correct, the non optional version of the function prints an error when failing to find the IRQ. Fixes: eea9b97b4504 ("drm/v3d: Add support for V3D v4.2") Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/gpu/drm/v3d/v3d_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)