| Message ID | 20200718103344.3407-1-grandmaster@al2klimov.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 238b5bdefdf9767f5de8574ed79ead397eccf05e |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: udraw-ps3: Replace HTTP links with HTTPS ones | expand |
On Sat, 2020-07-18 at 12:33 +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > If both the HTTP and HTTPS versions > return 200 OK and serve the same content: > Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> Looks good! Acked-by: Bastien Nocera <hadess@hadess.net>
On Sat, 18 Jul 2020, Bastien Nocera wrote: > > Rationale: > > Reduces attack surface on kernel devs opening the links for MITM > > as HTTPS traffic is much harder to manipulate. > > > > Deterministic algorithm: > > For each file: > > If not .svg: > > For each line: > > If doesn't contain `\bxmlns\b`: > > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > > If both the HTTP and HTTPS versions > > return 200 OK and serve the same content: > > Replace HTTP with HTTPS. > > > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > > Looks good! > > Acked-by: Bastien Nocera <hadess@hadess.net> Applied, thanks.
diff --git a/drivers/hid/hid-udraw-ps3.c b/drivers/hid/hid-udraw-ps3.c index b0fbd11aa0fc..b2e17ef2ea27 100644 --- a/drivers/hid/hid-udraw-ps3.c +++ b/drivers/hid/hid-udraw-ps3.c @@ -16,7 +16,7 @@ MODULE_LICENSE("GPL"); /* * Protocol information from: - * http://brandonw.net/udraw/ + * https://brandonw.net/udraw/ * and the source code of: * https://vvvv.org/contribution/udraw-hid */
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: If both the HTTP and HTTPS versions return 200 OK and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master If there are any URLs to be removed completely or at least not (just) HTTPSified: Just clearly say so and I'll *undo my change*. See also: https://lkml.org/lkml/2020/6/27/64 If there are any valid, but yet not changed URLs: See: https://lkml.org/lkml/2020/6/26/837 If you apply the patch, please let me know. drivers/hid/hid-udraw-ps3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)