[0/2] Fix for write sharing on luks raw images

Message

Maxim Levitsky July 19, 2020, 12:20 p.m. UTC

A rebase gone wrong, and I ended up allowing a luks image
to be opened at the same time by two VMs without any warnings/overrides.

Fix that and also add an iotest to prevent this from happening.

Best regards,
	Maxim Levisky

Maxim Levitsky (2):
  block/crypto: disallow write sharing by default
  qemu-iotests: add testcase for bz #1857490

 block/crypto.c             |  2 +-
 tests/qemu-iotests/296     | 44 +++++++++++++++++++++++++++++++++++++-
 tests/qemu-iotests/296.out | 12 +++++++++--
 3 files changed, 54 insertions(+), 4 deletions(-)

Comments

[e-mail] July 19, 2020, 12:28 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

Max Reitz July 20, 2020, 12:37 p.m. UTC | #2

On 19.07.20 14:20, Maxim Levitsky wrote:
> A rebase gone wrong, and I ended up allowing a luks image
> to be opened at the same time by two VMs without any warnings/overrides.
> 
> Fix that and also add an iotest to prevent this from happening.
> 
> Best regards,
> 	Maxim Levisky
> 
> Maxim Levitsky (2):
>   block/crypto: disallow write sharing by default
>   qemu-iotests: add testcase for bz #1857490

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block