| Message ID | 20200713144930.1034632-8-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | None | expand |
Am Montag, 13. Juli 2020, 16:49:12 CEST schrieb Lee Jones: > Kerneldoc struct titles must be followed by whitespace. Also attributes > need to be in the format '@.*: ' else the checker gets confused. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data ' > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > index 9bd0a3de101dd..5e24838a582f5 100644 > --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > @@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = { > } > > /** > - * struct s3c24xx_eint_data: EINT common data > + * struct s3c24xx_eint_data - EINT common data > * @drvdata: pin controller driver data > * @domains: IRQ domains of particular EINT interrupts > * @parents: mapped parent irqs in the main interrupt controller > @@ -92,10 +92,10 @@ struct s3c24xx_eint_data { > }; > > /** > - * struct s3c24xx_eint_domain_data: per irq-domain data > + * struct s3c24xx_eint_domain_data - per irq-domain data > * @bank: pin bank related to the domain > * @eint_data: common data > - * eint0_3_parent_only: live eints 0-3 only in the main intc > + * @eint0_3_parent_only: live eints 0-3 only in the main intc > */ > struct s3c24xx_eint_domain_data { > struct samsung_pin_bank *bank; >
On Mon, Jul 13, 2020 at 03:49:12PM +0100, Lee Jones wrote: > Kerneldoc struct titles must be followed by whitespace. Also attributes > need to be in the format '@.*: ' else the checker gets confused. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data ' > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- Thanks, applied. Best regards, Krzysztof
On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote: > On Mon, Jul 13, 2020 at 03:49:12PM +0100, Lee Jones wrote: > > Kerneldoc struct titles must be followed by whitespace. Also attributes > > need to be in the format '@.*: ' else the checker gets confused. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data ' > > > > Cc: Kukjin Kim <kgene@kernel.org> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > > Cc: Heiko Stuebner <heiko@sntech.de> > > Cc: linux-samsung-soc@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- > > Thanks, applied. This has already been applied and resides in -next.
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c index 9bd0a3de101dd..5e24838a582f5 100644 --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c @@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = { } /** - * struct s3c24xx_eint_data: EINT common data + * struct s3c24xx_eint_data - EINT common data * @drvdata: pin controller driver data * @domains: IRQ domains of particular EINT interrupts * @parents: mapped parent irqs in the main interrupt controller @@ -92,10 +92,10 @@ struct s3c24xx_eint_data { }; /** - * struct s3c24xx_eint_domain_data: per irq-domain data + * struct s3c24xx_eint_domain_data - per irq-domain data * @bank: pin bank related to the domain * @eint_data: common data - * eint0_3_parent_only: live eints 0-3 only in the main intc + * @eint0_3_parent_only: live eints 0-3 only in the main intc */ struct s3c24xx_eint_domain_data { struct samsung_pin_bank *bank;
Kerneldoc struct titles must be followed by whitespace. Also attributes need to be in the format '@.*: ' else the checker gets confused. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data ' Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Tomasz Figa <tomasz.figa@gmail.com> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Heiko Stuebner <heiko@sntech.de> Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)