| Message ID | 20200709020629.91671-4-justin.he@arm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix and enable pmem as RAM device on arm64 | expand |
On 09.07.20 04:06, Jia He wrote: > After making default memory_add_physaddr_to_nid in mm/memory_hotplug, > there is no use to define a similar one in arch specific directory. > > Signed-off-by: Jia He <justin.he@arm.com> > --- > arch/sh/mm/init.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index a70ba0fdd0b3..f75932ba87a6 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -430,15 +430,6 @@ int arch_add_memory(int nid, u64 start, u64 size, > return ret; > } > > -#ifdef CONFIG_NUMA > -int memory_add_physaddr_to_nid(u64 addr) > -{ > - /* Node 0 for now.. */ > - return 0; > -} > -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > -#endif > - > void arch_remove_memory(int nid, u64 start, u64 size, > struct vmem_altmap *altmap) > { > Reviewed-by: David Hildenbrand <david@redhat.com>
On Thu, Jul 09, 2020 at 11:10:36AM +0200, David Hildenbrand wrote: > On 09.07.20 04:06, Jia He wrote: > > After making default memory_add_physaddr_to_nid in mm/memory_hotplug, > > there is no use to define a similar one in arch specific directory. > > > > Signed-off-by: Jia He <justin.he@arm.com> > > --- > > arch/sh/mm/init.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index a70ba0fdd0b3..f75932ba87a6 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -430,15 +430,6 @@ int arch_add_memory(int nid, u64 start, u64 size, > > return ret; > > } > > > > -#ifdef CONFIG_NUMA > > -int memory_add_physaddr_to_nid(u64 addr) > > -{ > > - /* Node 0 for now.. */ > > - return 0; > > -} > > -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > > -#endif > > - > > void arch_remove_memory(int nid, u64 start, u64 size, > > struct vmem_altmap *altmap) > > { > > > > Reviewed-by: David Hildenbrand <david@redhat.com> Acked-by: Rich Felker <dalias@libc.org>
> After making default memory_add_physaddr_to_nid in mm/memory_hotplug, > there is no use to define a similar one in arch specific directory. > > Signed-off-by: Jia He <justin.he@arm.com> > --- > arch/sh/mm/init.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index a70ba0fdd0b3..f75932ba87a6 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -430,15 +430,6 @@ int arch_add_memory(int nid, u64 start, u64 size, > return ret; > } > > -#ifdef CONFIG_NUMA > -int memory_add_physaddr_to_nid(u64 addr) > -{ > - /* Node 0 for now.. */ > - return 0; > -} > -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > -#endif > - > void arch_remove_memory(int nid, u64 start, u64 size, > struct vmem_altmap *altmap) > { Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c index a70ba0fdd0b3..f75932ba87a6 100644 --- a/arch/sh/mm/init.c +++ b/arch/sh/mm/init.c @@ -430,15 +430,6 @@ int arch_add_memory(int nid, u64 start, u64 size, return ret; } -#ifdef CONFIG_NUMA -int memory_add_physaddr_to_nid(u64 addr) -{ - /* Node 0 for now.. */ - return 0; -} -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); -#endif - void arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap) {
After making default memory_add_physaddr_to_nid in mm/memory_hotplug, there is no use to define a similar one in arch specific directory. Signed-off-by: Jia He <justin.he@arm.com> --- arch/sh/mm/init.c | 9 --------- 1 file changed, 9 deletions(-)