mbox series

[v6,0/3] ufs: exynos: introduce the way to get cmd info

Message ID cover.1594798514.git.kwmad.kim@samsung.com (mailing list archive)
Headers show
Series ufs: exynos: introduce the way to get cmd info | expand

Message

Kiwoong Kim July 15, 2020, 7:39 a.m. UTC
v5 -> v6
replace put_aligned with get_unaligned_be32 to set lba and sct
fix null pointer access symptom

v4 -> v5
Rebased on Stanley's patch (scsi: ufs: Fix and simplify ..
Change cmd history print order
rename config to SCSI_UFS_EXYNOS_DBG
feature functions in ufs-exynos-dbg.c by SCSI_UFS_EXYNOS_DBG

v3 -> v4
seperate respective implementations of the callbacks
change the location of compl_xfer_req related stuffs
fix null pointer access

v2 -> v3
fix build errors

v1 -> v2
change callbacks
allocate memory for ufs_s_dbg_mgr dynamically, not static way

Kiwoong Kim (3):
  ufs: introduce a callback to get info of command completion
  ufs: exynos: introduce command history
  ufs: exynos: implement dbg_register_dump

 drivers/scsi/ufs/Kconfig          |  14 +++
 drivers/scsi/ufs/Makefile         |   1 +
 drivers/scsi/ufs/ufs-exynos-dbg.c | 198 ++++++++++++++++++++++++++++++++++++++
 drivers/scsi/ufs/ufs-exynos-if.h  |  17 ++++
 drivers/scsi/ufs/ufs-exynos.c     |  38 ++++++++
 drivers/scsi/ufs/ufs-exynos.h     |  35 +++++++
 drivers/scsi/ufs/ufshcd.c         |   1 +
 drivers/scsi/ufs/ufshcd.h         |   8 ++
 8 files changed, 312 insertions(+)
 create mode 100644 drivers/scsi/ufs/ufs-exynos-dbg.c
 create mode 100644 drivers/scsi/ufs/ufs-exynos-if.h

Comments

Alim Akhtar July 15, 2020, 6:25 p.m. UTC | #1
Hi Kiwoong,

> -----Original Message-----
> From: Kiwoong Kim <kwmad.kim@samsung.com>
> Sent: 15 July 2020 13:10
> To: linux-scsi@vger.kernel.org; alim.akhtar@samsung.com;
> avri.altman@wdc.com; jejb@linux.ibm.com; martin.petersen@oracle.com;
> beanhuo@micron.com; asutoshd@codeaurora.org; cang@codeaurora.org;
> bvanassche@acm.org; grant.jung@samsung.com; sc.suh@samsung.com;
> hy50.seo@samsung.com; sh425.lee@samsung.com
> Cc: Kiwoong Kim <kwmad.kim@samsung.com>
> Subject: [PATCH v6 0/3] ufs: exynos: introduce the way to get cmd info
> 
> v5 -> v6
> replace put_aligned with get_unaligned_be32 to set lba and sct fix null pointer
> access symptom
> 
> v4 -> v5
> Rebased on Stanley's patch (scsi: ufs: Fix and simplify ..
> Change cmd history print order
> rename config to SCSI_UFS_EXYNOS_DBG
> feature functions in ufs-exynos-dbg.c by SCSI_UFS_EXYNOS_DBG
> 
> v3 -> v4
> seperate respective implementations of the callbacks change the location of
> compl_xfer_req related stuffs fix null pointer access
> 
> v2 -> v3
> fix build errors
> 
> v1 -> v2
> change callbacks
> allocate memory for ufs_s_dbg_mgr dynamically, not static way
> 
> Kiwoong Kim (3):
>   ufs: introduce a callback to get info of command completion
>   ufs: exynos: introduce command history
>   ufs: exynos: implement dbg_register_dump
> 
>  drivers/scsi/ufs/Kconfig          |  14 +++
>  drivers/scsi/ufs/Makefile         |   1 +
>  drivers/scsi/ufs/ufs-exynos-dbg.c | 198
> ++++++++++++++++++++++++++++++++++++++
>  drivers/scsi/ufs/ufs-exynos-if.h  |  17 ++++
>  drivers/scsi/ufs/ufs-exynos.c     |  38 ++++++++
>  drivers/scsi/ufs/ufs-exynos.h     |  35 +++++++
>  drivers/scsi/ufs/ufshcd.c         |   1 +
>  drivers/scsi/ufs/ufshcd.h         |   8 ++
>  8 files changed, 312 insertions(+)
>  create mode 100644 drivers/scsi/ufs/ufs-exynos-dbg.c  create mode 100644
> drivers/scsi/ufs/ufs-exynos-if.h
> 
This series looks good to me.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Thanks,
> --
> 2.7.4
Martin K. Petersen July 21, 2020, 3:42 a.m. UTC | #2
On Wed, 15 Jul 2020 16:39:54 +0900, Kiwoong Kim wrote:

> v5 -> v6
> replace put_aligned with get_unaligned_be32 to set lba and sct
> fix null pointer access symptom
> 
> v4 -> v5
> Rebased on Stanley's patch (scsi: ufs: Fix and simplify ..
> Change cmd history print order
> rename config to SCSI_UFS_EXYNOS_DBG
> feature functions in ufs-exynos-dbg.c by SCSI_UFS_EXYNOS_DBG
> 
> [...]

Applied to 5.9/scsi-queue, thanks!

[1/3] scsi: ufs: Introduce callback to capture command completion information
      https://git.kernel.org/mkp/scsi/c/679d4ca6c93f
[2/3] scsi: ufs: exynos: Introduce command history
      https://git.kernel.org/mkp/scsi/c/c3b5e96ef515
[3/3] scsi: ufs: exynos: Implement dbg_register_dump
      https://git.kernel.org/mkp/scsi/c/957ee40d413b
Greg KH Aug. 8, 2020, 11:16 a.m. UTC | #3
On Mon, Jul 20, 2020 at 11:42:07PM -0400, Martin K. Petersen wrote:
> On Wed, 15 Jul 2020 16:39:54 +0900, Kiwoong Kim wrote:
> 
> > v5 -> v6
> > replace put_aligned with get_unaligned_be32 to set lba and sct
> > fix null pointer access symptom
> > 
> > v4 -> v5
> > Rebased on Stanley's patch (scsi: ufs: Fix and simplify ..
> > Change cmd history print order
> > rename config to SCSI_UFS_EXYNOS_DBG
> > feature functions in ufs-exynos-dbg.c by SCSI_UFS_EXYNOS_DBG
> > 
> > [...]
> 
> Applied to 5.9/scsi-queue, thanks!
> 
> [1/3] scsi: ufs: Introduce callback to capture command completion information
>       https://git.kernel.org/mkp/scsi/c/679d4ca6c93f
> [2/3] scsi: ufs: exynos: Introduce command history
>       https://git.kernel.org/mkp/scsi/c/c3b5e96ef515
> [3/3] scsi: ufs: exynos: Implement dbg_register_dump
>       https://git.kernel.org/mkp/scsi/c/957ee40d413b

These links no longer work, did the patches get dropped from your tree
or rebased or something else?

thanks,

greg k-h