mbox series

[PULL] gvt-next

Message ID 20200720080541.GT27035@zhen-hp.sh.intel.com (mailing list archive)
State New, archived
Headers show
Series [PULL] gvt-next | expand

Pull-request

https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20

Message

Zhenyu Wang July 20, 2020, 8:05 a.m. UTC 
Hi,

Sorry that this might be a bit late as last week our QA people were
busy on something else..So this is gvt changes queued for 5.9 which is
to improve guest suspend/resume with proper PCI PM state tracking for
resource handling, e.g ppgtt. Hopefully this could still be in queue
for 5.9.

Thanks
--
The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:

  drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)

are available in the Git repository at:

  https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20

for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:

  drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)

----------------------------------------------------------------
gvt-next-2020-07-20

- Improve guest suspend/resume handling (Colin)

----------------------------------------------------------------
Colin Xu (3):
      drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
      drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
      drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.

 drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
 drivers/gpu/drm/i915/gvt/gtt.c       | 20 +-------------------
 drivers/gpu/drm/i915/gvt/gtt.h       |  3 ++-
 drivers/gpu/drm/i915/gvt/gvt.h       |  3 +++
 drivers/gpu/drm/i915/gvt/vgpu.c      | 20 +++++++++++++++++---
 5 files changed, 47 insertions(+), 23 deletions(-)
--

Comments

Joonas Lahtinen July 21, 2020, 11:04 a.m. UTC | #1 
Quoting Zhenyu Wang (2020-07-20 11:05:41)
> 
> Hi,
> 
> Sorry that this might be a bit late as last week our QA people were
> busy on something else..So this is gvt changes queued for 5.9 which is
> to improve guest suspend/resume with proper PCI PM state tracking for
> resource handling, e.g ppgtt. Hopefully this could still be in queue
> for 5.9.

Is this a regression fix to a problem introduced by previous
gvt-next PR targeting 5.9?

Or is it an incremental improvement over 5.8?

Regards, Joonas

> 
> Thanks
> --
> The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:
> 
>   drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20
> 
> for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:
> 
>   drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)
> 
> ----------------------------------------------------------------
> gvt-next-2020-07-20
> 
> - Improve guest suspend/resume handling (Colin)
> 
> ----------------------------------------------------------------
> Colin Xu (3):
>       drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
>       drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
>       drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.
> 
>  drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
>  drivers/gpu/drm/i915/gvt/gtt.c       | 20 +-------------------
>  drivers/gpu/drm/i915/gvt/gtt.h       |  3 ++-
>  drivers/gpu/drm/i915/gvt/gvt.h       |  3 +++
>  drivers/gpu/drm/i915/gvt/vgpu.c      | 20 +++++++++++++++++---
>  5 files changed, 47 insertions(+), 23 deletions(-)
> --
Zhenyu Wang July 22, 2020, 12:42 a.m. UTC | #2 
On 2020.07.21 14:04:41 +0300, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2020-07-20 11:05:41)
> > 
> > Hi,
> > 
> > Sorry that this might be a bit late as last week our QA people were
> > busy on something else..So this is gvt changes queued for 5.9 which is
> > to improve guest suspend/resume with proper PCI PM state tracking for
> > resource handling, e.g ppgtt. Hopefully this could still be in queue
> > for 5.9.
> 
> Is this a regression fix to a problem introduced by previous
> gvt-next PR targeting 5.9?
> 
> Or is it an incremental improvement over 5.8?
>

Second case. This is incremental improvement. Guest suspend/resume
did work somehow before but has bad performance and possible failure
with some guest versions.

Thanks

> 
> > 
> > Thanks
> > --
> > The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:
> > 
> >   drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)
> > 
> > are available in the Git repository at:
> > 
> >   https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20
> > 
> > for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:
> > 
> >   drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)
> > 
> > ----------------------------------------------------------------
> > gvt-next-2020-07-20
> > 
> > - Improve guest suspend/resume handling (Colin)
> > 
> > ----------------------------------------------------------------
> > Colin Xu (3):
> >       drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
> >       drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
> >       drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.
> > 
> >  drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
> >  drivers/gpu/drm/i915/gvt/gtt.c       | 20 +-------------------
> >  drivers/gpu/drm/i915/gvt/gtt.h       |  3 ++-
> >  drivers/gpu/drm/i915/gvt/gvt.h       |  3 +++
> >  drivers/gpu/drm/i915/gvt/vgpu.c      | 20 +++++++++++++++++---
> >  5 files changed, 47 insertions(+), 23 deletions(-)
> > --
Rodrigo Vivi July 27, 2020, 4:39 p.m. UTC | #3 
> On Jul 21, 2020, at 5:42 PM, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> 
> On 2020.07.21 14:04:41 +0300, Joonas Lahtinen wrote:
>> Quoting Zhenyu Wang (2020-07-20 11:05:41)
>>> 
>>> Hi,
>>> 
>>> Sorry that this might be a bit late as last week our QA people were
>>> busy on something else..So this is gvt changes queued for 5.9 which is
>>> to improve guest suspend/resume with proper PCI PM state tracking for
>>> resource handling, e.g ppgtt. Hopefully this could still be in queue
>>> for 5.9.
>> 
>> Is this a regression fix to a problem introduced by previous
>> gvt-next PR targeting 5.9?
>> 
>> Or is it an incremental improvement over 5.8?
>> 
> 
> Second case. This is incremental improvement. Guest suspend/resume
> did work somehow before but has bad performance and possible failure
> with some guest versions.

I'm afraid Jani already sent the last pull request towards 5.9.
So if there are fixes inside this pull request this should move to the -next-fixes

and the remaining improvements to another 5.10 pull request

Thanks,
Rodrigo.

> 
> Thanks
> 
>> 
>>> 
>>> Thanks
>>> --
>>> The following changes since commit d524b87f77364db096855d7eb714ffacec974ddf:
>>> 
>>>  drm/i915: Update DRIVER_DATE to 20200702 (2020-07-02 21:25:28 +0300)
>>> 
>>> are available in the Git repository at:
>>> 
>>>  https://github.com/intel/gvt-linux tags/gvt-next-2020-07-20
>>> 
>>> for you to fetch changes up to 02b5fc1527c0bb26a1012c6a806dc033f3b125a6:
>>> 
>>>  drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it. (2020-07-14 16:42:14 +0800)
>>> 
>>> ----------------------------------------------------------------
>>> gvt-next-2020-07-20
>>> 
>>> - Improve guest suspend/resume handling (Colin)
>>> 
>>> ----------------------------------------------------------------
>>> Colin Xu (3):
>>>      drm/i915/gvt: Do not destroy ppgtt_mm during vGPU D3->D0.
>>>      drm/i915/gvt: Do not reset pv_notified when vGPU transit from D3->D0
>>>      drm/i915/gvt: Remove intel_vgpu_reset_gtt() since no one use it.
>>> 
>>> drivers/gpu/drm/i915/gvt/cfg_space.c | 24 ++++++++++++++++++++++++
>>> drivers/gpu/drm/i915/gvt/gtt.c       | 20 +-------------------
>>> drivers/gpu/drm/i915/gvt/gtt.h       |  3 ++-
>>> drivers/gpu/drm/i915/gvt/gvt.h       |  3 +++
>>> drivers/gpu/drm/i915/gvt/vgpu.c      | 20 +++++++++++++++++---
>>> 5 files changed, 47 insertions(+), 23 deletions(-)
>>> --
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Zhenyu Wang July 28, 2020, 3:18 a.m. UTC | #4 
On 2020.07.27 16:39:58 +0000, Vivi, Rodrigo wrote:
> 
> 
> > On Jul 21, 2020, at 5:42 PM, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > 
> > On 2020.07.21 14:04:41 +0300, Joonas Lahtinen wrote:
> >> Quoting Zhenyu Wang (2020-07-20 11:05:41)
> >>> 
> >>> Hi,
> >>> 
> >>> Sorry that this might be a bit late as last week our QA people were
> >>> busy on something else..So this is gvt changes queued for 5.9 which is
> >>> to improve guest suspend/resume with proper PCI PM state tracking for
> >>> resource handling, e.g ppgtt. Hopefully this could still be in queue
> >>> for 5.9.
> >> 
> >> Is this a regression fix to a problem introduced by previous
> >> gvt-next PR targeting 5.9?
> >> 
> >> Or is it an incremental improvement over 5.8?
> >> 
> > 
> > Second case. This is incremental improvement. Guest suspend/resume
> > did work somehow before but has bad performance and possible failure
> > with some guest versions.
> 
> I'm afraid Jani already sent the last pull request towards 5.9.
> So if there are fixes inside this pull request this should move to the -next-fixes
> 
> and the remaining improvements to another 5.10 pull request
> 

Got it. I'll split out those fixes for another pull.

Thanks