| Message ID | 20200722094628.4236-2-hadess@hadess.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] USB: Fix device driver race | expand |
On Wed, Jul 22, 2020 at 11:46:28AM +0200, Bastien Nocera wrote: > Signed-off-by: Bastien Nocera <hadess@hadess.net> I can't take patches without any changelog text at all, sorry. > --- > drivers/usb/core/driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c > index a6187dd2186c..bd346e683af3 100644 > --- a/drivers/usb/core/driver.c > +++ b/drivers/usb/core/driver.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * drivers/usb/driver.c - most of the driver model stuff for usb > + * drivers/usb/core/driver.c - most of the driver model stuff for usb Just drop the whole file name, it's not needed at all. thanks, greg k-h
On Wed, 2020-07-22 at 11:51 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 22, 2020 at 11:46:28AM +0200, Bastien Nocera wrote: > > Signed-off-by: Bastien Nocera <hadess@hadess.net> > > I can't take patches without any changelog text at all, sorry. The subject line isn't clear enough? > > --- > > drivers/usb/core/driver.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c > > index a6187dd2186c..bd346e683af3 100644 > > --- a/drivers/usb/core/driver.c > > +++ b/drivers/usb/core/driver.c > > @@ -1,6 +1,6 @@ > > // SPDX-License-Identifier: GPL-2.0 > > /* > > - * drivers/usb/driver.c - most of the driver model stuff for usb > > + * drivers/usb/core/driver.c - most of the driver model stuff for > > usb > > Just drop the whole file name, it's not needed at all. And the description after or just the filename?
On Wed, Jul 22, 2020 at 11:58:54AM +0200, Bastien Nocera wrote: > On Wed, 2020-07-22 at 11:51 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 22, 2020 at 11:46:28AM +0200, Bastien Nocera wrote: > > > Signed-off-by: Bastien Nocera <hadess@hadess.net> > > > > I can't take patches without any changelog text at all, sorry. > > The subject line isn't clear enough? Maybe, maybe not, doesn't mean you shouldn't also write some text about why you did what you did. > > > --- > > > drivers/usb/core/driver.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c > > > index a6187dd2186c..bd346e683af3 100644 > > > --- a/drivers/usb/core/driver.c > > > +++ b/drivers/usb/core/driver.c > > > @@ -1,6 +1,6 @@ > > > // SPDX-License-Identifier: GPL-2.0 > > > /* > > > - * drivers/usb/driver.c - most of the driver model stuff for usb > > > + * drivers/usb/core/driver.c - most of the driver model stuff for > > > usb > > > > Just drop the whole file name, it's not needed at all. > > And the description after or just the filename? The description is fine to keep. thanks, greg k-h
On Wed, 2020-07-22 at 12:35 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 22, 2020 at 11:58:54AM +0200, Bastien Nocera wrote: > > On Wed, 2020-07-22 at 11:51 +0200, Greg Kroah-Hartman wrote: > > > On Wed, Jul 22, 2020 at 11:46:28AM +0200, Bastien Nocera wrote: > > > > Signed-off-by: Bastien Nocera <hadess@hadess.net> > > > > > > I can't take patches without any changelog text at all, sorry. > > > > The subject line isn't clear enough? > > Maybe, maybe not, doesn't mean you shouldn't also write some text > about > why you did what you did. > > > > > --- > > > > drivers/usb/core/driver.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/usb/core/driver.c > > > > b/drivers/usb/core/driver.c > > > > index a6187dd2186c..bd346e683af3 100644 > > > > --- a/drivers/usb/core/driver.c > > > > +++ b/drivers/usb/core/driver.c > > > > @@ -1,6 +1,6 @@ > > > > // SPDX-License-Identifier: GPL-2.0 > > > > /* > > > > - * drivers/usb/driver.c - most of the driver model stuff for > > > > usb > > > > + * drivers/usb/core/driver.c - most of the driver model stuff > > > > for > > > > usb > > > > > > Just drop the whole file name, it's not needed at all. > > > > And the description after or just the filename? > > The description is fine to keep. Looks like there's a lot more cleaning up that would need to be done in the tree, so feel free to drop this patch. Cheers
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index a6187dd2186c..bd346e683af3 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * drivers/usb/driver.c - most of the driver model stuff for usb + * drivers/usb/core/driver.c - most of the driver model stuff for usb * * (C) Copyright 2005 Greg Kroah-Hartman <gregkh@suse.de> *
Signed-off-by: Bastien Nocera <hadess@hadess.net> --- drivers/usb/core/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)