mbox series

[v2,0/2] Remove MT6779 UART3 clock support

Message ID 1595387397-13110-1-git-send-email-hanks.chen@mediatek.com (mailing list archive)
Headers show
Series Remove MT6779 UART3 clock support | expand

Message

Hanks Chen July 22, 2020, 3:09 a.m. UTC 
remove the redundant clk interface of uart.
CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"
-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support"
-- remove Fixes tag

Hanks Chen (2):
  dt-bindings: clock: remove UART3 clock support
  clk: mediatek: remove UART3 clock support

 drivers/clk/mediatek/clk-mt6779.c      | 2 --
 include/dt-bindings/clock/mt6779-clk.h | 1 -
 2 files changed, 3 deletions(-)

Comments

Matthias Brugger July 22, 2020, 8:43 a.m. UTC | #1 
On 22/07/2020 05:09, Hanks Chen wrote:
> remove the redundant clk interface of uart.
> CLK_INFRA_UART3 is a dummy clk interface,
> it has no effect on the operation of the read/write instruction.
> 
> Change since v2:
> Commit "dt-bindings: clock: remove UART3 clock support"

Sorry just another comment. I think we can make this one patch deleting everything.

> -- remove Fixes tag
> Commit "clk: mediatek: remove UART3 clock support"
> -- remove Fixes tag
> 
> Hanks Chen (2):
>    dt-bindings: clock: remove UART3 clock support
>    clk: mediatek: remove UART3 clock support
> 
>   drivers/clk/mediatek/clk-mt6779.c      | 2 --
>   include/dt-bindings/clock/mt6779-clk.h | 1 -
>   2 files changed, 3 deletions(-)
>
Hanks Chen July 22, 2020, 11:16 a.m. UTC | #2 
On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
> 
> On 22/07/2020 05:09, Hanks Chen wrote:
> > remove the redundant clk interface of uart.
> > CLK_INFRA_UART3 is a dummy clk interface,
> > it has no effect on the operation of the read/write instruction.
> > 
> > Change since v2:
> > Commit "dt-bindings: clock: remove UART3 clock support"
> 
> Sorry just another comment. I think we can make this one patch deleting everything.
> 
Sorry, I don't understand the comment. Do I need to merge them into one
big patch?
Btw, if I use one patch, I would get check patch fail.
---
[2020-07-22 19:12:49,046 ERROR] Run check patch results:
WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
---

Hanks

> > -- remove Fixes tag
> > Commit "clk: mediatek: remove UART3 clock support"
> > -- remove Fixes tag
> > 
> > Hanks Chen (2):
> >    dt-bindings: clock: remove UART3 clock support
> >    clk: mediatek: remove UART3 clock support
> > 
> >   drivers/clk/mediatek/clk-mt6779.c      | 2 --
> >   include/dt-bindings/clock/mt6779-clk.h | 1 -
> >   2 files changed, 3 deletions(-)
> >
Matthias Brugger July 22, 2020, 3:21 p.m. UTC | #3 
On 22/07/2020 13:16, Hanks Chen wrote:
> On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
>>
>> On 22/07/2020 05:09, Hanks Chen wrote:
>>> remove the redundant clk interface of uart.
>>> CLK_INFRA_UART3 is a dummy clk interface,
>>> it has no effect on the operation of the read/write instruction.
>>>
>>> Change since v2:
>>> Commit "dt-bindings: clock: remove UART3 clock support"
>>
>> Sorry just another comment. I think we can make this one patch deleting everything.
>>
> Sorry, I don't understand the comment. Do I need to merge them into one
> big patch?
> Btw, if I use one patch, I would get check patch fail.
> ---
> [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> separate patch. See:
> Documentation/devicetree/bindings/submitting-patches.rst
> ---

Hm, I think that's a debatable error message from checkpatch, but let's leave it 
as it is.

Regards,
Matthias


> 
> Hanks
> 
>>> -- remove Fixes tag
>>> Commit "clk: mediatek: remove UART3 clock support"
>>> -- remove Fixes tag
>>>
>>> Hanks Chen (2):
>>>     dt-bindings: clock: remove UART3 clock support
>>>     clk: mediatek: remove UART3 clock support
>>>
>>>    drivers/clk/mediatek/clk-mt6779.c      | 2 --
>>>    include/dt-bindings/clock/mt6779-clk.h | 1 -
>>>    2 files changed, 3 deletions(-)
>>>
>
Hanks Chen July 30, 2020, 1:04 p.m. UTC | #4 
Hi all,

Gentle ping on this patch.

Thanks!

Hanks Chen


On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote:
> 
> On 22/07/2020 13:16, Hanks Chen wrote:
> > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
> >>
> >> On 22/07/2020 05:09, Hanks Chen wrote:
> >>> remove the redundant clk interface of uart.
> >>> CLK_INFRA_UART3 is a dummy clk interface,
> >>> it has no effect on the operation of the read/write instruction.
> >>>
> >>> Change since v2:
> >>> Commit "dt-bindings: clock: remove UART3 clock support"
> >>
> >> Sorry just another comment. I think we can make this one patch deleting everything.
> >>
> > Sorry, I don't understand the comment. Do I need to merge them into one
> > big patch?
> > Btw, if I use one patch, I would get check patch fail.
> > ---
> > [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> > separate patch. See:
> > Documentation/devicetree/bindings/submitting-patches.rst
> > ---
> 
> Hm, I think that's a debatable error message from checkpatch, but let's leave it 
> as it is.
> 
> Regards,
> Matthias
> 
> 
> > 
> > Hanks
> > 
> >>> -- remove Fixes tag
> >>> Commit "clk: mediatek: remove UART3 clock support"
> >>> -- remove Fixes tag
> >>>
> >>> Hanks Chen (2):
> >>>     dt-bindings: clock: remove UART3 clock support
> >>>     clk: mediatek: remove UART3 clock support
> >>>
> >>>    drivers/clk/mediatek/clk-mt6779.c      | 2 --
> >>>    include/dt-bindings/clock/mt6779-clk.h | 1 -
> >>>    2 files changed, 3 deletions(-)
> >>>
> >
Hanks Chen Sept. 8, 2020, 6:31 a.m. UTC | #5 
Hi all,

Gentle ping on this patch set.

Thanks!


Hanks Chen


On Thu, 2020-07-30 at 21:04 +0800, Hanks Chen wrote:
> Hi all,
> 
> Gentle ping on this patch.
> 
> Thanks!
> 
> Hanks Chen
> 
> 
> On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote:
> > 
> > On 22/07/2020 13:16, Hanks Chen wrote:
> > > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
> > >>
> > >> On 22/07/2020 05:09, Hanks Chen wrote:
> > >>> remove the redundant clk interface of uart.
> > >>> CLK_INFRA_UART3 is a dummy clk interface,
> > >>> it has no effect on the operation of the read/write instruction.
> > >>>
> > >>> Change since v2:
> > >>> Commit "dt-bindings: clock: remove UART3 clock support"
> > >>
> > >> Sorry just another comment. I think we can make this one patch deleting everything.
> > >>
> > > Sorry, I don't understand the comment. Do I need to merge them into one
> > > big patch?
> > > Btw, if I use one patch, I would get check patch fail.
> > > ---
> > > [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> > > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> > > separate patch. See:
> > > Documentation/devicetree/bindings/submitting-patches.rst
> > > ---
> > 
> > Hm, I think that's a debatable error message from checkpatch, but let's leave it 
> > as it is.
> > 
> > Regards,
> > Matthias
> > 
> > 
> > > 
> > > Hanks
> > > 
> > >>> -- remove Fixes tag
> > >>> Commit "clk: mediatek: remove UART3 clock support"
> > >>> -- remove Fixes tag
> > >>>
> > >>> Hanks Chen (2):
> > >>>     dt-bindings: clock: remove UART3 clock support
> > >>>     clk: mediatek: remove UART3 clock support
> > >>>
> > >>>    drivers/clk/mediatek/clk-mt6779.c      | 2 --
> > >>>    include/dt-bindings/clock/mt6779-clk.h | 1 -
> > >>>    2 files changed, 3 deletions(-)
> > >>>
> > > 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hanks Chen Sept. 25, 2020, 12:43 p.m. UTC | #6 
Hi Michael & Stephen,

Gentle ping on this clk patch.

Thanks.

Regards,
Hanks


On Tue, 2020-09-08 at 14:31 +0800, Hanks Chen wrote:
> Hi all,
> 
> Gentle ping on this patch set.
> 
> Thanks!
> 
> 
> Hanks Chen
> 
> 
> On Thu, 2020-07-30 at 21:04 +0800, Hanks Chen wrote:
> > Hi all,
> > 
> > Gentle ping on this patch.
> > 
> > Thanks!
> > 
> > Hanks Chen
> > 
> > 
> > On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote:
> > > 
> > > On 22/07/2020 13:16, Hanks Chen wrote:
> > > > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
> > > >>
> > > >> On 22/07/2020 05:09, Hanks Chen wrote:
> > > >>> remove the redundant clk interface of uart.
> > > >>> CLK_INFRA_UART3 is a dummy clk interface,
> > > >>> it has no effect on the operation of the read/write instruction.
> > > >>>
> > > >>> Change since v2:
> > > >>> Commit "dt-bindings: clock: remove UART3 clock support"
> > > >>
> > > >> Sorry just another comment. I think we can make this one patch deleting everything.
> > > >>
> > > > Sorry, I don't understand the comment. Do I need to merge them into one
> > > > big patch?
> > > > Btw, if I use one patch, I would get check patch fail.
> > > > ---
> > > > [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> > > > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> > > > separate patch. See:
> > > > Documentation/devicetree/bindings/submitting-patches.rst
> > > > ---
> > > 
> > > Hm, I think that's a debatable error message from checkpatch, but let's leave it 
> > > as it is.
> > > 
> > > Regards,
> > > Matthias
> > > 
> > > 
> > > > 
> > > > Hanks
> > > > 
> > > >>> -- remove Fixes tag
> > > >>> Commit "clk: mediatek: remove UART3 clock support"
> > > >>> -- remove Fixes tag
> > > >>>
> > > >>> Hanks Chen (2):
> > > >>>     dt-bindings: clock: remove UART3 clock support
> > > >>>     clk: mediatek: remove UART3 clock support
> > > >>>
> > > >>>    drivers/clk/mediatek/clk-mt6779.c      | 2 --
> > > >>>    include/dt-bindings/clock/mt6779-clk.h | 1 -
> > > >>>    2 files changed, 3 deletions(-)
> > > >>>
> > > > 
> > 
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek