mbox series

[0/5] minor rtsx cleanups

Message ID 20200721212336.1159079-1-helgaas@kernel.org (mailing list archive)
Headers show
Series minor rtsx cleanups | expand

Message

Bjorn Helgaas July 21, 2020, 9:23 p.m. UTC
From: Bjorn Helgaas <bhelgaas@google.com>

Clean up some needlessly device-specific stuff in the Realtek card reader
drivers.

This implements some of my suggestions from
https://lore.kernel.org/r/20200720220651.GA1035857@bjorn-Precision-5520

This will conflict with Ricky's post here:
https://lore.kernel.org/r/20200706070259.32565-1-ricky_wu@realtek.com

I'll be happy to update this on top of Ricky's patch after it's applied, or
Ricky could pick up these patches and base his on top.

Bjorn Helgaas (5):
  misc: rtsx: Use pcie_capability_clear_and_set_word() for
    PCI_EXP_LNKCTL
  misc: rtsx: Remove unused pcie_cap
  misc: rtsx: Remove rtsx_pci_read/write_config() wrappers
  misc: rtsx: Find L1 PM Substates capability instead of hard-coding
  misc: rtsx: Use standard PCI definitions

 drivers/misc/cardreader/rtl8411.c  |  8 +++++---
 drivers/misc/cardreader/rts5209.c  |  5 +++--
 drivers/misc/cardreader/rts5227.c  |  5 +++--
 drivers/misc/cardreader/rts5229.c  |  5 +++--
 drivers/misc/cardreader/rts5249.c  | 28 ++++++++++++++------------
 drivers/misc/cardreader/rts5260.c  | 23 +++++++++++++--------
 drivers/misc/cardreader/rts5261.c  | 32 +++++++++++++++++++-----------
 drivers/misc/cardreader/rtsx_pcr.c |  7 ++++---
 include/linux/rtsx_pci.h           | 22 --------------------
 9 files changed, 68 insertions(+), 67 deletions(-)

Comments

Arnd Bergmann July 21, 2020, 9:28 p.m. UTC | #1
On Tue, Jul 21, 2020 at 11:23 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Clean up some needlessly device-specific stuff in the Realtek card reader
> drivers.
>
> This implements some of my suggestions from
> https://lore.kernel.org/r/20200720220651.GA1035857@bjorn-Precision-5520
>
> This will conflict with Ricky's post here:
> https://lore.kernel.org/r/20200706070259.32565-1-ricky_wu@realtek.com
>
> I'll be happy to update this on top of Ricky's patch after it's applied, or
> Ricky could pick up these patches and base his on top.


Looks all good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>
Ricky WU July 23, 2020, 8:16 a.m. UTC | #2
Hi Arnd, Bjorn,

So How can I do for now?
I need to wait Bjorn's patch applied and resubmit patch for our new chip RTS5228 base on Bjorn's patch or ?

Ricky


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Wednesday, July 22, 2020 5:29 AM
> To: Bjorn Helgaas
> Cc: 吳昊澄 Ricky; Greg Kroah-Hartman; Ulf Hansson; Rui Feng; Klaus Doth;
> Linus Walleij; Rui Miguel Silva; Puranjay Mohan; linux-kernel@vger.kernel.org;
> linux-mmc; Bjorn Helgaas
> Subject: Re: [PATCH 0/5] minor rtsx cleanups
> 
> On Tue, Jul 21, 2020 at 11:23 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Clean up some needlessly device-specific stuff in the Realtek card reader
> > drivers.
> >
> > This implements some of my suggestions from
> > https://lore.kernel.org/r/20200720220651.GA1035857@bjorn-Precision-5520
> >
> > This will conflict with Ricky's post here:
> > https://lore.kernel.org/r/20200706070259.32565-1-ricky_wu@realtek.com
> >
> > I'll be happy to update this on top of Ricky's patch after it's applied, or
> > Ricky could pick up these patches and base his on top.
> 
> 
> Looks all good to me,
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> ------Please consider the environment before printing this e-mail.
Greg Kroah-Hartman July 23, 2020, 8:28 a.m. UTC | #3
On Thu, Jul 23, 2020 at 08:16:10AM +0000, 吳昊澄 Ricky wrote:
> Hi Arnd, Bjorn,
> 
> So How can I do for now?
> I need to wait Bjorn's patch applied and resubmit patch for our new
> chip RTS5228 base on Bjorn's patch or ?

These are all now in my tree, so please feel free to resend any
outstanding patches against it.

But I think I have already applied your patch, right?

If not, please resend as I do not have anything outstanding that I can
see...

thanks,

greg k-h