| Message ID | 20200722102653.19224-3-guoqing.jiang@cloud.ionos.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Two patches for rnbd | expand |
On Wed, Jul 22, 2020 at 12:27 PM Guoqing Jiang <guoqing.jiang@cloud.ionos.com> wrote: > > Since we always set bi_end_io after call rnbd_bio_map_kern, so the > setting in rnbd_bio_map_kern is redundant. > > Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> Thanks! Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com> > --- > drivers/block/rnbd/rnbd-srv-dev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/rnbd/rnbd-srv-dev.c b/drivers/block/rnbd/rnbd-srv-dev.c > index 49c62b506c9b..b241a099aeae 100644 > --- a/drivers/block/rnbd/rnbd-srv-dev.c > +++ b/drivers/block/rnbd/rnbd-srv-dev.c > @@ -99,6 +99,5 @@ struct bio *rnbd_bio_map_kern(void *data, struct bio_set *bs, > offset = 0; > } > > - bio->bi_end_io = bio_put; > return bio; > } > -- > 2.17.1 >
On Wed, Jul 22, 2020 at 12:27 PM Guoqing Jiang <guoqing.jiang@cloud.ionos.com> wrote: > > Since we always set bi_end_io after call rnbd_bio_map_kern, so the > setting in rnbd_bio_map_kern is redundant. > > Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> Thanks! Acked-by: Danil Kipnis <danil.kipnis@cloud.ionos.com> > --- > drivers/block/rnbd/rnbd-srv-dev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/rnbd/rnbd-srv-dev.c b/drivers/block/rnbd/rnbd-srv-dev.c > index 49c62b506c9b..b241a099aeae 100644 > --- a/drivers/block/rnbd/rnbd-srv-dev.c > +++ b/drivers/block/rnbd/rnbd-srv-dev.c > @@ -99,6 +99,5 @@ struct bio *rnbd_bio_map_kern(void *data, struct bio_set *bs, > offset = 0; > } > > - bio->bi_end_io = bio_put; > return bio; > } > -- > 2.17.1 >
diff --git a/drivers/block/rnbd/rnbd-srv-dev.c b/drivers/block/rnbd/rnbd-srv-dev.c index 49c62b506c9b..b241a099aeae 100644 --- a/drivers/block/rnbd/rnbd-srv-dev.c +++ b/drivers/block/rnbd/rnbd-srv-dev.c @@ -99,6 +99,5 @@ struct bio *rnbd_bio_map_kern(void *data, struct bio_set *bs, offset = 0; } - bio->bi_end_io = bio_put; return bio; }
Since we always set bi_end_io after call rnbd_bio_map_kern, so the setting in rnbd_bio_map_kern is redundant. Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> --- drivers/block/rnbd/rnbd-srv-dev.c | 1 - 1 file changed, 1 deletion(-)