| Message ID | 20200724130903.110903-1-committed@heine.so (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [BlueZ] main: add missing comma after AlwaysPairable | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
checkpatch Failed
Outputs:
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 1880b2990866 ("core: Add AlwaysPairable to main.conf")'
#6:
Commit 1880b2990866598 added a new key to supported_options but didn't
- total: 1 errors, 0 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Your patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
diff --git a/src/main.c b/src/main.c index ec7a9fbd7..2c083de67 100644 --- a/src/main.c +++ b/src/main.c @@ -79,7 +79,7 @@ static const char *supported_options[] = { "Name", "Class", "DiscoverableTimeout", - "AlwaysPairable" + "AlwaysPairable", "PairableTimeout", "DeviceID", "ReverseServiceDiscovery",
Commit 1880b2990866598 added a new key to supported_options but didn't add a comma. This leads to the following error message on startup if the key 'PairableTimeout' is present: Unknown key PairableTimeout for group General in /etc/bluetooth/main.conf This probably also leads to ignoring the setting. Fixes: 1880b2990866598 ("core: Add AlwaysPairable to main.conf") --- src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)