| Message ID | 20200721164148.2617584-1-lee.jones@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Set 4: Next set of SCSI related W=1 warnings | expand |
On Tue, 21 Jul 2020 17:41:08 +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This brings the total of W=1 SCSI wanings from 1690 in v5.8-rc1 to 817. > > Lee Jones (40): > scsi: arcmsr: arcmsr_hba: Remove statement with no effect > scsi: aic7xxx: aic79xx_core: Remove a bunch of unused variables > scsi: aacraid: sa: Add descriptions for missing parameters > scsi: aacraid: rkt: Add missing description for 'dev' > scsi: aacraid: nark: Add missing description for 'dev' > scsi: aic94xx: aic94xx_dev: Fix a couple of kerneldoc formatting > issues > scsi: aacraid: src: Add descriptions for missing parameters > scsi: aic94xx: aic94xx_tmf: Fix kerneldoc formatting issue with 'task' > scsi: pm8001: pm8001_sas: Fix strncpy() warning > scsi: pm8001: pm8001_sas: Mover function header and supply some > missing parameter descriptions > scsi: pm8001: pm8001_ctl: Add descriptions for unused 'attr' function > parameters > scsi: qla4xxx: ql4_init: Remove set but unused variable 'func_number' > scsi: qla4xxx: ql4_init: Check return value of pci_set_mwi() > scsi: qla4xxx: ql4_83xx: Move 'qla4_83xx_reg_tbl' from shared header > scsi: aic7xxx: aic79xx_core: Remove set but unused variables > 'targ_info' and 'value' > scsi: pm8001: pm8001_hwi: Fix a bunch of kerneldoc issues > scsi: pm8001: pm80xx_hwi: Fix some function documentation issues > scsi: pm8001: pm8001_hwi: Remove a bunch of set but unused variables > scsi: qla4xxx: ql4_nx: Move 'qla4_82xx_reg_tbl' to the only place its > used > scsi: lpfc: lpfc_sli: Remove unused variable 'pg_addr' > scsi: qla4xxx: ql4_mbx: Fix-up incorrectly documented parameter > scsi: qla4xxx: ql4_iocb: Fix incorrectly named function parameter > scsi: lpfc: lpfc_sli: Fix-up around 120 documentation issues > scsi: pm8001: pm8001_hwi: Remove unused variable 'value' > scsi: pm8001: pm80xx_hwi: Staticify 'pm80xx_pci_mem_copy' and > 'mpi_set_phy_profile_req' > scsi: qla4xxx: ql4_os: Fix some kerneldoc parameter documentation > issues > scsi: qla4xxx: ql4_isr: Repair function documentation headers > scsi: lpfc: lpfc_mem: Provide description for lpfc_mem_alloc()'s > 'align' param > scsi: qla4xxx: ql4_init: Document qla4xxx_process_ddb()'s 'conn_err' > scsi: lpfc: lpfc_ct: Fix-up formatting/docrot where appropriate > scsi: csiostor: csio_init: Fix misnamed function parameter > scsi: qla4xxx: ql4_nx: Remove three set but unused variables > scsi: qla4xxx: ql4_nx: Supply description for 'code' > scsi: csiostor: csio_lnode: Demote kerneldoc that fails to meet the > criteria > scsi: bfa: bfad_bsg: Staticify all local functions > scsi: lpfc: lpfc_sli: Ensure variable has the same stipulations as > code using it > scsi: sym53c8xx_2: sym_glue: Add missing description for 'pdev' > scsi: sym53c8xx_2: sym_hipd: Ensure variable has the same stipulations > as code using it > scsi: mvsas: mv_init: Move 'core_nr' inside #ifdef and remove unused > variable 'res_flag' > scsi: cxgbi: cxgb3i: cxgb3i: Remove bad documentation and demote > kerneldoc header > > [...] Applied to 5.9/scsi-next, thanks! [01/40] scsi: arcmsr: arcmsr_hba: Remove statement with no effect https://git.kernel.org/mkp/scsi/c/7c7ef829ad08 [02/40] scsi: aic7xxx: aic79xx_core: Remove a bunch of unused variables https://git.kernel.org/mkp/scsi/c/84dc1a1d5459 [03/40] scsi: aacraid: Add descriptions for missing parameters https://git.kernel.org/mkp/scsi/c/baef36891460 [04/40] scsi: aacraid: Add missing description for 'dev' https://git.kernel.org/mkp/scsi/c/3c4538f80b09 [05/40] scsi: aacraid: Add missing description for 'dev' https://git.kernel.org/mkp/scsi/c/5d9d46b93d0a [06/40] scsi: aic94xx: Fix a couple of kerneldoc formatting issues https://git.kernel.org/mkp/scsi/c/ee37a6e6d2a1 [07/40] scsi: aacraid: Add descriptions for missing parameters https://git.kernel.org/mkp/scsi/c/a13689118f63 [08/40] scsi: aic94xx: Fix kerneldoc formatting issue with 'task' https://git.kernel.org/mkp/scsi/c/45c21cec3867 [10/40] scsi: pm8001: Move function header and supply some missing parameter descriptions https://git.kernel.org/mkp/scsi/c/a0cf5ce40d12 [11/40] scsi: pm8001: Add descriptions for unused 'attr' function parameters https://git.kernel.org/mkp/scsi/c/cd2eebfd4028 [12/40] scsi: qla4xxx: Remove set but unused variable 'func_number' https://git.kernel.org/mkp/scsi/c/4c2de9c54112 [13/40] scsi: qla4xxx: Check return value of pci_set_mwi() https://git.kernel.org/mkp/scsi/c/b854460053ec [14/40] scsi: qla4xxx: Move 'qla4_83xx_reg_tbl' from shared header https://git.kernel.org/mkp/scsi/c/3ca2c203ed99 [15/40] scsi: aic7xxx: Remove set but unused variables 'targ_info' and 'value' https://git.kernel.org/mkp/scsi/c/0683550b54c4 [16/40] scsi: pm8001: Fix a bunch of kerneldoc issues https://git.kernel.org/mkp/scsi/c/083645bab221 [17/40] scsi: pm8001: Fix some function documentation issues https://git.kernel.org/mkp/scsi/c/6ad4a51764a0 [18/40] scsi: pm8001: Remove a bunch of set but unused variables https://git.kernel.org/mkp/scsi/c/685f94794f9a [19/40] scsi: qla4xxx: Move 'qla4_82xx_reg_tbl' to the only place its used https://git.kernel.org/mkp/scsi/c/f30554c27112 [20/40] scsi: lpfc: Remove unused variable 'pg_addr' https://git.kernel.org/mkp/scsi/c/3c1311ad837e [21/40] scsi: qla4xxx: Fix-up incorrectly documented parameter https://git.kernel.org/mkp/scsi/c/0d5fea42989e [22/40] scsi: qla4xxx: Fix incorrectly named function parameter https://git.kernel.org/mkp/scsi/c/67b8b93a559f [23/40] scsi: lpfc: Fix-up around 120 documentation issues https://git.kernel.org/mkp/scsi/c/7af29d455362 [25/40] scsi: pm8001: Staticify 'pm80xx_pci_mem_copy' and 'mpi_set_phy_profile_req' https://git.kernel.org/mkp/scsi/c/ea310f574e73 [26/40] scsi: qla4xxx: Fix some kerneldoc parameter documentation issues https://git.kernel.org/mkp/scsi/c/cdeeb36d8f24 [27/40] scsi: qla4xxx: Repair function documentation headers https://git.kernel.org/mkp/scsi/c/fc5fba6e2ae2 [28/40] scsi: lpfc: Provide description for lpfc_mem_alloc()'s 'align' param https://git.kernel.org/mkp/scsi/c/c734de98a7bc [29/40] scsi: qla4xxx: Document qla4xxx_process_ddb()'s 'conn_err' https://git.kernel.org/mkp/scsi/c/c0ad04b4b6d7 [30/40] scsi: lpfc: Fix-up formatting/docrot where appropriate https://git.kernel.org/mkp/scsi/c/6265bc4a41cd [31/40] scsi: csiostor: Fix misnamed function parameter https://git.kernel.org/mkp/scsi/c/5446a91d8401 [32/40] scsi: qla4xxx: Remove three set but unused variables https://git.kernel.org/mkp/scsi/c/f67e81641db7 [33/40] scsi: qla4xxx: Supply description for 'code' https://git.kernel.org/mkp/scsi/c/653557df36e0 [34/40] scsi: csiostor: Demote kerneldoc that fails to meet the criteria https://git.kernel.org/mkp/scsi/c/fd4cdf6488d1 [35/40] scsi: bfa: Staticify all local functions https://git.kernel.org/mkp/scsi/c/3bbd8ef9f780 [36/40] scsi: lpfc: Ensure variable has the same stipulations as code using it https://git.kernel.org/mkp/scsi/c/11d8e56bfd3f [37/40] scsi: sym53c8xx_2: Add missing description for 'pdev' https://git.kernel.org/mkp/scsi/c/633e19b57110 [38/40] scsi: sym53c8xx_2: Ensure variable has the same stipulations as code using it https://git.kernel.org/mkp/scsi/c/101706dc0a46 [39/40] scsi: mvsas: Move 'core_nr' inside #ifdef and remove unused variable 'res_flag' https://git.kernel.org/mkp/scsi/c/6eaa862747ea [40/40] scsi: cxgb3i: Remove bad documentation and demote kerneldoc header https://git.kernel.org/mkp/scsi/c/f27e1bbc5cb2
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This brings the total of W=1 SCSI wanings from 1690 in v5.8-rc1 to 817. Lee Jones (40): scsi: arcmsr: arcmsr_hba: Remove statement with no effect scsi: aic7xxx: aic79xx_core: Remove a bunch of unused variables scsi: aacraid: sa: Add descriptions for missing parameters scsi: aacraid: rkt: Add missing description for 'dev' scsi: aacraid: nark: Add missing description for 'dev' scsi: aic94xx: aic94xx_dev: Fix a couple of kerneldoc formatting issues scsi: aacraid: src: Add descriptions for missing parameters scsi: aic94xx: aic94xx_tmf: Fix kerneldoc formatting issue with 'task' scsi: pm8001: pm8001_sas: Fix strncpy() warning scsi: pm8001: pm8001_sas: Mover function header and supply some missing parameter descriptions scsi: pm8001: pm8001_ctl: Add descriptions for unused 'attr' function parameters scsi: qla4xxx: ql4_init: Remove set but unused variable 'func_number' scsi: qla4xxx: ql4_init: Check return value of pci_set_mwi() scsi: qla4xxx: ql4_83xx: Move 'qla4_83xx_reg_tbl' from shared header scsi: aic7xxx: aic79xx_core: Remove set but unused variables 'targ_info' and 'value' scsi: pm8001: pm8001_hwi: Fix a bunch of kerneldoc issues scsi: pm8001: pm80xx_hwi: Fix some function documentation issues scsi: pm8001: pm8001_hwi: Remove a bunch of set but unused variables scsi: qla4xxx: ql4_nx: Move 'qla4_82xx_reg_tbl' to the only place its used scsi: lpfc: lpfc_sli: Remove unused variable 'pg_addr' scsi: qla4xxx: ql4_mbx: Fix-up incorrectly documented parameter scsi: qla4xxx: ql4_iocb: Fix incorrectly named function parameter scsi: lpfc: lpfc_sli: Fix-up around 120 documentation issues scsi: pm8001: pm8001_hwi: Remove unused variable 'value' scsi: pm8001: pm80xx_hwi: Staticify 'pm80xx_pci_mem_copy' and 'mpi_set_phy_profile_req' scsi: qla4xxx: ql4_os: Fix some kerneldoc parameter documentation issues scsi: qla4xxx: ql4_isr: Repair function documentation headers scsi: lpfc: lpfc_mem: Provide description for lpfc_mem_alloc()'s 'align' param scsi: qla4xxx: ql4_init: Document qla4xxx_process_ddb()'s 'conn_err' scsi: lpfc: lpfc_ct: Fix-up formatting/docrot where appropriate scsi: csiostor: csio_init: Fix misnamed function parameter scsi: qla4xxx: ql4_nx: Remove three set but unused variables scsi: qla4xxx: ql4_nx: Supply description for 'code' scsi: csiostor: csio_lnode: Demote kerneldoc that fails to meet the criteria scsi: bfa: bfad_bsg: Staticify all local functions scsi: lpfc: lpfc_sli: Ensure variable has the same stipulations as code using it scsi: sym53c8xx_2: sym_glue: Add missing description for 'pdev' scsi: sym53c8xx_2: sym_hipd: Ensure variable has the same stipulations as code using it scsi: mvsas: mv_init: Move 'core_nr' inside #ifdef and remove unused variable 'res_flag' scsi: cxgbi: cxgb3i: cxgb3i: Remove bad documentation and demote kerneldoc header drivers/scsi/aacraid/nark.c | 1 + drivers/scsi/aacraid/rkt.c | 5 +- drivers/scsi/aacraid/sa.c | 19 ++- drivers/scsi/aacraid/src.c | 13 +- drivers/scsi/aic7xxx/aic79xx_core.c | 20 +-- drivers/scsi/aic94xx/aic94xx_dev.c | 4 +- drivers/scsi/aic94xx/aic94xx_tmf.c | 2 +- drivers/scsi/arcmsr/arcmsr_hba.c | 3 - drivers/scsi/bfa/bfad_bsg.c | 222 ++++++++++++++-------------- drivers/scsi/csiostor/csio_init.c | 2 +- drivers/scsi/csiostor/csio_lnode.c | 3 +- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 13 +- drivers/scsi/lpfc/lpfc_ct.c | 10 +- drivers/scsi/lpfc/lpfc_mem.c | 1 + drivers/scsi/lpfc/lpfc_sli.c | 125 ++++++++++------ drivers/scsi/mvsas/mv_init.c | 9 +- drivers/scsi/pm8001/pm8001_ctl.c | 9 +- drivers/scsi/pm8001/pm8001_hwi.c | 30 ++-- drivers/scsi/pm8001/pm8001_sas.c | 11 +- drivers/scsi/pm8001/pm80xx_hwi.c | 23 +-- drivers/scsi/qla4xxx/ql4_83xx.h | 17 --- drivers/scsi/qla4xxx/ql4_init.c | 6 +- drivers/scsi/qla4xxx/ql4_iocb.c | 2 +- drivers/scsi/qla4xxx/ql4_isr.c | 6 +- drivers/scsi/qla4xxx/ql4_mbx.c | 7 +- drivers/scsi/qla4xxx/ql4_nx.c | 18 +-- drivers/scsi/qla4xxx/ql4_nx.h | 17 --- drivers/scsi/qla4xxx/ql4_os.c | 58 ++++++-- drivers/scsi/sym53c8xx_2/sym_glue.c | 1 + drivers/scsi/sym53c8xx_2/sym_hipd.c | 8 + 30 files changed, 354 insertions(+), 311 deletions(-)