| Message ID | 1596096304-16422-1-git-send-email-henry.yen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | thermal: mediatek: Fix missing selection | expand |
Hi Henry, cc'ing Arnd On 30/07/2020 10:05, Henry Yen wrote: > Mediatek thermal driver is compatible with multiple platforms. > Some of the platforms (e.g., MT2701) requires to enable > MEDIATEK_MT6577_AUXADC option. If lacks the config, the driver > will not be able to read correct temperature. > > To fix it, select missing MEDIATEK_MT6577_AUXADC config. The description states there is a dependency for some platforms not all of them. The change will select the option every time for any mediatek platform or compile test. I don't think it is the place to select the option. > Signed-off-by: Henry Yen <henry.yen@mediatek.com> > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 3eb2348e5242..3a37f674f7f3 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -409,6 +409,7 @@ config MTK_THERMAL > depends on NVMEM || NVMEM=n > depends on RESET_CONTROLLER > default y > + select MEDIATEK_MT6577_AUXADC > help > Enable this option if you want to have support for thermal management > controller present in Mediatek SoCs >
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 3eb2348e5242..3a37f674f7f3 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -409,6 +409,7 @@ config MTK_THERMAL depends on NVMEM || NVMEM=n depends on RESET_CONTROLLER default y + select MEDIATEK_MT6577_AUXADC help Enable this option if you want to have support for thermal management controller present in Mediatek SoCs
Mediatek thermal driver is compatible with multiple platforms. Some of the platforms (e.g., MT2701) requires to enable MEDIATEK_MT6577_AUXADC option. If lacks the config, the driver will not be able to read correct temperature. To fix it, select missing MEDIATEK_MT6577_AUXADC config. Signed-off-by: Henry Yen <henry.yen@mediatek.com> --- drivers/thermal/Kconfig | 1 + 1 file changed, 1 insertion(+)