| Message ID | 20200807174954.14448-3-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | r8a7742: Enable DU and LVDS | expand |
Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > Add direct support for the r8a7742 (RZ/G1H). > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > (R-Car H2) so that device info structure is reused, the only difference > being TCON is unsupported on RZ/G1H (Currently unsupported by the driver). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 3e67cf70f040..7e286c7a7a6c 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { > .channels_mask = BIT(2) | BIT(1) | BIT(0), > .routes = { > /* > - * R8A7790 has one RGB output, two LVDS outputs and one > - * (currently unsupported) TCON output. > + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally > + * R8A7790 supports one TCON output (currently unsupported by the driver). Once we support TCON we'll have to split this, but for now I suppose it's fine. Would you however mind wrapping this to 80 columns ? I can do so when applying if it's fine with you. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > */ > [RCAR_DU_OUTPUT_DPAD0] = { > .possible_crtcs = BIT(2) | BIT(1) | BIT(0), > @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > }; > > static const struct of_device_id rcar_du_of_table[] = { > + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
Hi Laurent, Thank you for the review. On Sat, Aug 8, 2020 at 10:02 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > > Add direct support for the r8a7742 (RZ/G1H). > > > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > > (R-Car H2) so that device info structure is reused, the only difference > > being TCON is unsupported on RZ/G1H (Currently unsupported by the driver). > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > --- > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > index 3e67cf70f040..7e286c7a7a6c 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { > > .channels_mask = BIT(2) | BIT(1) | BIT(0), > > .routes = { > > /* > > - * R8A7790 has one RGB output, two LVDS outputs and one > > - * (currently unsupported) TCON output. > > + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally > > + * R8A7790 supports one TCON output (currently unsupported by the driver). > > Once we support TCON we'll have to split this, but for now I suppose > it's fine. Would you however mind wrapping this to 80 columns ? I can do > so when applying if it's fine with you. > Agreed once TCON is added this has to be split. But isn't the column size has been increased (checkpatch too doesn't complain about), but feel free to wrapp it for 80 columns. Cheers, Prabhakar > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > */ > > [RCAR_DU_OUTPUT_DPAD0] = { > > .possible_crtcs = BIT(2) | BIT(1) | BIT(0), > > @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > > }; > > > > static const struct of_device_id rcar_du_of_table[] = { > > + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, > > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > > -- > Regards, > > Laurent Pinchart
Hi Prabhakar, On Sun, Aug 09, 2020 at 09:38:05PM +0100, Lad, Prabhakar wrote: > On Sat, Aug 8, 2020 at 10:02 PM Laurent Pinchart wrote: > > On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > > > Add direct support for the r8a7742 (RZ/G1H). > > > > > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > > > (R-Car H2) so that device info structure is reused, the only difference > > > being TCON is unsupported on RZ/G1H (Currently unsupported by the driver). > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > --- > > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > > index 3e67cf70f040..7e286c7a7a6c 100644 > > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > > @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { > > > .channels_mask = BIT(2) | BIT(1) | BIT(0), > > > .routes = { > > > /* > > > - * R8A7790 has one RGB output, two LVDS outputs and one > > > - * (currently unsupported) TCON output. > > > + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally > > > + * R8A7790 supports one TCON output (currently unsupported by the driver). > > > > Once we support TCON we'll have to split this, but for now I suppose > > it's fine. Would you however mind wrapping this to 80 columns ? I can do > > so when applying if it's fine with you. > > Agreed once TCON is added this has to be split. But isn't the column > size has been increased (checkpatch too doesn't complain about), but It has, but it doesn't mean it's mandatory to increase line length :-) I think aligning with the style of the existing code should be favoured. > feel free to wrapp it for 80 columns. OK, I'll do that. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > */ > > > [RCAR_DU_OUTPUT_DPAD0] = { > > > .possible_crtcs = BIT(2) | BIT(1) | BIT(0), > > > @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > > > }; > > > > > > static const struct of_device_id rcar_du_of_table[] = { > > > + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, > > > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > > > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > > > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 3e67cf70f040..7e286c7a7a6c 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { .channels_mask = BIT(2) | BIT(1) | BIT(0), .routes = { /* - * R8A7790 has one RGB output, two LVDS outputs and one - * (currently unsupported) TCON output. + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally + * R8A7790 supports one TCON output (currently unsupported by the driver). */ [RCAR_DU_OUTPUT_DPAD0] = { .possible_crtcs = BIT(2) | BIT(1) | BIT(0), @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { }; static const struct of_device_id rcar_du_of_table[] = { + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },