diff mbox series

ci: fix stall on git log -1

Message ID 20200811191035.13948-1-william.c.roberts@intel.com (mailing list archive)
State Accepted
Headers show
Series ci: fix stall on git log -1 | expand

Commit Message

William Roberts Aug. 11, 2020, 7:10 p.m. UTC 
From: William Roberts <william.c.roberts@intel.com>

git log -1 may use a pager to output long messages, and when the pager
is invoked, leads to stalls on the ci system waiting for user input.
Use --oneline to print the short part of the commit message and
the digest. This information is for debug/informational purposes only,
so truncating the output is sufficient.

Reported-by: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: William Roberts <william.c.roberts@intel.com>
---

Thanks Ondrej for pointing out that the culprit was the pager, many
thanks for triaging this.

 scripts/ci/fedora-test-runner.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Smalley Aug. 11, 2020, 7:16 p.m. UTC | #1 
On Tue, Aug 11, 2020 at 3:11 PM <bill.c.roberts@gmail.com> wrote:
>
> From: William Roberts <william.c.roberts@intel.com>
>
> git log -1 may use a pager to output long messages, and when the pager
> is invoked, leads to stalls on the ci system waiting for user input.
> Use --oneline to print the short part of the commit message and
> the digest. This information is for debug/informational purposes only,
> so truncating the output is sufficient.
>
> Reported-by: Stephen Smalley <sds@tycho.nsa.gov>
> Signed-off-by: William Roberts <william.c.roberts@intel.com>

Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
William Roberts Aug. 11, 2020, 7:51 p.m. UTC | #2 
On Tue, Aug 11, 2020 at 2:16 PM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Tue, Aug 11, 2020 at 3:11 PM <bill.c.roberts@gmail.com> wrote:
> >
> > From: William Roberts <william.c.roberts@intel.com>
> >
> > git log -1 may use a pager to output long messages, and when the pager
> > is invoked, leads to stalls on the ci system waiting for user input.
> > Use --oneline to print the short part of the commit message and
> > the digest. This information is for debug/informational purposes only,
> > so truncating the output is sufficient.
> >
> > Reported-by: Stephen Smalley <sds@tycho.nsa.gov>
> > Signed-off-by: William Roberts <william.c.roberts@intel.com>
>
> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>

Staged:
https://github.com/SELinuxProject/selinux/pull/259
William Roberts Aug. 11, 2020, 10:01 p.m. UTC | #3 
merged:
https://github.com/SELinuxProject/selinux/pull/259

On Tue, Aug 11, 2020 at 2:51 PM William Roberts
<bill.c.roberts@gmail.com> wrote:
>
> On Tue, Aug 11, 2020 at 2:16 PM Stephen Smalley
> <stephen.smalley.work@gmail.com> wrote:
> >
> > On Tue, Aug 11, 2020 at 3:11 PM <bill.c.roberts@gmail.com> wrote:
> > >
> > > From: William Roberts <william.c.roberts@intel.com>
> > >
> > > git log -1 may use a pager to output long messages, and when the pager
> > > is invoked, leads to stalls on the ci system waiting for user input.
> > > Use --oneline to print the short part of the commit message and
> > > the digest. This information is for debug/informational purposes only,
> > > so truncating the output is sufficient.
> > >
> > > Reported-by: Stephen Smalley <sds@tycho.nsa.gov>
> > > Signed-off-by: William Roberts <william.c.roberts@intel.com>
> >
> > Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
>
> Staged:
> https://github.com/SELinuxProject/selinux/pull/259
diff mbox series

Patch

diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh
index 0aaba87c421b..782189630569 100755
--- a/scripts/ci/fedora-test-runner.sh
+++ b/scripts/ci/fedora-test-runner.sh
@@ -67,7 +67,7 @@  dnf install -y \
 cd "$SELINUX_DIR"
 
 # Show HEAD commit for sanity checking
-git log -1
+git log --oneline -1
 
 #
 # Build and replace userspace components