| Message ID | 20200811095336.32396-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: hda/hdmi: Use force connectivity quirk on another HP desktop | expand |
Hi, > On Aug 11, 2020, at 17:53, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: > > There's another HP desktop has buggy BIOS which flags the Port > Connectivity bit as no connection. > > Apply force connectivity quirk to enable DP/HDMI audio. > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> I guess this patch was omitted as well... Kai-Heng > --- > sound/pci/hda/patch_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 4bbd12d3b1b5..b8c8490e568b 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) > } > > static const struct snd_pci_quirk force_connect_list[] = { > + SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), > SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), > {} > }; > -- > 2.17.1 >
On Wed, 12 Aug 2020 17:43:27 +0200, Kai-Heng Feng wrote: > > Hi, > > > On Aug 11, 2020, at 17:53, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: > > > > There's another HP desktop has buggy BIOS which flags the Port > > Connectivity bit as no connection. > > > > Apply force connectivity quirk to enable DP/HDMI audio. > > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > I guess this patch was omitted as well... Not omitted but applied to a wrong internal branch, sorry. Now I rebased to the proper branch and pushed out. thanks, Takashi > > Kai-Heng > > > --- > > sound/pci/hda/patch_hdmi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > > index 4bbd12d3b1b5..b8c8490e568b 100644 > > --- a/sound/pci/hda/patch_hdmi.c > > +++ b/sound/pci/hda/patch_hdmi.c > > @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) > > } > > > > static const struct snd_pci_quirk force_connect_list[] = { > > + SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), > > SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), > > {} > > }; > > -- > > 2.17.1 > > >
> On Aug 12, 2020, at 23:47, Takashi Iwai <tiwai@suse.de> wrote: > > On Wed, 12 Aug 2020 17:43:27 +0200, > Kai-Heng Feng wrote: >> >> Hi, >> >>> On Aug 11, 2020, at 17:53, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: >>> >>> There's another HP desktop has buggy BIOS which flags the Port >>> Connectivity bit as no connection. >>> >>> Apply force connectivity quirk to enable DP/HDMI audio. >>> >>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> >> I guess this patch was omitted as well... > > Not omitted but applied to a wrong internal branch, sorry. > Now I rebased to the proper branch and pushed out. Thanks a lot! Kai-Heng > > > thanks, > > Takashi > >> >> Kai-Heng >> >>> --- >>> sound/pci/hda/patch_hdmi.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c >>> index 4bbd12d3b1b5..b8c8490e568b 100644 >>> --- a/sound/pci/hda/patch_hdmi.c >>> +++ b/sound/pci/hda/patch_hdmi.c >>> @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) >>> } >>> >>> static const struct snd_pci_quirk force_connect_list[] = { >>> + SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), >>> SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), >>> {} >>> }; >>> -- >>> 2.17.1 >>> >>
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 4bbd12d3b1b5..b8c8490e568b 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1863,6 +1863,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) } static const struct snd_pci_quirk force_connect_list[] = { + SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), {} };
There's another HP desktop has buggy BIOS which flags the Port Connectivity bit as no connection. Apply force connectivity quirk to enable DP/HDMI audio. Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- sound/pci/hda/patch_hdmi.c | 1 + 1 file changed, 1 insertion(+)