| Message ID | 20200816233934.1573-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] block: blk-mq.c: fix @at_head kernel-doc warning | expand |
On 8/16/20 4:39 PM, Randy Dunlap wrote: > Fix a new kernel-doc warning in block/blk-mq.c: > > ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert' Replaced the previous one - and since I was doing that anyway, I removed the 'new' from the commit message. Looks like it was from 5.6, so not what I'd call new.
On 8/16/20 4:50 PM, Jens Axboe wrote: > On 8/16/20 4:39 PM, Randy Dunlap wrote: >> Fix a new kernel-doc warning in block/blk-mq.c: >> >> ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert' > > Replaced the previous one - and since I was doing that anyway, I removed > the 'new' from the commit message. Looks like it was from 5.6, so not > what I'd call new. Yes, I just hadn't seen it before and I check pretty carefully. thanks.
--- lnx-59-rc1.orig/block/blk-mq.c +++ lnx-59-rc1/block/blk-mq.c @@ -1834,6 +1834,7 @@ void __blk_mq_insert_request(struct blk_ /** * blk_mq_request_bypass_insert - Insert a request at dispatch list. * @rq: Pointer to request to be inserted. + * @at_head: true if the request should be inserted at the head of the list. * @run_queue: If we should run the hardware queue after inserting the request. * * Should only be used carefully, when the caller knows we want to
Fix a new kernel-doc warning in block/blk-mq.c: ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert' Fixes: 01e99aeca397 ("blk-mq: insert passthrough request into hctx->dispatch directly") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: André Almeida <andrealmeid@collabora.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Ming Lei <ming.lei@redhat.com> Cc: linux-block@vger.kernel.org --- v2: correct Fixes: Commit-ID + Cc: to author. block/blk-mq.c | 1 + 1 file changed, 1 insertion(+)